[
https://issues.apache.org/jira/browse/HTTPASYNC-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807118#comment-17807118
]
tassadar commented on HTTPASYNC-171:
Thanks [~olegk], so there's no way to force?
[
https://issues.apache.org/jira/browse/HTTPCORE-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807126#comment-17807126
]
ASF subversion and git services commented on HTTPCORE-763:
--
Co
[
https://issues.apache.org/jira/browse/HTTPCORE-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807129#comment-17807129
]
Oleg Kalnichevski commented on HTTPCORE-763:
[~turing85] I cherry-picked th
[
https://issues.apache.org/jira/browse/HTTPASYNC-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807148#comment-17807148
]
Oleg Kalnichevski commented on HTTPASYNC-171:
-
[~tassadar] Of course, ther
ok2c closed pull request #535: Fixes createSocket being called with null proxy
when proxy is null
URL: https://github.com/apache/httpcomponents-client/pull/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Sineaggi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453711034
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory
Sineaggi commented on PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1894145035
> > As it stands, there's no way for createSocket(HttpContext to be called
anymore
>
> @Sineaggi So what? This method will get removed in the next major release.
Sineaggi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453719670
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory
Sineaggi commented on PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1894157759
If going forward the design of the connection factory class ought to use the
new `createSocket(proxy, context)` method, for the sake of existing users of
the library would y
ok2c commented on PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1894384361
> would you be alright with modifying the existing overloads of createSocket
in SSL and PlainConnectionFactory to call the previous createSocket method on
null?
@Sineaggi
Sineaggi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453719670
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory
Sineaggi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453711034
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory
ok2c commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453956084
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
Sineaggi opened a new pull request, #536:
URL: https://github.com/apache/httpcomponents-client/pull/536
In order to allow for backwards-compatibility with projects that
override/extend the existing plain and ssl connection factories, we'll specify
the createSocket(Proxy, HttpContext) method
Sineaggi commented on PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1894436596
@ok2c Here's the PR https://github.com/apache/httpcomponents-client/pull/536
with the proposed changes.
--
This is an automated message from the Apache Git Service.
To res
ok2c merged PR #536:
URL: https://github.com/apache/httpcomponents-client/pull/536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c commented on PR #536:
URL:
https://github.com/apache/httpcomponents-client/pull/536#issuecomment-1894483150
@Sineaggi Also cherry-picked to `5.3.x`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Sineaggi commented on PR #536:
URL:
https://github.com/apache/httpcomponents-client/pull/536#issuecomment-1894531632
@ok2c thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
18 matches
Mail list logo
