Sineaggi commented on PR #535: URL: https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1894157759
If going forward the design of the connection factory class ought to use the new `createSocket(proxy, context)` method, for the sake of existing users of the library would you be alright with modifying the existing overloads of createSocket in SSL and PlainConnectionFactory to call the previous createSocket method on null? For example, like the following ```java httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java return proxy != null ? new Socket(proxy) : createSocket(context); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
