Sineaggi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453719670
##########
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##########
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
@Override
public Socket createSocket(final Proxy proxy, final HttpContext context)
throws IOException {
- return proxy != null ? new Socket(proxy) : new Socket();
Review Comment:
> one must be aware of risks of tight coupling through inheritance and risks
of subclassing a concrete class and overriding methods that were not meant for
extension in the first place
The class in question has no private fields and no hidden internal logic,
and has existed virtually unmodified since 2012. Without warning, this public
and non-final class has had a breaking change made to its behavior in a patch
release of this library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
