ok2c commented on PR #501:
URL:
https://github.com/apache/httpcomponents-client/pull/501#issuecomment-1793709117
@arturobernalg Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ok2c commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382557118
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@ ManagedHttpClientConnection get
arturobernalg commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382565133
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@ ManagedHttpClientConne
kkewwei opened a new pull request, #442:
URL: https://github.com/apache/httpcomponents-core/pull/442
Support setting TCP_KEEPIDLE, TCP_KEEPINTERVAL, TCP_KEEPCOUNT in Socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ok2c commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382593572
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@ ManagedHttpClientConnection get
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382594611
##
httpcore5/src/main/java/org/apache/hc/core5/net/ExtendedSocketOptions.java:
##
@@ -0,0 +1,49 @@
+/*
+ * =
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-1793766886
@kkewwei Also there are test failures with Java 1.8
```
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.008 s <<< FAILURE! - in org.apache.hc.core5.
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382621660
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import org.ap
kkewwei commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382699123
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import org
