arturobernalg commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382565133
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##########
@@ -357,7 +357,19 @@ ManagedHttpClientConnection getConnection(final HttpRoute
route, final Object st
this.conn = this.connFactory.createConnection(null);
this.created = System.currentTimeMillis();
} else {
- this.conn.activate();
+ // Check if the existing connection is stale
+ if (this.conn.isStale()) {
Review Comment:
> Should not the connection have already been checked for staleness in
`#validate` line 355? Why doing again? Am I missing something?
@ok2c
The staleness check was only being performed when the deadline had expired.
In our case, the deadline wasn't expired, so the connection's staleness wasn't
being evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
