ok2c commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382557118
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##########
@@ -357,7 +357,19 @@ ManagedHttpClientConnection getConnection(final HttpRoute
route, final Object st
this.conn = this.connFactory.createConnection(null);
this.created = System.currentTimeMillis();
} else {
- this.conn.activate();
+ // Check if the existing connection is stale
+ if (this.conn.isStale()) {
Review Comment:
@arturobernalg Should not the connection have already been checked for
staleness in `#validate` line 355? Why doing again? Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
