Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164323292 > It seems that the effected ResponseTimeout is being rounded up to the nearest second, and milliseconds are not taking effect. @lethinker Socket timeout granularity of a

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164276512 > @ok2c @rschmitt can you help me with the problem when I use the httpAsyncClient( httpclient 5.4.3 、jdk 21) First, I set a 100-second sleep on the server side to ensure th

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164182716 @ok2c @rschmitt can you help me with the problem when I use the httpAsyncClient( httpclient 5.4.3 、jdk 21) First, I set a 100-second sleep on the server side to ensure t

Re: [PR] HTTPCLIENT-2386: Classic transport to use connect timeout as a default if TLS timeout has not been explicitly set [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on PR #699: URL: https://github.com/apache/httpcomponents-client/pull/699#issuecomment-3163033158 > Where is the original soTimeout restored after the handshake is completed? @rschmitt Good catch. Please do another pass. -- This is an automated message from the Apach

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259386248 ## httpcore5/src/test/java/org/apache/hc/core5/io/TestSocketSupport.java: ## @@ -38,6 +38,7 @@ import org.junit.jupiter.api.Assertions; import org.junit.jupit

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259384299 ## httpcore5/src/main/java/org/apache/hc/core5/io/SocketSupport.java: ## @@ -36,8 +36,11 @@ /** * @since 5.3 + * + * @deprecated No longer necessary, due t

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2259331530 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(fina

Re: [PR] Enable new TcpKeepAlive options on Java 8 [httpcomponents-client]

2025-08-06 Thread via GitHub
garydgregory commented on PR #701: URL: https://github.com/apache/httpcomponents-client/pull/701#issuecomment-3161831611 Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-06 Thread via GitHub
rschmitt opened a new pull request, #542: URL: https://github.com/apache/httpcomponents-core/pull/542 The extended socket options related to TCP Keep-Alive were backported to Java 8 over five years ago. We can simply enable them directly without having to use reflection. Related: htt

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-06 Thread via GitHub
rschmitt commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2258400165 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(

[PR] Enable new TcpKeepAlive options on Java 8 [httpcomponents-client]

2025-08-06 Thread via GitHub
rschmitt opened a new pull request, #701: URL: https://github.com/apache/httpcomponents-client/pull/701 This change sets the new KeepAlive-related options directly through the JDK, instead of going through `SocketSupport`. There are two reasons for this. First, the `SocketSupport` cod

Re: [PR] Transparent async content (de)compression with gzip [httpcomponents-client]

2025-08-06 Thread via GitHub
ok2c commented on code in PR #700: URL: https://github.com/apache/httpcomponents-client/pull/700#discussion_r2257898110 ## httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/DeflatingGzipEntityProducer.java: ## @@ -0,0 +1,250 @@ +/* + * =

Re: [PR] HTTPCLIENT-2386: Classic transport to use connect timeout as a default if TLS timeout has not been explicitly set [httpcomponents-client]

2025-08-05 Thread via GitHub
garydgregory commented on PR #699: URL: https://github.com/apache/httpcomponents-client/pull/699#issuecomment-3156185714 👍 I think this will help a lot of users that get confused by what timeout kicks in when. -- This is an automated message from the Apache Git Service. To respond to the

[PR] Transparent async content (de)compression with gzip [httpcomponents-client]

2025-08-05 Thread via GitHub
arturobernalg opened a new pull request, #700: URL: https://github.com/apache/httpcomponents-client/pull/700 Adds `InflatingGzipDataConsumer,` `DeflatingGzipEntityProducer` and example/tests so the async client automatically advertises gzip, inflates gzip/ responses on the fly and streams

Re: [PR] Unsupported content encoding to be treated as an error [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c merged PR #698: URL: https://github.com/apache/httpcomponents-client/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-05 Thread via GitHub
arturobernalg closed pull request #694: HTTPCLIENT-2386: Fix TLS handshake timeout precedence URL: https://github.com/apache/httpcomponents-client/pull/694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-05 Thread via GitHub
arturobernalg commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3155072359 Closing in favor of [88c19c0](https://github.com/apache/httpcomponents-client/pull/699/commits/88c19c009628750fa6f84b7635fc46b72e439edb) -- This is an automated messa

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2253819023 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(fina

[PR] HTTPCLIENT-2386: Classic transport to use connect timeout as a default if TLS timeout has not been explicitly set [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c opened a new pull request, #699: URL: https://github.com/apache/httpcomponents-client/pull/699 This change-set re-aligns the behavior of the classic and async connection operations and makes both transports use connect timeout as a fallback value for the TLS timeout when explicitly set

[PR] Unsupported content encoding to be treated as an error [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c opened a new pull request, #698: URL: https://github.com/apache/httpcomponents-client/pull/698 Treat unsupported content encoding as an error. @arturobernalg Please double-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c commented on PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#issuecomment-3153996645 Committed as 3fbbd2237216a74cceacf8458655ff19d0120bb4. @arturobernalg Very good job -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-05 Thread via GitHub
ok2c closed pull request #681: HTTPCLIENT-1822: async transparent content decompression URL: https://github.com/apache/httpcomponents-client/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-04 Thread via GitHub
rschmitt commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2252475258 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-04 Thread via GitHub
arturobernalg commented on PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#issuecomment-3151496357 > @arturobernalg Two things still need to be fixed. > > Alternatively I can pull in your change, tweak them a bit and commit it. @ok2c I just made the missi

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-04 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2251978170 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java: ## @@ -0,0 +1,208 @@ +/* + *

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-04 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2251974219 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java: ## @@ -0,0 +1,208 @@ +/* + *

Re: [PR] Add fully-streaming async GZIP producer/consumer [httpcomponents-client]

2025-08-03 Thread via GitHub
arturobernalg closed pull request #688: Add fully-streaming async GZIP producer/consumer URL: https://github.com/apache/httpcomponents-client/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-03 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2250076282 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java: ## @@ -0,0 +1,208 @@ +/* + *

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-03 Thread via GitHub
arturobernalg commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2250046172 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java: ## @@ -0,0 +1,171 @@ +/* + * ===

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-03 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2250022183 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientDeflatePostExample.java: ## @@ -0,0 +1,110 @@ +/* + *

Re: [PR] [HTTPCLIENT-2178] Implement Happy Eyeballs V2 (RFC 8305) [httpcomponents-client]

2025-08-03 Thread via GitHub
ok2c commented on PR #693: URL: https://github.com/apache/httpcomponents-client/pull/693#issuecomment-3148485490 @rschmitt Could you please take a look at this PR as you are the requester of this feature? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Bug-fix: Corrected DecompressingEntity to return null Content-Encoding (no encoding) [httpcomponents-client]

2025-08-03 Thread via GitHub
ok2c merged PR #697: URL: https://github.com/apache/httpcomponents-client/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-08-02 Thread via GitHub
arturobernalg commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2249528066 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientInflateDecompressionExample.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-08-02 Thread via GitHub
ok2c merged PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[PR] Bug-fix: Corrected DecompressingEntity to return null Content-Encoding (no encoding) [httpcomponents-client]

2025-08-02 Thread via GitHub
ok2c opened a new pull request, #697: URL: https://github.com/apache/httpcomponents-client/pull/697 @arturobernalg I overlooked the problem with `Content-Encoding` property value returned by DecompressingEntity, Please double-check. -- This is an automated message from the Apache Git Serv

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-08-01 Thread via GitHub
arturobernalg commented on PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#issuecomment-3145262000 > > > @arturobernalg I do not think we need this. The root cause of the problem is HTTPCLIENT-2386. > > > > > > @ok2c This change is inspired by the discussion

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-08-01 Thread via GitHub
ok2c commented on PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#issuecomment-3145251494 > > @arturobernalg I do not think we need this. The root cause of the problem is HTTPCLIENT-2386. > > @ok2c This change is inspired by the discussion in mailing list thread:

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-08-01 Thread via GitHub
arturobernalg commented on PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#issuecomment-3145218820 > @arturobernalg I do not think we need this. The root cause of the problem is HTTPCLIENT-2386. @ok2c This change is inspired by the discussion in mailing list thr

[PR] Bump io.reactivex.rxjava3:rxjava from 3.1.10 to 3.1.11 [httpcomponents-client]

2025-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #696: URL: https://github.com/apache/httpcomponents-client/pull/696 Bumps [io.reactivex.rxjava3:rxjava](https://github.com/ReactiveX/RxJava) from 3.1.10 to 3.1.11. Release notes Sourced from https://github.com/ReactiveX/RxJava/releases";>i

[PR] Bump org.apache.commons:commons-compress from 1.27.1 to 1.28.0 [httpcomponents-client]

2025-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #695: URL: https://github.com/apache/httpcomponents-client/pull/695 Bumps [org.apache.commons:commons-compress](https://github.com/apache/commons-compress) from 1.27.1 to 1.28.0. Changelog Sourced from https://github.com/apache/commons-co

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-07-31 Thread via GitHub
ok2c commented on PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#issuecomment-3140966578 @arturobernalg I do not think we need this. The root cause of the problem is HTTPCLIENT-2386. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-07-31 Thread via GitHub
garydgregory commented on code in PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#discussion_r2246081591 ## httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java: ## @@ -166,10 +167,17 @@ void onTimeout(final Timeout timeout) throws I

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-07-31 Thread via GitHub
garydgregory commented on code in PR #541: URL: https://github.com/apache/httpcomponents-core/pull/541#discussion_r2246080997 ## httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java: ## @@ -166,10 +167,17 @@ void onTimeout(final Timeout timeout) throws I

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-07-31 Thread via GitHub
ok2c commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2246069191 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(fina

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-07-31 Thread via GitHub
ok2c commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2246066138 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(fina

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-31 Thread via GitHub
winfriedgerlach commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3140878878 @ok2c your wish is my command :-) changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-07-31 Thread via GitHub
arturobernalg opened a new pull request, #694: URL: https://github.com/apache/httpcomponents-client/pull/694 Changes TLS handshake timeout fallback from `connectTimeout` to `socketTimeout` when no explicit timeout is configured in `TlsConfig`. -- This is an automated message from the Apac

[PR] HTTPCLIENT-2386: Fix TLS handshake timeout handling [httpcomponents-core]

2025-07-31 Thread via GitHub
arturobernalg opened a new pull request, #541: URL: https://github.com/apache/httpcomponents-core/pull/541 Fix TLS handshake timeout handling ([HTTPCLIENT-2386](https://issues.apache.org/jira/browse/HTTPCLIENT-2386)) Use socketTimeout for TLS handshake and add dedicated timeout except

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-31 Thread via GitHub
ok2c commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3140797330 > > > > > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public > > > > > > > > > > > > @winfriedgerlach What is the reason those classes should

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-31 Thread via GitHub
winfriedgerlach commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3139518521 > > > > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public > > > > > > > > > @winfriedgerlach What is the reason those classes sho

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-31 Thread via GitHub
ok2c commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3139095303 > > > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public > > > > > > @winfriedgerlach What is the reason those classes should be made public?

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-31 Thread via GitHub
winfriedgerlach commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3138863137 > > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public > > @winfriedgerlach What is the reason those classes should be made public?

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-30 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2243581245 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientInflateDecompressionExample.java: ## @@ -0,0 +1,94 @@ +/* + *

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-30 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2243581245 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientInflateDecompressionExample.java: ## @@ -0,0 +1,94 @@ +/* + *

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2243545194 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientInflateDecompressionExample.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3136965295 > > Hi @arturobernalg, I am already using a custom connection factory to create my "instrumented connections". But that was not the question that I wanted to answer wit

Re: [PR] Implement HappyEyeballsV2AsyncClientConnectionOperator [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg commented on PR #527: URL: https://github.com/apache/httpcomponents-client/pull/527#issuecomment-3136902150 closing in favor of https://github.com/apache/httpcomponents-client/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Implement HappyEyeballsV2AsyncClientConnectionOperator [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg closed pull request #527: Implement HappyEyeballsV2AsyncClientConnectionOperator URL: https://github.com/apache/httpcomponents-client/pull/527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] [HTTPCLIENT-2178] Implement Happy Eyeballs V2 (RFC 8305) [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg opened a new pull request, #693: URL: https://github.com/apache/httpcomponents-client/pull/693 This pull request introduces a minimal implementation of Happy Eyeballs Version 2 (RFC 8305) for the asynchronous client connection operator in Apache HttpComponents Client 5.x. It f

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-30 Thread via GitHub
arturobernalg commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3136876685 > Hi @arturobernalg, I am already using a custom connection factory to create my "instrumented connections". But that was not the question that I wanted to answer with

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-30 Thread via GitHub
ok2c commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3136513807 > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public @winfriedgerlach What is the reason those classes should be made public? -- This is an a

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-30 Thread via GitHub
ok2c commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3136306127 > * make `DefaultManagedHttpClientConnection` and `DefaultManagedAsyncClientConnection` public non-final @winfriedgerlach I do not have a problem with making `DefaultMana

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-30 Thread via GitHub
winfriedgerlach commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3135887395 Hi @arturobernalg, I am already using a custom connection factory to create my "instrumented connections". But that was not the question that I wanted to answer with

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-29 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2240832900 ## httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/DeflatingAsyncEntityProducer.java: ## @@ -0,0 +1,240 @@ +/* + *

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-29 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2240824434 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java: ## @@ -0,0 +1,212 @@ +/* + *

Re: [PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-29 Thread via GitHub
arturobernalg commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3133421996 > Cf. https://issues.apache.org/jira/browse/HTTPCLIENT-2385: > > I'd like to improve extensibility of `DefaultManagedHttpClientConnection` and `DefaultManagedAsyn

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-29 Thread via GitHub
arturobernalg commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2240488876 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientDeflateCompressionExample.java: ## @@ -0,0 +1,106 @@ +/* + *

Re: [PR] Drop RxJava 2 [httpcomponents-core]

2025-07-29 Thread via GitHub
rschmitt merged PR #540: URL: https://github.com/apache/httpcomponents-core/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.

[PR] HTTPCLIENT-2385: make DefaultManagedHttpClientConnection and DefaultM… [httpcomponents-client]

2025-07-29 Thread via GitHub
winfriedgerlach opened a new pull request, #692: URL: https://github.com/apache/httpcomponents-client/pull/692 Cf. https://issues.apache.org/jira/browse/HTTPCLIENT-2385: I'd like to improve extensibility of `DefaultManagedHttpClientConnection` and `DefaultManagedAsyncClientConnection`

Re: [PR] Drop RxJava 2 [httpcomponents-core]

2025-07-29 Thread via GitHub
rschmitt commented on code in PR #540: URL: https://github.com/apache/httpcomponents-core/pull/540#discussion_r2240224383 ## pom.xml: ## @@ -232,6 +231,7 @@ true true +true Review Comment: No, I changed this by hand. This

Re: [PR] Drop RxJava 2 [httpcomponents-core]

2025-07-29 Thread via GitHub
rschmitt commented on code in PR #540: URL: https://github.com/apache/httpcomponents-core/pull/540#discussion_r2240224383 ## pom.xml: ## @@ -232,6 +231,7 @@ true true +true Review Comment: No, I changed this by hand. This

Re: [PR] Upgrade tests to RxJava 3 [httpcomponents-client]

2025-07-29 Thread via GitHub
rschmitt merged PR #691: URL: https://github.com/apache/httpcomponents-client/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-29 Thread via GitHub
ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2239596409 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientDeflateCompressionExample.java: ## @@ -0,0 +1,106 @@ +/* + * =

Re: [PR] fix JavaDoc for PoolingHttpClientConnectionManager [httpcomponents-client]

2025-07-29 Thread via GitHub
ok2c merged PR #690: URL: https://github.com/apache/httpcomponents-client/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

Re: [PR] Drop RxJava 2 [httpcomponents-core]

2025-07-29 Thread via GitHub
ok2c commented on code in PR #540: URL: https://github.com/apache/httpcomponents-core/pull/540#discussion_r2239502351 ## pom.xml: ## @@ -232,6 +231,7 @@ true true +true Review Comment: @rschmitt This is due to formatting,

Re: [PR] fix ContentType JavaDoc [httpcomponents-core]

2025-07-29 Thread via GitHub
ok2c commented on PR #539: URL: https://github.com/apache/httpcomponents-core/pull/539#issuecomment-3132045806 @winfriedgerlach Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] fix ContentType JavaDoc [httpcomponents-core]

2025-07-29 Thread via GitHub
ok2c merged PR #539: URL: https://github.com/apache/httpcomponents-core/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-28 Thread via GitHub
RayTigerZ closed pull request #689: remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 URL: https://github.com/apache/httpcomponents-client/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-28 Thread via GitHub
RayTigerZ commented on PR #689: URL: https://github.com/apache/httpcomponents-client/pull/689#issuecomment-3130328961 > > @ok2c Could you tell the purpose of the current dependency declaration? > > @RayTigerZ I understand this is a mater of taste. I personally like when mandatory dep

[PR] Drop RxJava 2 [httpcomponents-core]

2025-07-28 Thread via GitHub
rschmitt opened a new pull request, #540: URL: https://github.com/apache/httpcomponents-core/pull/540 RxJava 2 is end-of-life as of February 28, 2021. `ReactiveTestUtils` can probably be dropped for 5.6 in favor of `Reactive3TestUtils`. -- This is an automated message from the Apache Git

[PR] Upgrade tests to RxJava 3 [httpcomponents-client]

2025-07-28 Thread via GitHub
rschmitt opened a new pull request, #691: URL: https://github.com/apache/httpcomponents-client/pull/691 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] fix ContentType JavaDoc [httpcomponents-core]

2025-07-28 Thread via GitHub
winfriedgerlach opened a new pull request, #539: URL: https://github.com/apache/httpcomponents-core/pull/539 the whole point of `ContentType.parseLenient()` is to **not** throw `UnsupportedCharsetException`. This should be reflected in the JavaDoc. -- This is an automated message from the

[PR] fix JavaDoc for PoolingHttpClientConnectionManager [httpcomponents-client]

2025-07-28 Thread via GitHub
winfriedgerlach opened a new pull request, #690: URL: https://github.com/apache/httpcomponents-client/pull/690 in ancient history this class seems to have been renamed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-28 Thread via GitHub
ok2c commented on PR #689: URL: https://github.com/apache/httpcomponents-client/pull/689#issuecomment-3126375488 > @ok2c Could you tell the purpose of the current dependency declaration? @RayTigerZ I understand this is a mater of taste. I personally like when mandatory dependencies a

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-27 Thread via GitHub
RayTigerZ commented on PR #689: URL: https://github.com/apache/httpcomponents-client/pull/689#issuecomment-3124959828 @ok2c Could you tell the purpose of the current dependency declaration? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-27 Thread via GitHub
RayTigerZ commented on PR #689: URL: https://github.com/apache/httpcomponents-client/pull/689#issuecomment-3124952825 @ok2c it would simplify dependencies manager to httpcomponents-client and project that depended on httpcomponents-client -- This is an automated message from the Apache G

Re: [PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-27 Thread via GitHub
ok2c commented on PR #689: URL: https://github.com/apache/httpcomponents-client/pull/689#issuecomment-3124275802 @RayTigerZ What would be the benefit of doing so? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add TUNNEL_PROXY support to AsyncConnectExec for proxy chain tunneling [httpcomponents-client]

2025-07-27 Thread via GitHub
ok2c commented on PR #685: URL: https://github.com/apache/httpcomponents-client/pull/685#issuecomment-3124274857 > > @arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain? > > Then, we would also need to make similar changes

Re: [PR] Add fully-streaming async GZIP producer/consumer [httpcomponents-client]

2025-07-26 Thread via GitHub
garydgregory commented on code in PR #688: URL: https://github.com/apache/httpcomponents-client/pull/688#discussion_r2233030207 ## httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/GzipAsyncEntityConsumer.java: ## @@ -0,0 +1,331 @@ +/* + * =

[PR] remove dependency httpcore5: httpcore5-h2 is depend on httpcore5 [httpcomponents-client]

2025-07-26 Thread via GitHub
RayTigerZ opened a new pull request, #689: URL: https://github.com/apache/httpcomponents-client/pull/689 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add TUNNEL_PROXY support to AsyncConnectExec for proxy chain tunneling [httpcomponents-client]

2025-07-25 Thread via GitHub
arturobernalg commented on PR #685: URL: https://github.com/apache/httpcomponents-client/pull/685#issuecomment-3119499515 > @arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain? > > Then, we would also need to make simil

Re: [PR] HTTPCLIENT-2369: implemented HTTPS-proxy tunnelling (TLS-in-TLS) [httpcomponents-client]

2025-07-25 Thread via GitHub
garydgregory commented on PR #684: URL: https://github.com/apache/httpcomponents-client/pull/684#issuecomment-3119487725 > I didn't test it with a real case. Didn't have the way. Can't something be set up with Docker and then driven with a Docker Maven plugin? -- This is an automa

Re: [PR] HTTPCLIENT-2369: implemented HTTPS-proxy tunnelling (TLS-in-TLS) [httpcomponents-client]

2025-07-25 Thread via GitHub
arturobernalg commented on PR #684: URL: https://github.com/apache/httpcomponents-client/pull/684#issuecomment-3119463485 I didn't test it with a real case. Didn't have the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HTTPCLIENT-2369: implemented HTTPS-proxy tunnelling (TLS-in-TLS) [httpcomponents-client]

2025-07-25 Thread via GitHub
arturobernalg closed pull request #684: HTTPCLIENT-2369: implemented HTTPS-proxy tunnelling (TLS-in-TLS) URL: https://github.com/apache/httpcomponents-client/pull/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] Add fully-streaming async GZIP producer/consumer [httpcomponents-client]

2025-07-25 Thread via GitHub
arturobernalg opened a new pull request, #688: URL: https://github.com/apache/httpcomponents-client/pull/688 Adds streaming async support for Content-Encoding: gzip. Includes `GzipAsyncEntityProducer` + `GzipAsyncEntityConsumer` with full header/trailer validation. Unit tests & tiny ex

[PR] Bump org.junit:junit-bom from 5.13.3 to 5.13.4 [httpcomponents-core]

2025-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #538: URL: https://github.com/apache/httpcomponents-core/pull/538 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit-framework) from 5.13.3 to 5.13.4. Release notes Sourced from https://github.com/junit-team/junit-framework/re

[PR] Bump org.junit:junit-bom from 5.13.3 to 5.13.4 [httpcomponents-client]

2025-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #686: URL: https://github.com/apache/httpcomponents-client/pull/686 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit-framework) from 5.13.3 to 5.13.4. Release notes Sourced from https://github.com/junit-team/junit-framework/

[PR] Bump commons-io:commons-io from 2.19.0 to 2.20.0 [httpcomponents-client]

2025-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #687: URL: https://github.com/apache/httpcomponents-client/pull/687 Bumps [commons-io:commons-io](https://github.com/apache/commons-io) from 2.19.0 to 2.20.0. Changelog Sourced from https://github.com/apache/commons-io/blob/master/RELEASE-

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-25 Thread via GitHub
arturobernalg commented on PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#issuecomment-3117147034 > build `DeflatingAsyncEntityProducer` and `InflatingAsyncEntityCunsumer` using `Deflater` / `Inflater` API directly @ok2c implemented. -- This is an automate

Re: [PR] HTTPCLIENT-1822: async transparent content decompression [httpcomponents-client]

2025-07-25 Thread via GitHub
ok2c commented on PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#issuecomment-3116846909 @arturobernalg I guess I failed to properly express myself. I actually thought you were going to build `DeflatingAsyncEntityProducer` and `InflatingAsyncEntityCunsumer` using `D

  1   2   3   4   5   6   7   8   9   10   >