winfriedgerlach commented on PR #692: URL: https://github.com/apache/httpcomponents-client/pull/692#issuecomment-3139518521
> > > > make LoggingInputStream, LoggingOutputStream, and LoggingSocketHolder public > > > > > > > > > @winfriedgerlach What is the reason those classes should be made public? > > > > > > OK @ok2c , I have reverted this change. I guess just having `DefaultManagedHttpClientConnection` public would do the job for me. > > @winfriedgerlach Can you also live with those classes being internal (annotated `@Internal`)? @ok2c I don't have an opinion on that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
