ok2c commented on PR #685: URL: https://github.com/apache/httpcomponents-client/pull/685#issuecomment-3124274857
> > @arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain? > > Then, we would also need to make similar changes to the classic `ConnectExec`. > > The classic already have a implementations --> https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java#L165 @arturobernalg That code is likely wrong or broken or both. There is not a single integration test case that exercises it. Instead of adding similarly broken code in the async pipeline we should rather remove it from the classic one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
