arturobernalg opened a new pull request, #608:
URL: https://github.com/apache/httpcomponents-client/pull/608
This PR addresses an issue where Unicode hostnames cause
UnknownHostException during DNS resolution. The change normalizes hostnames to
punycode using IDN.toASCII() before passing th
arturobernalg commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903320443
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,19 @@ private static boolean matchIdentit
ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903266673
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,19 @@ private static boolean matchIdentity(final S
LGTM
Arturo
On Sun, Jan 5, 2025 at 9:15 AM Oleg Kalnichevski wrote:
> Folks
>
> Please review the release notes for HttpCcore 5.3.2 and amend them as
> you deem necessary
>
> https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt
>
> Oleg
>
> --
LGTM (I made some minor adjustments).
Thanks Oleg.
Gary
On Sun, Jan 5, 2025 at 3:15 AM Oleg Kalnichevski wrote:
> Folks
>
> Please review the release notes for HttpCcore 5.3.2 and amend them as
> you deem necessary
>
> https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt
arturobernalg commented on PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#issuecomment-2571593409
> @arturobernalg Please note we still have a problem with punycode encoded
hostname resolution. We might address it in a separate PR though.
@ok2c I have fixed t
arturobernalg commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903250820
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,36 +229,44 @@ private static boolean matchIdenti
ok2c commented on PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#issuecomment-2571577681
@arturobernalg Please note we still have a problem with punycode encoded
hostname resolution. We might address it in a separate PR though.
--
This is an automated message from
ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903241427
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,36 +229,44 @@ private static boolean matchIdentity(final
arturobernalg commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903238928
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,18 @@ private static boolean matchIdentit
ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903236128
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,18 @@ private static boolean matchIdentity(final S
arturobernalg commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903232894
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,18 @@ private static boolean matchIdentit
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909851#comment-17909851
]
Oleg Kalnichevski edited comment on HTTPCLIENT-2353 at 1/5/25 8:48 AM:
---
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909851#comment-17909851
]
Oleg Kalnichevski commented on HTTPCLIENT-2353:
---
I think we have a gre
ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903220580
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##
@@ -228,8 +229,18 @@ private static boolean matchIdentity(final S
Folks
Please review the release notes for HttpCcore 5.3.2 and amend them as
you deem necessary
https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt
Oleg
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.
16 matches
Mail list logo