ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903236128
##########
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##########
@@ -228,8 +229,18 @@ private static boolean matchIdentity(final String host,
final String identity,
final PublicSuffixMatcher
publicSuffixMatcher,
final DomainType domainType,
final boolean strict) {
+
+ final String punycodeHost;
Review Comment:
> @ok2c you mean Instead of converting both strings to punycode, bring both
into the same Unicode form—i.e., use IDN.toUnicode(...) rather than
toASCII(...) ???
@arturobernalg That is exactly what I mean. This way one would not need to
normalize the hostname as it is has already been normalized to Unicode at the
construction time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
