ok2c commented on code in PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#discussion_r1903266673
##########
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java:
##########
@@ -228,8 +229,19 @@ private static boolean matchIdentity(final String host,
final String identity,
final PublicSuffixMatcher
publicSuffixMatcher,
final DomainType domainType,
final boolean strict) {
- if (publicSuffixMatcher != null && host.contains(".")) {
- if (publicSuffixMatcher.getDomainRoot(identity, domainType) ==
null) {
+
+ final String normalizedHost;
+ final String normalizedIdentity;
+ try {
+ normalizedHost = IDN.toUnicode(host);
Review Comment:
@arturobernalg This is unnecessary. The hostname has already been
normalized. Please see `Host` and `HttpHost` classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
