tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004716082
I've come across the idea for these metrics here
micrometer-metrics/micrometer#1617, so I cannot say i'm the only one who wants
these metrics, but the pool of people is certain
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004622070
> Is there a reason for not being able to add the
`HttpClientConnectionOperator` to the builder?
>
@tippl The are two reasons:
1. Internal interfaces ideally should
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828072#comment-17828072
]
Julian Reschke commented on HTTPCLIENT-2325:
> No, it is not. It is defi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828072#comment-17828072
]
Julian Reschke edited comment on HTTPCLIENT-2325 at 3/18/24 6:10 PM:
-
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski resolved HTTPCLIENT-2325.
---
Fix Version/s: 5.4-alpha3
Resolution: Fixed
> Avoid adding "; cha
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828069#comment-17828069
]
ASF subversion and git services commented on HTTPCLIENT-2325:
ok2c merged PR #556:
URL: https://github.com/apache/httpcomponents-client/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004560033
> One can subclass `PoolingHttpClientConnectionManager` and pass a custom
`HttpClientConnectionOperator` through the protected super constructor.
Is there a reason for no
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827974#comment-17827974
]
Oleg Kalnichevski commented on HTTPCLIENT-2325:
---
> The contents of for
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2003798399
> So there is no way to actually create a PoolingHttpClientConnectionManager
with a custom HttpClientConnectionOperator, either by itself or through the
Builder.
One can
ok2c commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528452045
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827948#comment-17827948
]
Julian Reschke commented on HTTPCLIENT-2325:
bq. vladimirsitnikov It may
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528412914
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528370944
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528368485
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528366507
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -88,7 +88,7 @@ public void testMultipartCustom
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528356852
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -99,7 +99,7 @@ public void testMultipartContentType
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528354232
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -88,7 +88,7 @@ public void testMultipartCustomConte
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528350724
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528332718
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827906#comment-17827906
]
Michael Osipov commented on HTTPCLIENT-2325:
not for me, all parts have
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827900#comment-17827900
]
Michael Osipov edited comment on HTTPCLIENT-2325 at 3/18/24 10:17 AM:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827905#comment-17827905
]
Oleg Kalnichevski commented on HTTPCLIENT-2325:
---
> What makes you thin
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827902#comment-17827902
]
Michael Osipov commented on HTTPCLIENT-2325:
[~vladimirsitnikov], I agre
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827900#comment-17827900
]
Michael Osipov commented on HTTPCLIENT-2325:
[~olegk], I do not agree wi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827898#comment-17827898
]
Oleg Kalnichevski commented on HTTPCLIENT-2325:
---
[~vladimirsitnikov] I
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827896#comment-17827896
]
Vladimir Sitnikov commented on HTTPCLIENT-2325:
---
E.g. see
https://git
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827891#comment-17827891
]
Michael Osipov commented on HTTPCLIENT-2325:
This is the same as with {{
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827890#comment-17827890
]
Oleg Kalnichevski commented on HTTPCLIENT-2325:
---
> Oleg, as they say i
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827888#comment-17827888
]
Vladimir Sitnikov commented on HTTPCLIENT-2325:
---
Oleg, as they say in
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827888#comment-17827888
]
Vladimir Sitnikov edited comment on HTTPCLIENT-2325 at 3/18/24 9:08 AM:
--
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827877#comment-17827877
]
Oleg Kalnichevski commented on HTTPCLIENT-2325:
---
[~vladimirsitnikov] A
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827871#comment-17827871
]
Michael Osipov edited comment on HTTPCLIENT-2325 at 3/18/24 8:26 AM:
-
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827871#comment-17827871
]
Michael Osipov commented on HTTPCLIENT-2325:
I consider this as a duplic
Vladimir Sitnikov created HTTPCLIENT-2325:
-
Summary: Avoid adding "; charset=" for multipart/form-data requests
Key: HTTPCLIENT-2325
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2325
P
35 matches
Mail list logo
