ok2c commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528452045
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##########
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
if (charsetCopy == null && contentType != null) {
charsetCopy = contentType.getCharset();
}
- final List<NameValuePair> paramsList = new ArrayList<>(2);
- paramsList.add(new BasicNameValuePair("boundary", boundaryCopy));
- if (charsetCopy != null) {
- paramsList.add(new BasicNameValuePair("charset",
charsetCopy.name()));
- }
- final NameValuePair[] params =
paramsList.toArray(EMPTY_NAME_VALUE_ARRAY);
+ // Previusly, "charset" parameter was added to the Content-Type
header, however adding "charset=..."
+ // is not specified in RFC 7578, and it causes issues with (flawed?)
HTTP servers.
+ // For instance:
+ //
https://github.com/owasp-modsecurity/ModSecurity/commit/6e56950cdf258c9b39f12cf6eb014cb59797cfd3
+ // https://github.com/akka/akka-http/issues/338
+ // https://bz.apache.org/bugzilla/show_bug.cgi?id=61384
+ final NameValuePair[] params = new NameValuePair[]{new
BasicNameValuePair("boundary", boundaryCopy)};
Review Comment:
>
> If you still think the code comment should be removed, I can easily do
that. It would make the maintenance harder though.
@vlsi Please remove that comment and move it to the commit message if you
like. Those who cannot work with the commit history should not be committing to
the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
