[GitHub] [httpcomponents-client] snehanie commented on pull request #488: Update MemcachedHttpCacheStorage.java

2023-09-29 Thread via GitHub
snehanie commented on PR #488: URL: https://github.com/apache/httpcomponents-client/pull/488#issuecomment-1741122926 Thank you for the fix. I was going to raise another pull request and you beat me to it. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [httpcomponents-core] dependabot[bot] opened a new pull request, #436: Bump io.reactivex.rxjava3:rxjava from 3.1.6 to 3.1.8

2023-09-29 Thread via GitHub
dependabot[bot] opened a new pull request, #436: URL: https://github.com/apache/httpcomponents-core/pull/436 Bumps [io.reactivex.rxjava3:rxjava](https://github.com/ReactiveX/RxJava) from 3.1.6 to 3.1.8. Release notes Sourced from https://github.com/ReactiveX/RxJava/releases";>io.re

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #420: Bump io.reactivex.rxjava3:rxjava from 3.1.6 to 3.1.7

2023-09-29 Thread via GitHub
dependabot[bot] closed pull request #420: Bump io.reactivex.rxjava3:rxjava from 3.1.6 to 3.1.7 URL: https://github.com/apache/httpcomponents-core/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #420: Bump io.reactivex.rxjava3:rxjava from 3.1.6 to 3.1.7

2023-09-29 Thread via GitHub
dependabot[bot] commented on PR #420: URL: https://github.com/apache/httpcomponents-core/pull/420#issuecomment-1740998514 Superseded by #436. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-client] ok2c commented on pull request #488: Update MemcachedHttpCacheStorage.java

2023-09-29 Thread via GitHub
ok2c commented on PR #488: URL: https://github.com/apache/httpcomponents-client/pull/488#issuecomment-1740897624 Superseded by 19abc7e947a25afcfa84f1efd4a915e7a7e8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [httpcomponents-client] ok2c closed pull request #488: Update MemcachedHttpCacheStorage.java

2023-09-29 Thread via GitHub
ok2c closed pull request #488: Update MemcachedHttpCacheStorage.java URL: https://github.com/apache/httpcomponents-client/pull/488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-759. Fix Version/s: 5.2.4 5.3-alpha1 Resolution: Fixed Patch

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770447#comment-17770447 ] ASF subversion and git services commented on HTTPCORE-759: -- Co

[GitHub] [httpcomponents-core] ok2c merged pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c merged PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341330485 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, final

[GitHub] [httpcomponents-core] chrysophylax commented on pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
chrysophylax commented on PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#issuecomment-1740848880 I updated the existing `testRequestContentNullEntity` test to the new expected behaviour and added a test to make sure non-PUT/POST/PATCH don't get the `Content-Length` h

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770411#comment-17770411 ] Julian Reschke commented on HTTPCORE-759: - bq. Can be, but not mandatory. Is ou

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770409#comment-17770409 ] Michael Osipov commented on HTTPCORE-759: - Can be, but not mandatory. Is our un

[GitHub] [httpcomponents-core] reschke commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
reschke commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341287246 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, fina

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341285734 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, final

[GitHub] [httpcomponents-core] chrysophylax commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
chrysophylax commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341277979 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request,

[GitHub] [httpcomponents-core] reschke commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
reschke commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341273913 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, fina

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341269898 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, final

[GitHub] [httpcomponents-core] chrysophylax commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
chrysophylax commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341265651 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request,

[GitHub] [httpcomponents-core] reschke commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
reschke commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341262963 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, fina

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341257383 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, final

[GitHub] [httpcomponents-core] ok2c commented on pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
ok2c commented on PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#issuecomment-1740750258 @chrysophylax Please also make sure the build still passes all style checks. I would also kindly ask you to add a test case to `TestStandardInterceptors` for the new behavior.

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770394#comment-17770394 ] Julian Reschke commented on HTTPCORE-759: - But for POST and PUT, content *is* a

[jira] [Comment Edited] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770393#comment-17770393 ] Arturo Bernal edited comment on HTTPCORE-759 at 9/29/23 11:36 AM: ---

[jira] [Comment Edited] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770393#comment-17770393 ] Arturo Bernal edited comment on HTTPCORE-759 at 9/29/23 11:35 AM: ---

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770393#comment-17770393 ] Arturo Bernal commented on HTTPCORE-759:  I agree with your [~michael-o] ,  int

[GitHub] [httpcomponents-core] chrysophylax opened a new pull request, #435: HTTPCORE-759 Content-Length missing on null entity request content

2023-09-29 Thread via GitHub
chrysophylax opened a new pull request, #435: URL: https://github.com/apache/httpcomponents-core/pull/435 Quick fix for maximum compatibility per JIRA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770379#comment-17770379 ] Michael Osipov commented on HTTPCORE-759: - Looking at https://www.rfc-editor.or

[jira] [Updated] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Billy Jaime Beltran (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Billy Jaime Beltran updated HTTPCORE-759: - Description: When making a POST request with an empty body, the following diffe

[jira] [Created] (HTTPCORE-759) Content-Length missing on null entity request content

2023-09-29 Thread Billy Jaime Beltran (Jira)
Billy Jaime Beltran created HTTPCORE-759: Summary: Content-Length missing on null entity request content Key: HTTPCORE-759 URL: https://issues.apache.org/jira/browse/HTTPCORE-759 Project: HttpC