ok2c commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341269898
##########
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##########
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final
EntityDetails entity, final
throw new ProtocolException("Content-Length header already
present");
}
}
+ if (entity == null) {
Review Comment:
@chrysophylax We had to drop `HttpEntityEnclosingRequest` in 5.x because RFC
723x muddied the water by declaring it was legal for all methods to enclose an
entity, well, except for `TRACE`, that is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
