reschke commented on code in PR #435: URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341262963
########## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ########## @@ -110,6 +110,10 @@ public void process(final HttpRequest request, final EntityDetails entity, final throw new ProtocolException("Content-Length header already present"); } } + if (entity == null) { Review Comment: I'd actually use a denyList with those methods that are documented not to anticipate content (which are only few). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org