Re: [DISCUSS] Release Flink 1.17.1

2023-05-11 Thread Jingsong Li
+1 for releasing 1.17.1 Best, Jingsong On Thu, May 11, 2023 at 1:29 PM Gyula Fóra wrote: > > +1 for the release > > Gyula > > On Thu, 11 May 2023 at 05:35, Yun Tang wrote: > > > +1 for release flink-1.17.1 > > > > The blocker issue might cause silent incorrect data, it's better to have a > > fi

Re: [DISCUSS] Release Flink 1.16.2

2023-05-11 Thread Jingsong Li
+1 for releasing 1.16.2 Best, Jingsong On Thu, May 11, 2023 at 1:28 PM Gyula Fóra wrote: > > +1 for the release > > Gyula > > On Thu, 11 May 2023 at 05:08, weijie guo wrote: > > > [1] > > > > https://issues.apache.org/jira/browse/FLINK-31092?jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%20

Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-05-11 Thread Jingsong Li
Hi Mang, Thanks for starting this FLIP. I have some doubts about the `TwoPhaseCatalogTable`. Generally, our Flink design places execution in the TableFactory or directly in the Catalog, so introducing an executable table makes me feel a bit strange. (Spark is this style, but Flink may not be) An

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-05-28 Thread Jingsong Li
Thanks Ron for the proposal. Do you have some benchmark results for the performance improvement? I am more concerned about the improvement on Flink than the data in other papers. Best, Jingsong On Mon, May 29, 2023 at 2:16 PM liu ron wrote: > > Hi, dev > > I'd like to start a discussion about F

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-28 Thread Jingsong Li
Thanks Yuxia for the proposal. > CALL [catalog_name.][database_name.]procedure_name ([ expression [, > expression]* ] ) The expression can be a function call. Does this need to be a function call? Do you have some example? > Procedure returns T[] Procedure looks like a TableFunction, do you co

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-05-29 Thread Jingsong Li
rting only Calc&HashJoin&HashAgg operator. In > some queries, we even get more than 30% gain, it looks like an effective > way. > > Best, > Ron > > Jingsong Li 于2023年5月29日周一 14:33写道: > > > Thanks Ron for the proposal. > > > > Do you have some

Re: [DISCUSS] Hive dialect shouldn't fall back to Flink's default dialect

2023-05-30 Thread Jingsong Li
+1, the fallback looks weird now, it is outdated. But, it is good to provide an option. I don't know if there are some users who depend on this fallback. Best, Jingsong On Tue, May 30, 2023 at 1:47 PM Rui Li wrote: > > +1, the fallback was just intended as a temporary workaround to run > catal

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-30 Thread Jingsong Li
e > amount of data, I think we can change to return type from T[] to Iterable > > [1]: https://iceberg.apache.org/docs/latest/spark-procedures/#migrate > [2]: > https://github.com/apache/iceberg/blob/601c5af9b6abded79dabeba177331310d5487f43/spark/v3.2/spark/src/main/java/org/apache/spar

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-01 Thread Jingsong Li
Thanks Feng, Just naming, maybe `createCatalog` in TableEnv, I can see many functions are converted to createxxx from registerxxx. On Fri, Jun 2, 2023 at 11:04 AM Feng Jin wrote: > > Hi jark, thanks for your suggestion. > > > 1. How to register the CatalogStore for Table API? I think the > Catal

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-04 Thread Jingsong Li
ides, if there is a complete test graph with all TPC-DS queries, the > > > effect of this FLIP will be more intuitive. > > > > > > Best, > > > Jark > > > > > > > > > > > > On Wed, 31 May 2023 at 14:27, liu ron w

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-06-06 Thread Jingsong Li
+1 (binding) - checked NOTICE and LICENSE - Verified signatures and hashes - Build and compile the source code locally - No unexpected binaries in the source release Something can be improved: - NOTICE file can be updated to 2014-2023 from 2014-2022. Best, Jingsong On Tue, Jun 6, 2023 at 3:59 

Re: [VOTE] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-07 Thread Jingsong Li
+1 On Wed, Jun 7, 2023 at 3:03 PM Benchao Li wrote: > > +1, binding > > Jark Wu 于2023年6月7日周三 14:44写道: > > > +1 (binding) > > > > Best, > > Jark > > > > > 2023年6月7日 14:20,liu ron 写道: > > > > > > Hi everyone, > > > > > > Thanks for all the feedback about FLIP-315: Support Operator Fusion > > Code

Re: Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-07 Thread Jingsong Li
e.org/confluence/display/FLINK/FLIP-305%3A+Support+atomic+for+CREATE+TABLE+AS+SELECT%28CTAS%29+statement > > > -- > > Best regards, > > Mang Zhang > > > > At 2023-05-12 13:02:14, "Jingsong Li" wrote: > >Hi Mang, > > > >Thanks for start

Re: [VOTE] FLIP-311: Support Call Stored Procedure

2023-06-12 Thread Jingsong Li
+1 On Mon, Jun 12, 2023 at 10:32 PM Rui Fan <1996fan...@gmail.com> wrote: > > +1 (binding) > > Best, > Rui Fan > > On Mon, Jun 12, 2023 at 22:20 Benchao Li wrote: > > > +1 (binding) > > > > yuxia 于2023年6月12日周一 17:58写道: > > > > > Hi everyone, > > > Thanks for all the feedback about FLIP-311: Supp

Re: [VOTE] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-12 Thread Jingsong Li
+1 On Mon, Jun 12, 2023 at 10:25 PM Rui Fan <1996fan...@gmail.com> wrote: > > +1 (binding) > > Best, > Rui Fan > > On Mon, Jun 12, 2023 at 19:58 liu ron wrote: > > > +1 (no-binding) > > > > Best, > > Ron > > > > Jing Ge 于2023年6月12日周一 19:33写道: > > > > > +1(binding) Thanks! > > > > > > Best regard

Re: Async I/O: preserve stream order for requests on key level

2023-06-20 Thread Jingsong Li
+1 for this. Actually, this is a headache for Flink SQL too. There is certainly a lot of updated data (CDC changelog) in real stream processing, The semantics here is the need to ensure the order between keys, and different keys can be handled in disorder. I'm very happy that the community has a

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-24 Thread Jingsong Li
Thanks Becket and all for your discussion. > 1. We say this FLIP is enforced starting release 2.0. For current 1.x APIs, we provide a migration period with best effort, while allowing exceptions for immediate removal in 2.0. That means we will still try with best effort to get the ProcessFuncion A

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-06-27 Thread Jingsong Li
Looks good to me! Thanks Dong, Yunfeng and all for your discussion and design. Best, Jingsong On Tue, Jun 27, 2023 at 3:35 PM Jark Wu wrote: > > Thank you Dong for driving this FLIP. > > The new design looks good to me! > > Best, > Jark > > > 2023年6月27日 14:38,Dong Lin 写道: > > > > Thank you Leo

Re: [VOTE] FLIP-309: Support using larger checkpointing interval when source is processing backlog

2023-06-28 Thread Jingsong Li
+1 binding On Thu, Jun 29, 2023 at 11:03 AM Dong Lin wrote: > > Hi all, > > We would like to start the vote for FLIP-309: Support using larger > checkpointing interval when source is processing backlog [1]. This FLIP was > discussed in this thread [2]. > > Flink 1.18 release will feature freeze o

Re: [DISCUSS] Deprecate SourceFunction APIs

2023-07-03 Thread Jingsong Li
> do we have any plan to offer a lighter Source API to decrease the connector > development cost? I remember mentioning it many times, but no contributor did it. ToT Best, Jingsong On Tue, Jul 4, 2023 at 11:01 AM Leonard Xu wrote: > > +1 to deprecate. > +1 for David’s points. > > I’ve one rela

Re: [VOTE] FLIP-321: introduce an API deprecation process

2023-07-03 Thread Jingsong Li
+1 binding On Tue, Jul 4, 2023 at 10:40 AM Zhu Zhu wrote: > > +1 (binding) > > Thanks, > Zhu > > ConradJam 于2023年7月3日周一 22:39写道: > > > > +1 (no-binding) > > > > Matthias Pohl 于2023年7月3日周一 22:33写道: > > > > > Thanks, Becket > > > > > > +1 (binding) > > > > > > On Mon, Jul 3, 2023 at 10:44 AM Jing

Re: Re: [ANNOUNCE] Apache Flink has won the 2023 SIGMOD Systems Award

2023-07-03 Thread Jingsong Li
Congratulations! Thank you! All of the Flink community! Best, Jingsong On Tue, Jul 4, 2023 at 1:24 PM tison wrote: > > Congrats and with honor :D > > Best, > tison. > > > Mang Zhang 于2023年7月4日周二 11:08写道: > > > Congratulations!-- > > > > Best regards, > > Mang Zhang > > > > > > > > > > > > 在 20

Re: [VOTE] Release 2.0 must-have work items

2023-07-09 Thread Jingsong Li
+1 On Mon, Jul 10, 2023 at 10:46 AM Yuan Mei wrote: > > +1 (binding) > > Thanks for driving this! > > Best > Yuan > > On Mon, Jul 10, 2023 at 10:26 AM Jark Wu wrote: > > > +1 (binding) > > > > Thanks for driving this. Looking forward to starting the 2.0 works. > > > > Best, > > Jark > > > > On

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Jingsong Li
It's exciting to finally have someone to refactor the Flink website. Thanks Deepthi. To Xintong, > maintain two sets of website designs at the same time If our website is not so complex, and new webui can be full feature coverage, there would be no need to maintain two sets of web. To Jing +1

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Jingsong Li
+1 to Leonard and Galen and Jing. About Source and Sink. We're still missing quite a bit of work, including functionality, including ease of use, including bug fixes, and I'm not sure we'll be completely done by 2.0. Until that's done, we won't be in a position to clean up the old APIs. Best, Jin

Re: [VOTE] FLIP-309: Support using larger checkpointing interval when source is processing backlog

2023-07-18 Thread Jingsong Li
+1 binding Thanks Dong for continuous driving. Best, Jingsong On Tue, Jul 18, 2023 at 10:04 PM Jark Wu wrote: > > +1 (binding) > > Best, > Jark > > On Tue, 18 Jul 2023 at 20:30, Piotr Nowojski wrote: > > > +1 (binding) > > > > Piotrek > > > > wt., 18 lip 2023 o 08:51 Jing Ge napisał(a): > > >

Re: [DISCUSS] FLIP-346: Deprecate ManagedTable related APIs

2023-07-19 Thread Jingsong Li
+1 On Thu, Jul 20, 2023 at 12:31 PM Jane Chan wrote: > > Hi, devs, > > I would like to start a discussion on FLIP-346: Deprecate ManagedTable > related APIs[1]. > > These APIs were initially designed for Flink Table Store, which has > joined the Apache Incubator as a separate project called Apach

[ANNOUNCE] New Apache Flink Committer - Yong Fang

2023-07-23 Thread Jingsong Li
Hi, everyone On behalf of the PMC, I'm very happy to announce Yong Fang (Shammon) (zjur...@gmail.com) as a new Flink Committer. Yong is an old flinker, he has been contributing to Flink since 2017. He actively participated in dev discussions and answered many questions on the user mailing list.

Re: [VOTE] Release 2.0 must-have work items - Round 2

2023-07-26 Thread Jingsong Li
+1 binding Thanks all for your work! Best, Jingsong On Thu, Jul 27, 2023 at 10:52 AM Jark Wu wrote: > > +1 (binding) > > Thanks Xintong for driving this. Thanks all for finalizing the > SourceFunction conclusion. > > Best, > Jark > > On Wed, 26 Jul 2023 at 22:28, Alexander Fedulov > wrote: > >

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-27 Thread Jingsong Li
Hi thanks all for your discussion. What is inputIndex in NestedFieldReferenceExpression? I know inputIndex has special usage in FieldReferenceExpression, but it is only for Join operators, and it is only for SQL optimization. It looks like there is no requirement for Nested. Best, Jingsong On M

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-27 Thread Jingsong Li
So if NestedFieldReferenceExpression doesn't need inputIndex, is there a need to introduce a base class `ReferenceExpression`? Best, Jingsong On Mon, Aug 28, 2023 at 2:09 PM Jingsong Li wrote: > > Hi thanks all for your discussion. > > What is inputIndex in NestedFieldReference

Re: [VOTE] FLIP-356: Support Nested Fields Filter Pushdown

2023-09-05 Thread Jingsong Li
+1 On Wed, Sep 6, 2023 at 1:18 PM Becket Qin wrote: > > Thanks for pushing the FLIP through. > > +1 on the updated FLIP wiki. > > Cheers, > > Jiangjie (Becket) Qin > > On Wed, Sep 6, 2023 at 1:12 PM Venkatakrishnan Sowrirajan > wrote: > > > Based on the recent discussions in the thread [DISCUSS]

Re: [DISCUSS] Remove legacy Paimon (TableStore) doc link from Flink web navigation

2023-10-17 Thread Jingsong Li
Hi marton, Thanks for driving. +1 There is a PR to remove legacy Paimon https://github.com/apache/flink-web/pull/665 , but it hasn't been updated for a long time. Best, Jingsong On Tue, Oct 17, 2023 at 4:28 PM Márton Balassi wrote: > > Hi Flink & Paimon devs, > > The Flink webpage documentatio

Re: [VOTE] Release 1.18.0, release candidate #3

2023-10-23 Thread Jingsong Li
+1 (binding) - verified signatures & hash - built from source code succeeded - started SQL Client, used Paimon connector to write and read, the result is expected Best, Jingsong On Tue, Oct 24, 2023 at 12:15 PM Yuxin Tan wrote: > > +1(non-binding) > > - Verified checksum > - Build from source c

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-10-24 Thread Jingsong Li
+1 for this FLIP. BTW, I think we can add an option for projection push down too. Yes, we can do all things in the connector, but a common implementation helps a lot! And can introduce an unify option! Best, Jingsong On Wed, Oct 25, 2023 at 10:07 AM Jark Wu wrote: > > Thank you for updating Ji

Re: [DISCUSS] FLIP-376: Add DISTRIBUTED BY clause

2023-10-26 Thread Jingsong Li
Very thanks Timo for starting this discussion. Big +1 for this. The design looks good to me! We can add some documentation for connector developers. For example: for sink, If there needs some keyby, please finish the keyby by the connector itself. SupportsBucketing is just a marker interface. B

Re: flink-sql-connector-jdbc new release

2023-10-26 Thread Jingsong Li
Hi David, Thanks for driving this. I think https://issues.apache.org/jira/browse/FLINK-33365 should be a blocker. Best, Jingsong On Thu, Oct 26, 2023 at 11:43 PM David Radley wrote: > > Hi, > I propose that we do a 3.2 release of flink-sql-connector-jdbc so that there > is a version matching

Re: [ANNOUNCE] Apache Flink 1.18.0 released

2023-10-26 Thread Jingsong Li
Congratulations! Thanks Jing and other release managers and all contributors. Best, Jingsong On Fri, Oct 27, 2023 at 1:52 PM Zakelly Lan wrote: > > Congratulations and thank you all! > > > Best, > Zakelly > > On Fri, Oct 27, 2023 at 12:39 PM Jark Wu wrote: > > > > Congratulations and thanks re

Re: [VOTE] FLIP-376: Add DISTRIBUTED BY clause

2023-11-07 Thread Jingsong Li
+1 On Tue, Nov 7, 2023 at 5:56 AM Jim Hughes wrote: > > Hi all, > > +1 (non-binding) > > Cheers, > > Jim > > On Mon, Nov 6, 2023 at 6:39 AM Timo Walther wrote: > > > Hi everyone, > > > > I'd like to start a vote on FLIP-376: Add DISTRIBUTED BY clause[1] which > > has been discussed in this threa

Re: Re:Re: [DISCUSS] Release 1.17.2

2023-11-07 Thread Jingsong Li
+1 thanks Yun 1.17.2 is really important. Best, Jingsong On Tue, Nov 7, 2023 at 9:32 AM Danny Cranmer wrote: > > +1, thanks for picking this up. > > I am happy to help out with the bits you need PMC support for. > > Thanks, > Danny > > On Tue, Nov 7, 2023 at 4:03 AM Yun Tang wrote: > > > Hi @

Re: [DISCUSS] Contribute Flink Doris Connector to the Flink community

2023-11-26 Thread Jingsong Li
+1 for this On Mon, Nov 27, 2023 at 10:26 AM Yun Tang wrote: > > Hi, Di.Wu > > Thanks for creating this discussion. The Apache Doris community might have > the most active contributors in ASF this year, and since I also contributed > to doris-flink-connector before, I'm very glad to see this co

Re: [VOTE] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-12-04 Thread Jingsong Li
+1 binding On Mon, Dec 4, 2023 at 10:33 PM Etienne Chauchot wrote: > > Correct, > > I forgot that in the bylaws, committer vote is binding for FLIPs thanks > for the reminder. > > Best > > Etienne > > Le 30/11/2023 à 10:43, Leonard Xu a écrit : > > +1(binding) > > > > Btw, @Etienne, IIRC, your vo

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-06 Thread Jingsong Li
Wow, Cool, Nice CDC is playing an increasingly important role. +1 Best, Jingsong On Thu, Dec 7, 2023 at 11:25 AM Leonard Xu wrote: > > Dear Flink devs, > > As you may have heard, we at Alibaba (Ververica) are planning to donate CDC > Connectors for the Apache Flink project[1] to the Apache Fl

Re: [ANNOUNCE] New Apache Flink Committer - Alexander Fedulov

2024-01-02 Thread Jingsong Li
Congratulations! Best, Jingsong On Wed, Jan 3, 2024 at 10:28 AM Benchao Li wrote: > > Congratulations, Alex! > > Yuepeng Pan 于2024年1月3日周三 10:10写道: > > > > Congrats, Alex! > > > > Best, > > Yuepeng Pan > > At 2024-01-02 20:15:08, "Maximilian Michels" wrote: > > >Happy New Year everyone, > > > >

Re: [VOTE] Accept Flink CDC into Apache Flink

2024-01-08 Thread Jingsong Li
+1 On Tue, Jan 9, 2024 at 3:23 PM Yuan Mei wrote: > > +1 binding > > > > On Tue, Jan 9, 2024 at 3:21 PM Yuan Mei wrote: > > > +1 > > > > Best, > > Yuan > > > > On Tue, Jan 9, 2024 at 3:06 PM tison wrote: > > > >> +1 non-binding > >> > >> Best, > >> tison. > >> > >> Leonard Xu 于2024年1月9日周二 15:0

Re: Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures

2024-01-09 Thread Jingsong Li
+1 On Wed, Jan 10, 2024 at 11:24 AM Xuyang wrote: > > +1(non-binding)-- > > Best! > Xuyang > > > > > > 在 2024-01-08 00:34:55,"Feng Jin" 写道: > >Hi Alexey > > > >Thank you for the reminder, the link has been updated. > > > >Best, > >Feng Jin > > > >On Sat, Jan 6, 2024 at 12:55 AM Alexey Le

Re: [DISCUSS] FLIP-415: Introduce a new join operator to support minibatch

2024-01-11 Thread Jingsong Li
Hi all, This is a relatively large optimization that may pose a significant risk of bugs, so I like to keep it from being enabled by default for now. Best, Jingsong On Fri, Jan 12, 2024 at 3:01 PM shuai xu wrote: > > Suppose we currently have a job that joins two CDC sources after > de-duplica

Re: [DISCUSS] Support scalar vectorized Python UDF in PyFlink

2020-02-05 Thread Jingsong Li
Hi Dian, +1 for this, thanks driving. Documentation looks very good. I can imagine a huge performance improvement and better integration to other Python libraries. A few thoughts: - About data split: "python.fn-execution.arrow.batch.size", can we unify it with "python.fn-execution.bundle.size"? -

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Jingsong Li
Hi Jeff, For FLINK-15935 [1], I try to think of it as a non blocker. But it's really an important issue. The problem is the class loading order. We want to load the class in the blink-planner.jar, but actually load the class in the flink-planner.jar. First of all, the order of class loading

Re: [DISCUSS] have separate Flink distributions with built-in Hive dependencies

2020-02-06 Thread Jingsong Li
t;> variables. I prefer to keep it this way for a while, and see if there're >> real concerns/complaints from user feedbacks. >> >> Please also note the Hive jars are not the only ones needed to integrate >> with Hive, users have to make sure flink-connector-hiv

Re: [DISCUSS] have separate Flink distributions with built-in Hive dependencies

2020-02-06 Thread Jingsong Li
> you can cover a lot of versions. > > Would it make sense to add these to flink-shaded (with proper dependency > exclusions of unnecessary dependencies) and offer them as a download, > similar as we offer pre-shaded Hadoop downloads? > > Best, > Stephan > > > On Thu, Fe

Re: [VOTE] Improve TableFactory to add Context

2020-02-09 Thread Jingsong Li
w, could you also attach a JIRA issue with the changes described > in > > > it, > > > >>> so that users can find the issue through the mailing list in the > > > future. > > > >>> > > > >>> Best, > > > >>> Jark > >

Re: [DISCUSS] Support scalar vectorized Python UDF in PyFlink

2020-02-09 Thread Jingsong Li
ded by Arrow, we can gain them > > > automatically using Arrow. > > > 3. Good point! As all the classes of Python module is written in Java > and > > > it's not suggested to introduce new Scala classes, so I guess it's not > > easy > > > to do so

Re: [VOTE] Release 1.10.0, release candidate #3

2020-02-10 Thread Jingsong Li
Hi, +1 (non-binding) Thanks for driving this, Gary & Yu. There is an unfriendly error here: "OutOfMemoryError: Direct buffer memory" in FileChannelBoundedData$FileBufferReader. It forces our batch users to configure "taskmanager.memory.task.off-heap.size" in production jobs. And users are hard

Re: [DISCUSS] Support scalar vectorized Python UDF in PyFlink

2020-02-10 Thread Jingsong Li
t; >> - Can we only configure one parameter and calculate another > > automatically? For example, if we just want to "pipeline", "bundle.size" > is > > twice as much as "batch.size", is this work? > > > > I don't think th

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-10 Thread Jingsong Li
Hi Dawid, Thanks for driving. - adding $ in scala api looks good to me. - Just a question, what should be expected to java.lang.Object? literal object or expression? So the Object is the grammatical sugar of literal? Best, Jingsong Lee On Mon, Feb 10, 2020 at 9:40 PM Timo Walther wrote: > +1

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Jingsong Li
rk Wu 写道: > >> > >> +1 for this. > >> > >> I have some minor comments: > >> - I'm +1 to use $ in both Java and Scala API. > >> - I'm +1 to use lit(), Spark also provides lit() function to create a > >> literal value. &

Re: [ANNOUNCE] Apache Flink 1.10.0 released

2020-02-12 Thread Jingsong Li
Congratulations! Great work. Best, Jingsong Lee On Wed, Feb 12, 2020 at 11:05 PM Leonard Xu wrote: > Great news! > Thanks everyone involved ! > Thanks Gary and Yu for being the release manager ! > > Best, > Leonard Xu > > 在 2020年2月12日,23:02,Stephan Ewen 写道: > > Congrats to us all. > > A big pi

Re: [VOTE] Support scalar vectorized Python UDF in PyFlink

2020-02-12 Thread Jingsong Li
+1 (non-binding) Thanks Dian for driving. Best, Jingsong Lee On Thu, Feb 13, 2020 at 11:45 AM jincheng sun wrote: > +1 (binding) > > Best, > Jincheng > > > Dian Fu 于2020年2月12日周三 下午1:31写道: > > > Hi all, > > > > I'd like to start the vote of FLIP-97[1] which is discussed and reached > > consensu

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-02-12 Thread Jingsong Li
Hi Godfrey, Thanks for updating. +1 sketchy. I have no idea to change "sqlQuery" to "fromQuery", I think "sqlQuery" is OK, It's not that confusing with return values. Can we change the "DmlBatch" to "Inserts"? I don't see any other needs. "Dml" seems a little weird. It is better to support "Ins

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-02-15 Thread Jingsong Li
> other statement in a single batch. If that happens, the name > "Inserts" > > > will > > > > be weird. > > > > > > > > Best, > > > > Kurt > > > > > > > > > > > > On Thu, Feb 13, 2020 at 4:03 PM J

Re: [ANNOUNCE] New Documentation Style Guide

2020-02-15 Thread Jingsong Li
Thank for the great work, In 1.10, I have modified and reviewed some documents. In that process, sometimes there is some confusion, how to write is the standard. How to write is correct to the users. Docs style now tells me. Learned a lot. Best, Jingsong Lee On Sat, Feb 15, 2020 at 10:00 PM Dian

Re: [DISCUSS][TABLE] Issue with package structure in the Table API

2020-02-17 Thread Jingsong Li
Thanks for bringing this discussion. +1 to peforming this big change as early as possible. You solved my question, why we need "_root_". Yes, I don't like this import too. And it is very strange that expressionDsl is in api, but can only work in api.scala. (Because scala extends ImplicitExpressi

Re: [DISCUSS] Improvements on FLIP Process

2020-02-18 Thread Jingsong Li
Hi all, thanks for launching this discussion. About eliminating Google Docs. I agree with Zhijiang, I share my concern about it. If the FLIP Driver is a Flink newer or the FLIP is very big and complicated. His/Her design maybe need change many many things, in this situation, Google doc is good to

Re: [DISCUSS] Kicking off the 1.11 release cycle

2020-02-20 Thread Jingsong Li
Thanks Stephan for the kicking off. Thanks Piotr and Zhijiang for volunteering. +1 for aiming with the feature freeze date for end of April. We should return to the quick release model. (3 months) Best, Jingsong Lee On Thu, Feb 20, 2020 at 6:04 PM Zhu Zhu wrote: > Thanks Piotr and Zhijiang for

Re: [DISCUSS] Support "create [temporary] table" and "create [temporary] view" statements

2020-02-20 Thread Jingsong Li
Hi Caizhi, thanks for starting this discussion. There is a FLIP-71 [1] to describe the whole story of view. Sql-cli now implements a wrong way, and a separate way, which should be deprecated and unified to TableEnvironment. > Shall we make it clear and support create table / create temporary tab

Re: [DISCUSS] Improve TableFactory

2020-02-21 Thread Jingsong Li
hink we need a new VOTE for this, I just want to make this > discussion more publicly. > What do you think? > > Best, > Jark > > On Wed, 5 Feb 2020 at 16:05, Rui Li wrote: > > > +1, thanks for the efforts. > > > > On Wed, Feb 5, 2020 at 4:00 PM Jingson

Re: [ANNOUNCE] Jingsong Lee becomes a Flink committer

2020-02-21 Thread Jingsong Li
Thanks everyone~ It's my pleasure to be part of the community. I hope I can make a better contribution in future. Best, Jingsong Lee On Fri, Feb 21, 2020 at 2:48 PM Hequn Cheng wrote: > Congratulations Jingsong! Well deserved. > > Best, > Hequn > > On Fri, Feb 21, 2020 at 2:42 PM Yang Wang wr

Re: TIME/TIMESTAMP parse in Flink TABLE/SQL API

2020-02-26 Thread Jingsong Li
Thanks all for your discussion. Hi Dawid, +1 to apply the logic of parsing a SQL timestamp literal. I don't fully understand the matrix your list. Should this be the semantics of SQL cast? Do you mean this is implicit cast in JSON parser? I doubt that because these implicit casts are not support

Re: TIME/TIMESTAMP parse in Flink TABLE/SQL API

2020-02-26 Thread Jingsong Li
in a topic. > > Best, > Jark > > On Wed, 26 Feb 2020 at 22:20, Jingsong Li wrote: > >> Thanks all for your discussion. >> >> Hi Dawid, >> >> +1 to apply the logic of parsing a SQL timestamp literal. >> >> I don't fully understand the

Re: Flink dev blog

2020-03-03 Thread Jingsong Li
+1 for this proposal. I have a lot of desired topics in table and batch. I also second Seth and Stephan 's comment separate this in a clear way. Have concerns that maybe easy to confuse new users. If I am a beginner and find a bunch of deep documents, I need to further distinguish which is effecti

Re: [DISCUSS] FLIP-110: Support LIKE clause in CREATE TABLE

2020-03-04 Thread Jingsong Li
Thanks Dawid for starting this discussion. I like the "LIKE". 1.For "INHERITS", I think this is a good feature too, yes, ALTER TABLE will propagate any changes in column data definitions and check constraints down the inheritance hierarchy. A inherits B, A and B share every things, they have the

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Jingsong Li
Thanks Bowen for involving. > why you proposed segregating hive versions into the 5 ranges above? & what different Hive features are supported in the 5 ranges? For only higher client dependencies version support lower hive metastore versions: - Hive 1.0.0 - 1.2.2, thrift change is OK, only hive d

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Jingsong Li
1.0.0 - 1.2.2, the module name can be "flink-connector-hive-1.0" > rather than "flink-connector-hive-1.2" > > > On Wed, Mar 4, 2020 at 10:20 PM Jingsong Li > wrote: > > > Thanks Bowen for involving. > > > > > why you proposed segregating

Re: [DISCUSS] Disable "Squash and merge" button for Flink repository on GitHub

2020-03-05 Thread Jingsong Li
Thanks for deep investigation. +1 to disable "Squash and merge" button now. But I think this is a very serious problem, It affects too many GitHub workers. Github should deal with it quickly? Best, Jingsong Lee On Thu, Mar 5, 2020 at 7:21 PM Xingbo Huang wrote: > Hi Jark, > > Thanks for bringi

Re: [DISCUSS] Disable "Squash and merge" button for Flink repository on GitHub

2020-03-05 Thread Jingsong Li
h > >>>>> in > >>>>>> the repository(according to github rules). > >>>>>> > >>>>>> If we only left "merge and commits" button, it will > >>>>>> against requiring > >> a >

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-05 Thread Jingsong Li
a name including the > lowest Hive version it supports. > > What do you think? > > > > On Wed, Mar 4, 2020 at 11:14 PM Jingsong Li > wrote: > > > Hi Bowen, thanks for your reply. > > > > > will there be a base module like "flink-connector-hive-base

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-09 Thread Jingsong Li
Hi Danny, +1 for table hints, thanks for driving. I took a look to FLIP, most of content are talking about query hints. It is hard to discussion and voting. So +1 to split it as Jark said. Another thing is configuration that suitable to config with table hints: "connector.path" and "connector.top

Re: [DISCUSS] Releasing Flink 1.10.1

2020-03-11 Thread Jingsong Li
Thanks for driving. Yu. +1 for starting the 1.10.1 release. Some issues are very important, Users are looking forward to them. Best, Jingsong Lee On Wed, Mar 11, 2020 at 2:52 PM Yangze Guo wrote: > Thanks for driving this release, Yu! > > +1 for starting the 1.10.1 release cycle. > > Best, > Y

Re: [DISCUSS] Drop Bucketing Sink

2020-03-12 Thread Jingsong Li
Hi Robert, +1 to drop it but maybe not 1.11. ORC has not been supported on StreamingFileSink. I have seen lots of users run ORC in the bucketing sink. Best, Jingsong Lee On Fri, Mar 13, 2020 at 1:11 AM Seth Wiesman wrote: > Sorry, I meant FLIP-46. > > Seth > > On Thu, Mar 12, 2020 at 11:52 AM

[DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-13 Thread Jingsong Li
Hi everyone, I'd like to start a discussion about FLIP-115 Filesystem connector in Table [1]. This FLIP will bring: - Introduce Filesystem table factory in table, support csv/parquet/orc/json/avro formats. - Introduce streaming filesystem/hive sink in table CC to user mail list, if you have any u

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-15 Thread Jingsong Li
s for FLIP-115. It is really useful feature for platform developers > > who manage hundreds of Flink to Hive jobs in production. > > > I think we need add 'connector.sink.username' for UserGroupInformation when > > data is written to HDFS > > > > > > 在 2020/3

Re: FLIP-117: HBase catalog

2020-03-15 Thread Jingsong Li
Thanks Flavio for driving. Personally I am +1 for integrating HBase tables. I start a new topic for discussion. It is related but not the core of this FLIP. In the FLIP, I can see: - Does HBase support the concept of partitions..? I don't think so.. - Does HBase support functions? I don't think so

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-15 Thread Jingsong Li
e On Mon, Mar 16, 2020 at 12:01 PM Jingsong Li wrote: > Thanks Piotr and Yun for involving. > > Hi Piotr and Yun, for implementation, > > FLINK-14254 [1] introduce batch sink table world, it deals with partitions > thing, metastore thing and etc.. And it just reuse

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-16 Thread Jingsong Li
wn set of limitations, quirks and features. > Especially that we have on our long term roadmap and wish list to unify > such kind of operators. > > Piotrek > > [1] https://issues.apache.org/jira/browse/FLINK-11499 < > https://issues.apache.org/jira/browse/FLINK-11499> > &

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-17 Thread Jingsong Li
would make it much easier for users > to > > understand the system. > > Especially when it comes to consistent behavior across external systems. > > Having a different file sink in Table API and DataStream API means that > > DataStream can write correctly to S3 while Table API

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-17 Thread Jingsong Li
Hi, I am thinking we can provide hints to *table* related instances. - TableFormatFactory: of cause we need hints support, there are many format options in DDL too. - catalog and module: I don't know, maybe in future we can provide some hints for them. Best, Jingsong Lee On Wed, Mar 18, 2020 at

Re: [DISCUSS] (FLINK-16648) Clean up the input parameter StreamQueryConfig of the API in StreamTableEnvironment

2020-03-18 Thread Jingsong Li
Hi Jinhai, thanks for driving. +1 to remove, I think we can remove StreamQueryConfig too. since we have deprecated StreamQueryConfig two versions. Remember to record it in release notes of issue. Best, Jingsong Lee On Wed, Mar 18, 2020 at 5:58 PM jinhai wang wrote: > Hi Devs > > I would like

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-18 Thread Jingsong Li
eviating from > >> this now, we only put more stress on other teams in the future. When > >> the users start using a given API, with high probability, they will > >> ask (and it is totally reasonable) consistent behaviour from all the > >> other APIs that ship wit

[DISCUSS] Introduce TableFactory for StatefulSequenceSource

2020-03-19 Thread Jingsong Li
Hi all, I heard some users complain that table is difficult to test. Now with SQL client, users are more and more inclined to use it to test rather than program. The most common example is Kafka source. If users need to test their SQL output and checkpoint, they need to: - 1.Launch a Kafka standa

Re: [DISCUSS] Introduce TableFactory for StatefulSequenceSource

2020-03-22 Thread Jingsong Li
nt data in row format in console > >> - purposes > >> - make it easier to test Flink SQL job e2e in IDE > >> - test Flink pipeline and ensure output data format/value is > >> correct > >> 3. no output data sink > >>

Re: [DISCUSS] Introduce TableFactory for StatefulSequenceSource

2020-03-23 Thread Jingsong Li
nerally, it's a very good proposal. > > > > About data gen source, do you think we need to add more columns with > > various types? > > > > About print sink, do we need to specify the schema? > > > > Jingsong Li 于2020年3月23日周一 下午1:51写道: > > > &

Re: [DISCUSS] Introduce TableFactory for StatefulSequenceSource

2020-03-24 Thread Jingsong Li
tackle them for the sake of > simplifying user experience to the extreme. Providing the above handy > source and sink implementations already offer users a ton of immediate > value. > > > On Mon, Mar 23, 2020 at 20:20 Jingsong Li wrote: > > > Hi Benchao, > > > &g

Re: [DISCUSS] FLIP-95: New TableSource and TableSink interfaces

2020-03-24 Thread Jingsong Li
+1. Thanks Timo for the design doc. We can also consider @Experimental too. But I am +1 to @PublicEvolving, we should be confident in the current change. Best, Jingsong Lee On Tue, Mar 24, 2020 at 4:30 PM Timo Walther wrote: > @Becket: We totally agree that we don't need table specific connect

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-25 Thread Jingsong Li
treamingFileSink might not > support currently. I am very glad to see that you all agree that improving > the StreamingFileSink architecture for these new cases. > > Best, > Guowei > > > Jingsong Li 于2020年3月19日周四 上午12:19写道: > > > Hi Stephan & Kostas & Piotr

Re: [DISCUSS]FLIP-113: Support SQL and planner hints

2020-03-26 Thread Jingsong Li
; > > > > >> Best, > > > > >> Jark > > > > >> > > > > >> [1]: https://kafka.apache.org/documentation/#consumerconfigs > > > > >> > > > > >> On Wed, 18 Mar 2020 at 21:44, Danny Chan > >

[VOTE] FLIP-115: Filesystem connector in Table

2020-03-26 Thread Jingsong Li
Hi everyone, I'd like to start the vote of FLIP-115 [1], which introduce Filesystem table factory in table. This FLIP is discussed in the thread[2]. The vote will be open for at least 72 hours. Unless there is an objection, I will try to close it by March 30, 2020 03:00 UTC if we have received su

Re: [VOTE] FLIP-115: Filesystem connector in Table

2020-03-29 Thread Jingsong Li
t; > > 在 2020年3月28日,16:25,Kurt Young 写道: > > > > > > +1 > > > > > > Best, > > > Kurt > > > > > > > > > On Fri, Mar 27, 2020 at 10:51 AM Jingsong Li > > wrote: > > > > > >> Hi eve

Re: [VOTE] FLIP-115: Filesystem connector in Table

2020-03-29 Thread Jingsong Li
; Best, > Jark > > On Mon, 30 Mar 2020 at 11:32, Jingsong Li wrote: > > > +1 (binding) > > > > Best, > > Jingsong Lee > > > > On Sun, Mar 29, 2020 at 10:37 PM Benchao Li wrote: > > > > > +1 (non-binding) > > > > > >

Re: [DISCUSS] FLIP-122: New Connector Property Keys for New Factory

2020-03-30 Thread Jingsong Li
Thanks Jark for the proposal. +1 to the general idea. For "version", what about "kafka.version"? It is obvious to know its meaning. And I'd like to start a new topic: Should we need to explicitly separate source from sink? With the development of batch and streaming, more and more connectors hav

  1   2   3   4   5   6   7   >