Hi Jeff,

For FLINK-15935 [1],

I try to think of it as a non blocker. But it's really an important issue.


The problem is the class loading order. We want to load the class in the
blink-planner.jar, but actually load the class in the flink-planner.jar.


First of all, the order of class loading is based on the order of classpath.


I just tried, the order of classpath of the folder is depends on the order
of file names.

-That is to say, our order is OK now: because
flink-table-blink_2.11-1.11-SNAPSHOT.jar is before the name order of
flink-table_2.11-1.11-snapshot.jar.

-But once I change the name of flink-table_2.11-1.11-SNAPSHOT.jar to
aflink-table_2.11-1.11-SNAPSHOT.jar, an error will be reported.


The order of classpaths should be influenced by the ls of Linux. By default
the ls command is listing the files in alphabetical order. [1]


IDE seems to have another rule, because it is directly load classes. Not
jars.


So the possible impact of this problem is:

-IDE with two planners to use watermark, which will report an error.

-The real production environment, under Linux, will not report errors
because of the above reasons.


[1] https://issues.apache.org/jira/browse/FLINK-15935

[2]
https://linuxize.com/post/how-to-list-files-in-linux-using-the-ls-command/


Best,

Jingsong Lee

On Thu, Feb 6, 2020 at 3:09 PM Jeff Zhang <zjf...@gmail.com> wrote:

> -1, I just found one critical issue
> https://issues.apache.org/jira/browse/FLINK-15935
> This ticket means user unable to use watermark in sql if he specify both
> flink planner and blink planner in pom.xml
>
> <dependency>
>    <groupId>org.apache.flink</groupId>
>    <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
>    <version>${project.version}</version>
> </dependency>
> <dependency>
>    <groupId>org.apache.flink</groupId>
>
>  <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
>    <version>${project.version}</version>
> </dependency>
>
>
>
> Thomas Weise <t...@apache.org> 于2020年2月6日周四 上午5:16写道:
>
> > I deployed commit 81cf2f9e59259389a6549b07dcf822ec63c899a4 and can
> confirm
> > that the dataformat-cbor and checkpoint alignment metric issues are
> > resolved.
> >
> >
> > On Wed, Feb 5, 2020 at 11:26 AM Gary Yao <g...@apache.org> wrote:
> >
> > > Note that there is currently an ongoing discussion about whether
> > > FLINK-15917
> > > and FLINK-15918 should be fixed in 1.10.0 [1].
> > >
> > > [1]
> > >
> > >
> >
> http://mail-archives.apache.org/mod_mbox/flink-dev/202002.mbox/%3CCA%2B5xAo3D21-T5QysQg3XOdm%3DL9ipz3rMkA%3DqMzxraJRgfuyg2A%40mail.gmail.com%3E
> > >
> > > On Wed, Feb 5, 2020 at 8:00 PM Gary Yao <g...@apache.org> wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #2 for the version
> > > 1.10.0,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release and binary convenience releases
> to
> > > be
> > > > deployed to dist.apache.org [2], which are signed with the key with
> > > > fingerprint BB137807CEFBE7DD2616556710B12A1F89C115E8 [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag "release-1.10.0-rc2" [5],
> > > > * website pull request listing the new release and adding
> announcement
> > > > blog post [6][7].
> > > >
> > > > The vote will be open for at least 24 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Yu & Gary
> > > >
> > > > [1]
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12345845
> > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.10.0-rc2/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > https://repository.apache.org/content/repositories/orgapacheflink-1332
> > > > [5] https://github.com/apache/flink/releases/tag/release-1.10.0-rc2
> > > > [6] https://github.com/apache/flink-web/pull/302
> > > > [7] https://github.com/apache/flink-web/pull/301
> > > >
> > >
> >
>
>
> --
> Best Regards
>
> Jeff Zhang
>


-- 
Best, Jingsong Lee

Reply via email to