Hi Jinhai, thanks for driving. +1 to remove, I think we can remove StreamQueryConfig too. since we have deprecated StreamQueryConfig two versions.
Remember to record it in release notes of issue. Best, Jingsong Lee On Wed, Mar 18, 2020 at 5:58 PM jinhai wang <jinhai...@gmail.com> wrote: > Hi Devs > > I would like to start the formal discussion about FLINK-16648. > > StreamQueryConfig is deprecated and replaced by TableConfig in the future, > and TableEnvironment class has config object. > > Do we need to delete the interfaces in StreamTableEnvironment and > StreamTableEnvironmentImpl: > toAppendStream(Table table, Class<T> clazz, StreamQueryConfig queryConfig); > toAppendStream(Table table, TypeInformation<T> typeInfo, StreamQueryConfig > queryConfig); > toRetractStream(Table table, Class<T> clazz, StreamQueryConfig > queryConfig); > toRetractStream(Table table, TypeInformation<T> typeInfo, > StreamQueryConfig queryConfig); > void sqlUpdate(String stmt, StreamQueryConfig config); > void insertInto(Table table, StreamQueryConfig queryConfig, String > sinkPath, String... sinkPathContinued); > > > Best Regards > > jinhai...@gmail.com > > -- Best, Jingsong Lee
