Re: [Discuss] CRD for flink sql gateway in the flink k8s operator

2023-09-15 Thread ConradJam
If we start from the crd direction, I think this mode is more like a sidecar of the session cluster, which is submitted to the session cluster by sending sql commands to the sql gateway. I don't know if my statement is accurate. Xiaolong Wang 于2023年9月15日周五 13:27写道: > Hi, Dongwoo, > > Since Flink

[jira] [Created] (FLINK-33092) Improve the resource-stabilization-timeout mechanism when rescale a job for Adaptive Scheduler

2023-09-15 Thread Rui Fan (Jira)
Rui Fan created FLINK-33092: --- Summary: Improve the resource-stabilization-timeout mechanism when rescale a job for Adaptive Scheduler Key: FLINK-33092 URL: https://issues.apache.org/jira/browse/FLINK-33092

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-15 Thread Martijn Visser
Hi all, I think Jark has a valid point with: > Does this mean that in the future we might add an option to disable each feature? I don't think that's a reasonable outcome indeed, but we are currently in a situation where we don't have clear guidelines on when to add a configuration option, and w

Re: [Discuss] CRD for flink sql gateway in the flink k8s operator

2023-09-15 Thread Yangze Guo
Thanks for bringing this up, Dongwoo. Flink SQL Gateway is also a key component for OLAP scenarios. @Gyula How about add sql gateway as an optional component to Session Cluster Deployments. User can specify the resource / instance number and ports of the sql gateway. I think that would help a lot

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-15 Thread Yangze Guo
+1 (binding) Best, Yangze Guo On Thu, Sep 14, 2023 at 5:47 PM Maximilian Michels wrote: > > +1 (binding) > > On Thu, Sep 14, 2023 at 4:26 AM Venkatakrishnan Sowrirajan > wrote: > > > > +1 (non-binding) > > > > On Wed, Sep 13, 2023, 6:55 PM Matt Wang wrote: > > > > > +1 (non-binding) > > > > >

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-15 Thread Jark Wu
Hi Martijn, I can understand that. Is there any database/system that supports disabling/enabling query hints with a configuration? This might help us to understand the use case, and follow the approach. Best, Jark On Fri, 15 Sept 2023 at 15:34, Martijn Visser wrote: > Hi all, > > I think Jark

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-15 Thread Yangze Guo
Thanks for driving this, Zhanghao. +1 for the overall proposal. Some cents from my side: 1. Since most of the rest api get the location from TaskManagerLocation, we can align the string formatter in this class. E.g. add something like toHumanRealableString to this class. 2. From my understanding

Re: [DISCUSS] Flink annotation strategy/consensus

2023-09-15 Thread Chesnay Schepler
We need the @Internal annotation for cases where a user-facing class has methods entirely meant for internal uses. It's not great that we have these cases to being with, but fixing that is another story. The semantics for non-annotated classes is already documented. https://nightlies.apache.org

Re: [Discuss] CRD for flink sql gateway in the flink k8s operator

2023-09-15 Thread Gyula Fóra
There would be many different ways of doing this. One gateway per session cluster, one gateway shared across different clusters... I would not rush to add anything anywhere until we understand the tradeoff and the simplest way of accomplishing this. The operator already supports ingresses for sess

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-15 Thread Martijn Visser
Hi Jark, Oracle has/had a generic "OPTIMIZER_IGNORE_HINTS" [1]. It looks like MSSQL has configuration options to disable specific hints [2] instead of a generic solution. [1] https://docs.oracle.com/en/database/oracle/oracle-database/23/refrn/OPTIMIZER_IGNORE_HINTS.html#GUID-D62CA6D8-D0D8-4A20-93

RE: Inconsistent build Flink from source in readme and docs

2023-09-15 Thread David Radley
Hi Sergey, Thanks for your response. To summarise: Flink 1.17 needs Maven 3.25 or 3.3.x with shading Flink current master and 1.18 when released will require 3.8.6 (recommended or higher if it works). I suggest that for the 1.18 build we include, we police the Maven version number in the build.

FW: RE: Inconsistent build Flink from source in readme and docs

2023-09-15 Thread David Radley
Hi again, I have just checked and you already enforcer have the enforcer for this in master. I guess the only extra piece would be to put out a warning for java 8 indicating it is deprecated – I could look at that in a Jira, Kind regards, David. From: David Radley Date: Friday, 15 Septem

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-15 Thread Jark Wu
Hi Martijn, Thanks for the investigation. I found the blog[1] shows a use case that they use "OPTIMIZER_IGNORE_HINTS" to check if embedded hints can be removed in legacy code. I think this is a useful tool to improve queries without complex hints strewn throughout the code. Therefore, I'm fine to

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-15 Thread Chen Zhanghao
Hi Yangze, Thanks for the input, totally agree with you, will take the advice. Best, Zhanghao Chen 发件人: Yangze Guo 发送时间: 2023年9月15日 17:26 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web

回复: [DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-15 Thread Chen Zhanghao
Hi Yun, Thanks for the input. Agree with that setting parallelism for each operator is also valuable, and compiled plan should work. However, this would significantly increase the complexity. I'd rather make the FLIP focused and leave it for future work. WDYT? Best, Zhanghao Chen _

FW: FW: RE: Inconsistent build Flink from source in readme and docs

2023-09-15 Thread David Radley
Hi, I have looked further into the pom file in master. I see: If I run locally: mvn clean install -DskipTests It does not appear to run the enforcer checks. I see that the enforcer checks for the higher versions are only in the release profile. I notice that elsewhere in the pom file :

回复: [DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-15 Thread Chen Zhanghao
Hi Jane, Thanks for the valuable suggestions. For Q1, it's indeed an issue. Some possible ideas include introducing a fake transformation after the source that takes the global default parallelism, or simply make exec nodes to take the global default parallelism, but both ways prevent potentia

Re: [DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-15 Thread Martijn Visser
Hi everyone, Thanks for the FLIP and the discussion. I find it exciting. Thanks for pushing for this. Best regards, Martijn On Fri, Sep 15, 2023 at 2:25 PM Chen Zhanghao wrote: > Hi Jane, > > Thanks for the valuable suggestions. > > For Q1, it's indeed an issue. Some possible ideas include in

Re: [DISCUSS]clean up the savepoints compatibility table

2023-09-15 Thread Martijn Visser
Hi Jing, I think it's fine to update the table to include lesser versions, as long as we provide a link to an older version of the table, for users who might be trying to upgrade from an older Flink version to the latest, so that they are aware of potential issues that could run into. Best regard

Re: [DISCUSS] FLIP-327: Support stream-batch unified operator to improve job throughput when processing backlog data

2023-09-15 Thread Dong Lin
Hi Xintong, Thanks for your comments! Please see my reply inline. On Thu, Sep 14, 2023 at 4:58 PM Xintong Song wrote: > Sorry to join the discussion late. > > Overall, I think it's a good idea to support dynamically switching the > operator algorithms between Streaming (optimized towards low la

[jira] [Created] (FLINK-33093) SHOW FUNCTIONS throw exception with unset catalog

2023-09-15 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33093: Summary: SHOW FUNCTIONS throw exception with unset catalog Key: FLINK-33093 URL: https://issues.apache.org/jira/browse/FLINK-33093 Project: Flink Iss

Re: [DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-15 Thread ConradJam
+ 1 Thanks for the FLIP and the discussion. I would like to ask whether to use SQL Hint syntax to set this parallelism? Martijn Visser 于2023年9月15日周五 20:52写道: > Hi everyone, > > Thanks for the FLIP and the discussion. I find it exciting. Thanks for > pushing for this. > > Best regards, > > Martij

[jira] [Created] (FLINK-33094) KUBERNETES_KERBEROS_MOUNT_DECORATOR_ENABLED(kubernetes.decorator.kerberos-mount.enabled) not works

2023-09-15 Thread Lee SeungMin (Jira)
Lee SeungMin created FLINK-33094: Summary: KUBERNETES_KERBEROS_MOUNT_DECORATOR_ENABLED(kubernetes.decorator.kerberos-mount.enabled) not works Key: FLINK-33094 URL: https://issues.apache.org/jira/browse/FLINK-3309

Re: [DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-15 Thread Yun Tang
Hi Zhanghao, Certainly, I think we shall leave this FLIP focus on setting the source parallelism via DDL's properties. I just want to clarify that setting parallelism for individual operators is also profitable from my experience, which is slighted in your FLIP. @ConradJam BTW, compared with S

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-15 Thread Rui Fan
+1(binding) Best, Rui On Thu, Sep 14, 2023 at 10:06 AM liu ron wrote: > +1(non-binding) > > Best, > Ron > > Dong Lin 于2023年9月14日周四 09:01写道: > > > Thank you Rui for the proposal. > > > > +1 (binding) > > > > On Wed, Sep 13, 2023 at 10:52 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > > Hi all

[RESULT][VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-15 Thread Rui Fan
Hi all, Thanks everyone for your review and the votes! I am happy to announce that FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler[1] has been accepted. There are 4 binding votes and 8 non-binding vote [2]: - Gyula Fora (binding) - Maximilian Michels (bindin

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-15 Thread Weihua Hu
+1 (binding) Best, Weihua On Fri, Sep 15, 2023 at 4:28 PM Yangze Guo wrote: > +1 (binding) > > Best, > Yangze Guo > > On Thu, Sep 14, 2023 at 5:47 PM Maximilian Michels wrote: > > > > +1 (binding) > > > > On Thu, Sep 14, 2023 at 4:26 AM Venkatakrishnan Sowrirajan > > wrote: > > > > > > +1 (n

Re: [DISCUSS] FLIP-307: Flink connector Redshift

2023-09-15 Thread Samrat Deb
Hello Martijn, I apologize for the delay in responding. Regarding your question about integrating Redshift directly into the JDBC connector, we are planning to offer two modes: JDBC and UNLOAD. Through our internal benchmarking, we have observed good performance in the UNLOAD flow. Additionally,

Re: [DISCUSS] FLIP-229: Prometheus Sink Connector

2023-09-15 Thread Lorenzo Nicora
Hello (apologies if this is a duplicate reply) I was working with Karthi on this connector, and I have taken over the development. We have a working version we would like to submit to the community. The renumbered FLIP-312 is also updated with more details [1]. Happy to answer any questions. Re