Re: [VOTE] Release 1.12.1, release candidate #1

+1 for canceling the RC to fix FLINK-20632. Thanks a lot for driving this effort Xintong and Robert! Cheers, Till On Wed, Jan 6, 2021 at 1:01 PM Xintong Song wrote: > Thanks for driving the docker image efforts, Robert. > > +1 for canceling this RC. That should also give us the chance to fix >

Re: [VOTE] Release 1.12.1, release candidate #1

Thanks for driving the docker image efforts, Robert. +1 for canceling this RC. That should also give us the chance to fix FLINK-20781. I'll try to create the next release candidate as soon as the following blockers are resolved. * FLINK-20781: UnalignedCheckpointITCase failure caused by NullPoint

Re: [VOTE] Release 1.12.1, release candidate #1

The Docker images for Flink 1.12.0 are still not on Docker Hub (the official images), because they were not accepted by Docker. To avoid such issues in the future, we've decided to additionally publish the Docker images on GitHub as part of the release process (immediately) [1]. We still intend to

Re: [VOTE] Release 1.12.1, release candidate #1

+1 (non-binding) - Verified checksums and signatures - No binaries found in source archive - Build from source - Tried a couple of example jobs in various deployment mode - Local - Standalone - Native Kubernetes Application & Session with image built locally - Y

Re: [VOTE] Release 1.12.1, release candidate #1

Thanks for the clarification, @Matthias. Thank you~ Xintong Song On Wed, Dec 30, 2020 at 1:21 AM Matthias Pohl wrote: > Hi Xintong, > I'm withdrawing my veto. Becket's proposed way of fixing it sounds fine. > Sorry for not being clear enough in my previous message. > > Best, > Matthias > > O

Re: [VOTE] Release 1.12.1, release candidate #1

Hi Xintong, I'm withdrawing my veto. Becket's proposed way of fixing it sounds fine. Sorry for not being clear enough in my previous message. Best, Matthias On Tue, Dec 29, 2020 at 8:11 AM Xintong Song wrote: > Hi Matthias, > I think Becket's opinion is not to block this release on FLINK-20781,

Re: [VOTE] Release 1.12.1, release candidate #1

Hi Matthias, I think Becket's opinion is not to block this release on FLINK-20781, thus not to cancel the vote for this rc1. Since you have already voted -1, I'd like to understand your opinion on this release candidate now. Do you still believe we should not approve rc1 because of FLINK-20781, or

Re: [VOTE] Release 1.12.1, release candidate #1

I think Becket's proposal in [1] sounds reasonable having the quickfix in place for 1.12.1. Thanks, Matthias [1] https://issues.apache.org/jira/browse/FLINK-20781 On Mon, Dec 28, 2020 at 1:51 PM Xintong Song wrote: > @Becket, > > Thanks for the clarification. Sorry, I misunderstood what you me

Re: [VOTE] Release 1.12.1, release candidate #1

I think we may hold announcing this release until the 1.12.1 official image is available. For the other approaches discussed in FLINK-20632 (hosting Docker images ourselves, moving most of entrypoint scripts into the Flink repository, etc.), maybe we can address them in future releases. Thank you

Re: [VOTE] Release 1.12.1, release candidate #1

Should we maybe wait with this release until we have the docker issue sorted out? On 12/28/2020 1:51 PM, Xintong Song wrote: @Becket, Thanks for the clarification. Sorry, I misunderstood what you meant on the jira. Seems it's not necessary to cancel this vote. WDYT, @Matthias? Thank you~ Xi

Re: [VOTE] Release 1.12.1, release candidate #1

@Becket, Thanks for the clarification. Sorry, I misunderstood what you meant on the jira. Seems it's not necessary to cancel this vote. WDYT, @Matthias? Thank you~ Xintong Song On Mon, Dec 28, 2020 at 8:42 PM Becket Qin wrote: > Hi Xintong, > > Thanks for driving the release. I just replie

Re: [VOTE] Release 1.12.1, release candidate #1

Hi Xintong, Thanks for driving the release. I just replied to FLINK-20781. Personally I don't think that is a blocker for release-1.12.1. The reasons are: 1. The root cause of the issue is thread unsafe shutdown sequence of the mailbox task. It is an issue for a while, SourceOperator just exposes

Re: [VOTE] Release 1.12.1, release candidate #1

@Becket has confirmed on the jira ticket that FLINK-20781 is indeed a bug. I‘m hereby officially canceling this vote. At the same time, it is appreciated to continue verifying the release candidate and reporting issues, so they can be fixed by the next release candidate. The RC#2 will be created

Re: [VOTE] Release 1.12.1, release candidate #1

Thanks for reporting the issue, @Matthias. @Becket, could you check if this should be a release blocker? Thank you~ Xintong Song On Mon, Dec 28, 2020 at 3:24 PM Matthias Pohl wrote: > -1 (non-binding) > > Could someone have a look into FLINK-20781 [1] to see whether this is a > problem for

Re: [VOTE] Release 1.12.1, release candidate #1

-1 (non-binding) Could someone have a look into FLINK-20781 [1] to see whether this is a problem for 1.12.1? It seems that it's introduced by FLINK-20492 [2]. Best, Matthias [1] https://issues.apache.org/jira/browse/FLINK-20781 [2] https://issues.apache.org/jira/browse/FLINK-20492 On Sat, Dec 2

[VOTE] Release 1.12.1, release candidate #1

Hi everyone, Please review and vote on the release candidate #1 for the version 1.12.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],