I think Becket's proposal in [1] sounds reasonable having the quickfix in place for 1.12.1.
Thanks, Matthias [1] https://issues.apache.org/jira/browse/FLINK-20781 On Mon, Dec 28, 2020 at 1:51 PM Xintong Song <tonysong...@gmail.com> wrote: > @Becket, > > Thanks for the clarification. Sorry, I misunderstood what you meant on the > jira. > > Seems it's not necessary to cancel this vote. WDYT, @Matthias? > > Thank you~ > > Xintong Song > > > > On Mon, Dec 28, 2020 at 8:42 PM Becket Qin <becket....@gmail.com> wrote: > > > Hi Xintong, > > > > Thanks for driving the release. I just replied to FLINK-20781. > Personally I > > don't think that is a blocker for release-1.12.1. The reasons are: > > > > 1. The root cause of the issue is thread unsafe shutdown sequence of the > > mailbox task. It is an issue for a while, SourceOperator just exposes > this > > issue. > > 2. The issue only occurs occasionally when a task exits, and the > > consequence is that the job will just failover. > > > > I am happy to put a band-aid on the SourceOperator so the NPE won't be > > thrown. But a correct fix would be fixing the mailbox shutdown sequence, > > which does not seem a blocker for release-1.12.1. > > > > Thanks, > > > > Jiangjie (Becket) Qin > > > > On Mon, Dec 28, 2020 at 7:37 PM Xintong Song <tonysong...@gmail.com> > > wrote: > > > > > @Becket has confirmed on the jira ticket that FLINK-20781 is indeed a > > bug. > > > > > > I‘m hereby officially canceling this vote. > > > > > > At the same time, it is appreciated to continue verifying the release > > > candidate and reporting issues, so they can be fixed by the next > release > > > candidate. > > > > > > The RC#2 will be created as soon as the reported blockers are fixed. > > > > > > Thank you~ > > > > > > Xintong Song > > > > > > > > > > > > On Mon, Dec 28, 2020 at 3:37 PM Xintong Song <tonysong...@gmail.com> > > > wrote: > > > > > > > Thanks for reporting the issue, @Matthias. > > > > > > > > @Becket, could you check if this should be a release blocker? > > > > > > > > Thank you~ > > > > > > > > Xintong Song > > > > > > > > > > > > > > > > On Mon, Dec 28, 2020 at 3:24 PM Matthias Pohl < > matth...@ververica.com> > > > > wrote: > > > > > > > >> -1 (non-binding) > > > >> > > > >> Could someone have a look into FLINK-20781 [1] to see whether this > is > > a > > > >> problem for 1.12.1? It seems that it's introduced by FLINK-20492 > [2]. > > > >> > > > >> Best, > > > >> Matthias > > > >> > > > >> [1] https://issues.apache.org/jira/browse/FLINK-20781 > > > >> [2] https://issues.apache.org/jira/browse/FLINK-20492 > > > >> > > > >> On Sat, Dec 26, 2020 at 1:53 AM Xintong Song <xts...@apache.org> > > wrote: > > > >> > > > >> > Hi everyone, > > > >> > > > > >> > Please review and vote on the release candidate #1 for the version > > > >> 1.12.1, > > > >> > as follows: > > > >> > > > > >> > [ ] +1, Approve the release > > > >> > [ ] -1, Do not approve the release (please provide specific > > comments) > > > >> > > > > >> > The complete staging area is available for your review, which > > > includes: > > > >> > * JIRA release notes [1], > > > >> > * the official Apache source release and binary convenience > releases > > > to > > > >> be > > > >> > deployed to dist.apache.org [2], which are signed with the key > with > > > >> > fingerprint F8E419AA0B60C28879E876859DFF40967ABFC5A4 [3], > > > >> > * all artifacts to be deployed to the Maven Central Repository > [4], > > > >> > * source code tag "release-1.12.1-rc1" [5], > > > >> > * website pull request listing the new release and adding > > announcement > > > >> blog > > > >> > post [6]. > > > >> > > > > >> > The vote will be open for at least 72 hours. It is adopted by > > majority > > > >> > approval, with at least 3 PMC affirmative votes. > > > >> > > > > >> > Thanks, > > > >> > Xintong Song > > > >> > > > > >> > [1] > > > >> > > > > >> > > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12349459 > > > >> > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.1-rc1 > > > >> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >> > <https://dist.apache.org/repos/dist/release/flink/KEYS> > > > >> > [4] > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1410 > > > >> > [5] > https://github.com/apache/flink/releases/tag/release-1.12.1-rc1 > > > >> > [6] https://github.com/apache/flink-web/pull/405 > > > >> > <https://github.com/apache/flink-web/pull/399> > > > >> > > > > > > > > >
