The Docker images for Flink 1.12.0 are still not on Docker Hub (the official images), because they were not accepted by Docker. To avoid such issues in the future, we've decided to additionally publish the Docker images on GitHub as part of the release process (immediately) [1]. We still intend to publish the official images to Docker Hub, but with potential delays. For Flink 1.12.1, it would be nice to update the docker image defaults to the Github Packages hosting, so that Flink on Kubernetes works out of the box, irrespective of potential delays due to the Docker Hub official images review process.
I propose to cancel this RC and open a new one with the defaults updated. I'll prepare a PR for that. [1] https://issues.apache.org/jira/browse/FLINK-20632 On Wed, Dec 30, 2020 at 4:42 AM Xintong Song <tonysong...@gmail.com> wrote: > +1 (non-binding) > > - Verified checksums and signatures > - No binaries found in source archive > - Build from source > - Tried a couple of example jobs in various deployment mode > - Local > - Standalone > - Native Kubernetes Application & Session with image built locally > - Yarn Job & Session > - UI and logs look good > > Thank you~ > > Xintong Song > > > > On Wed, Dec 30, 2020 at 11:40 AM Xintong Song <tonysong...@gmail.com> > wrote: > > > Thanks for the clarification, @Matthias. > > > > Thank you~ > > > > Xintong Song > > > > > > > > On Wed, Dec 30, 2020 at 1:21 AM Matthias Pohl <matth...@ververica.com> > > wrote: > > > >> Hi Xintong, > >> I'm withdrawing my veto. Becket's proposed way of fixing it sounds fine. > >> Sorry for not being clear enough in my previous message. > >> > >> Best, > >> Matthias > >> > >> On Tue, Dec 29, 2020 at 8:11 AM Xintong Song <tonysong...@gmail.com> > >> wrote: > >> > >>> Hi Matthias, > >>> I think Becket's opinion is not to block this release on FLINK-20781, > >>> thus not to cancel the vote for this rc1. > >>> Since you have already voted -1, I'd like to understand your opinion on > >>> this release candidate now. > >>> Do you still believe we should not approve rc1 because of FLINK-20781, > >>> or would you be ok to withdraw the veto based on Becket's comments? > >>> > >>> Thank you~ > >>> > >>> Xintong Song > >>> > >>> > >>> > >>> On Tue, Dec 29, 2020 at 2:39 PM Matthias Pohl <matth...@ververica.com> > >>> wrote: > >>> > >>>> I think Becket's proposal in [1] sounds reasonable having the quickfix > >>>> in > >>>> place for 1.12.1. > >>>> > >>>> Thanks, > >>>> Matthias > >>>> > >>>> [1] https://issues.apache.org/jira/browse/FLINK-20781 > >>>> > >>>> On Mon, Dec 28, 2020 at 1:51 PM Xintong Song <tonysong...@gmail.com> > >>>> wrote: > >>>> > >>>> > @Becket, > >>>> > > >>>> > Thanks for the clarification. Sorry, I misunderstood what you meant > >>>> on the > >>>> > jira. > >>>> > > >>>> > Seems it's not necessary to cancel this vote. WDYT, @Matthias? > >>>> > > >>>> > Thank you~ > >>>> > > >>>> > Xintong Song > >>>> > > >>>> > > >>>> > > >>>> > On Mon, Dec 28, 2020 at 8:42 PM Becket Qin <becket....@gmail.com> > >>>> wrote: > >>>> > > >>>> > > Hi Xintong, > >>>> > > > >>>> > > Thanks for driving the release. I just replied to FLINK-20781. > >>>> > Personally I > >>>> > > don't think that is a blocker for release-1.12.1. The reasons are: > >>>> > > > >>>> > > 1. The root cause of the issue is thread unsafe shutdown sequence > >>>> of the > >>>> > > mailbox task. It is an issue for a while, SourceOperator just > >>>> exposes > >>>> > this > >>>> > > issue. > >>>> > > 2. The issue only occurs occasionally when a task exits, and the > >>>> > > consequence is that the job will just failover. > >>>> > > > >>>> > > I am happy to put a band-aid on the SourceOperator so the NPE > won't > >>>> be > >>>> > > thrown. But a correct fix would be fixing the mailbox shutdown > >>>> sequence, > >>>> > > which does not seem a blocker for release-1.12.1. > >>>> > > > >>>> > > Thanks, > >>>> > > > >>>> > > Jiangjie (Becket) Qin > >>>> > > > >>>> > > On Mon, Dec 28, 2020 at 7:37 PM Xintong Song < > tonysong...@gmail.com > >>>> > > >>>> > > wrote: > >>>> > > > >>>> > > > @Becket has confirmed on the jira ticket that FLINK-20781 is > >>>> indeed a > >>>> > > bug. > >>>> > > > > >>>> > > > I‘m hereby officially canceling this vote. > >>>> > > > > >>>> > > > At the same time, it is appreciated to continue verifying the > >>>> release > >>>> > > > candidate and reporting issues, so they can be fixed by the next > >>>> > release > >>>> > > > candidate. > >>>> > > > > >>>> > > > The RC#2 will be created as soon as the reported blockers are > >>>> fixed. > >>>> > > > > >>>> > > > Thank you~ > >>>> > > > > >>>> > > > Xintong Song > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > On Mon, Dec 28, 2020 at 3:37 PM Xintong Song < > >>>> tonysong...@gmail.com> > >>>> > > > wrote: > >>>> > > > > >>>> > > > > Thanks for reporting the issue, @Matthias. > >>>> > > > > > >>>> > > > > @Becket, could you check if this should be a release blocker? > >>>> > > > > > >>>> > > > > Thank you~ > >>>> > > > > > >>>> > > > > Xintong Song > >>>> > > > > > >>>> > > > > > >>>> > > > > > >>>> > > > > On Mon, Dec 28, 2020 at 3:24 PM Matthias Pohl < > >>>> > matth...@ververica.com> > >>>> > > > > wrote: > >>>> > > > > > >>>> > > > >> -1 (non-binding) > >>>> > > > >> > >>>> > > > >> Could someone have a look into FLINK-20781 [1] to see whether > >>>> this > >>>> > is > >>>> > > a > >>>> > > > >> problem for 1.12.1? It seems that it's introduced by > >>>> FLINK-20492 > >>>> > [2]. > >>>> > > > >> > >>>> > > > >> Best, > >>>> > > > >> Matthias > >>>> > > > >> > >>>> > > > >> [1] https://issues.apache.org/jira/browse/FLINK-20781 > >>>> > > > >> [2] https://issues.apache.org/jira/browse/FLINK-20492 > >>>> > > > >> > >>>> > > > >> On Sat, Dec 26, 2020 at 1:53 AM Xintong Song < > >>>> xts...@apache.org> > >>>> > > wrote: > >>>> > > > >> > >>>> > > > >> > Hi everyone, > >>>> > > > >> > > >>>> > > > >> > Please review and vote on the release candidate #1 for the > >>>> version > >>>> > > > >> 1.12.1, > >>>> > > > >> > as follows: > >>>> > > > >> > > >>>> > > > >> > [ ] +1, Approve the release > >>>> > > > >> > [ ] -1, Do not approve the release (please provide specific > >>>> > > comments) > >>>> > > > >> > > >>>> > > > >> > The complete staging area is available for your review, > which > >>>> > > > includes: > >>>> > > > >> > * JIRA release notes [1], > >>>> > > > >> > * the official Apache source release and binary convenience > >>>> > releases > >>>> > > > to > >>>> > > > >> be > >>>> > > > >> > deployed to dist.apache.org [2], which are signed with the > >>>> key > >>>> > with > >>>> > > > >> > fingerprint F8E419AA0B60C28879E876859DFF40967ABFC5A4 [3], > >>>> > > > >> > * all artifacts to be deployed to the Maven Central > >>>> Repository > >>>> > [4], > >>>> > > > >> > * source code tag "release-1.12.1-rc1" [5], > >>>> > > > >> > * website pull request listing the new release and adding > >>>> > > announcement > >>>> > > > >> blog > >>>> > > > >> > post [6]. > >>>> > > > >> > > >>>> > > > >> > The vote will be open for at least 72 hours. It is adopted > by > >>>> > > majority > >>>> > > > >> > approval, with at least 3 PMC affirmative votes. > >>>> > > > >> > > >>>> > > > >> > Thanks, > >>>> > > > >> > Xintong Song > >>>> > > > >> > > >>>> > > > >> > [1] > >>>> > > > >> > > >>>> > > > >> > > >>>> > > > >> > >>>> > > > > >>>> > > > >>>> > > >>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12349459 > >>>> > > > >> > [2] > >>>> https://dist.apache.org/repos/dist/dev/flink/flink-1.12.1-rc1 > >>>> > > > >> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>> > > > >> > <https://dist.apache.org/repos/dist/release/flink/KEYS> > >>>> > > > >> > [4] > >>>> > > > >> > >>>> > > > >>>> > https://repository.apache.org/content/repositories/orgapacheflink-1410 > >>>> > > > >> > [5] > >>>> > https://github.com/apache/flink/releases/tag/release-1.12.1-rc1 > >>>> > > > >> > [6] https://github.com/apache/flink-web/pull/405 > >>>> > > > >> > <https://github.com/apache/flink-web/pull/399> > >>>> > > > >> > >>>> > > > > > >>>> > > > > >>>> > > > >>>> > >>> > >> > >> -- > >> > >> Matthias Pohl | Engineer > >> > >> Follow us @VervericaData Ververica <https://www.ververica.com/> > >> > >> -- > >> > >> Join Flink Forward <https://flink-forward.org/> - The Apache Flink > >> Conference > >> > >> Stream Processing | Event Driven | Real Time > >> > >> -- > >> > >> Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany > >> > >> -- > >> Ververica GmbH > >> Registered at Amtsgericht Charlottenburg: HRB 158244 B > >> Managing Directors: Yip Park Tung Jason, Jinwei (Kevin) Zhang, Karl > Anton > >> Wehner > >> > > >
