[RESULT][VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-09 Thread Xintong Song
Hi devs, I'm happy to announce that FLIP-141[1] is officially approved. The vote [2] has been opened for more than 72h + weekends, and we have received 9 +1s, 8 of which are binding, and no vetos. Thanks everyone for participating. * Xintong (binding) * Till (binding) * Dian (binding) * Zhu (bin

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-09 Thread Xintong Song
Thanks everyone, I'm closing this vote now in a separate email. Concerning the naming, I will use DATAPROC, as @Stephan suggested in the discussion thread [1], for now. If there are any other opinions, feel free to reach out to me anytime before the release. Thank you~ Xintong Song [1] http:/

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-09 Thread Andrey Zagrebin
For the option name, maybe: *flink.main* or *flink.managed* (this may be a bit confusing for existing users as we said that the overall managed memory is managed by Flink) On Wed, Sep 9, 2020 at 9:56 AM Andrey Zagrebin wrote: > +1 > > Best, > Andrey > > On Tue, Sep 8, 2020 at 2:16 PM Yu Li wrot

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-09 Thread Andrey Zagrebin
+1 Best, Andrey On Tue, Sep 8, 2020 at 2:16 PM Yu Li wrote: > +1 > > Best Regards, > Yu > > > On Tue, 8 Sep 2020 at 17:03, Aljoscha Krettek wrote: > > > +1 > > > > We just need to make sure to find a good name before the release but > > shouldn't block any work on this. > > > > Aljoscha > > >

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-08 Thread Yu Li
+1 Best Regards, Yu On Tue, 8 Sep 2020 at 17:03, Aljoscha Krettek wrote: > +1 > > We just need to make sure to find a good name before the release but > shouldn't block any work on this. > > Aljoscha > > On 08.09.20 07:59, Xintong Song wrote: > > Thanks for the vote, @Jincheng. > > > > > > Con

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-08 Thread Aljoscha Krettek
+1 We just need to make sure to find a good name before the release but shouldn't block any work on this. Aljoscha On 08.09.20 07:59, Xintong Song wrote: Thanks for the vote, @Jincheng. Concerning the namings, the original idea was, as you suggested, to have separate configuration names fo

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-07 Thread Xintong Song
Thanks for the vote, @Jincheng. Concerning the namings, the original idea was, as you suggested, to have separate configuration names for batch and rocksdb while only one of them will take effect at a time. It was then in the discussion thread [1] that @Stepahn suggested to combine these two.

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-07 Thread jincheng sun
+1 for the proposal! Regarding the name of `BATCH_OP/ROCKSDB`, we can reserve the configuration names for batch and rocksdb respectively, ` batch_ OP` for batch, "ROCKSDB" for roockdb. and the default value as follows: { BATCH_OP: 70, ROCKSDB : 70, PYTHON : 30 } Only one of `BATCH_ O

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-06 Thread Xintong Song
Thanks for the votes. Concerning the name for batch/RocksDB memory consumer, how about "execution memory"? We can further explain in docs and config option description that this is used for job execution, which is currently dedicated to rocksdb in streaming and batch algorithms in batch. Thank yo

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-06 Thread Yangze Guo
+1 Best, Yangze Guo On Mon, Sep 7, 2020 at 10:54 AM Zhu Zhu wrote: > > +1 > > Thanks, > Zhu > > Dian Fu 于2020年9月7日周一 上午10:34写道: > > > +1 > > > > > 在 2020年9月3日,下午8:46,Till Rohrmann 写道: > > > > > > Hi Xintong, > > > > > > thanks for starting the vote. > > > > > > +1 for the proposal given that w

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-06 Thread Zhu Zhu
+1 Thanks, Zhu Dian Fu 于2020年9月7日周一 上午10:34写道: > +1 > > > 在 2020年9月3日,下午8:46,Till Rohrmann 写道: > > > > Hi Xintong, > > > > thanks for starting the vote. > > > > +1 for the proposal given that we find a proper name for the > > different memory consumers (specifically the batch/RocksDB consumer)

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-06 Thread Dian Fu
+1 > 在 2020年9月3日,下午8:46,Till Rohrmann 写道: > > Hi Xintong, > > thanks for starting the vote. > > +1 for the proposal given that we find a proper name for the > different memory consumers (specifically the batch/RocksDB consumer) and > their corresponding weights. > > Cheers, > Till > > On Thu

Re: [VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-03 Thread Till Rohrmann
Hi Xintong, thanks for starting the vote. +1 for the proposal given that we find a proper name for the different memory consumers (specifically the batch/RocksDB consumer) and their corresponding weights. Cheers, Till On Thu, Sep 3, 2020 at 12:43 PM Xintong Song wrote: > Hi devs, > > I'd like

[VOTE] FLIP-141: Intra-Slot Managed Memory Sharing

2020-09-03 Thread Xintong Song
Hi devs, I'd like to start a voting thread on FLIP-141[1], which proposes how managed memory should be shared by various use cases within a slot. The proposal has been discussed in [2]. The vote will be open for at least 72h + weekends. I'll try to close it on September 8, unless there is an obje