Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
Quick update: Ufuk and me worked on fixing the last issues for 0.9.1 today, bringing the branch up to speed for the minor release. Ufuk de facto stepped up as release manager and will create a release candidate later today or early tomorrow. So we can get cracking with testing the release candida

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Liang Chen
Agree. keep major version stability and compatibility, always being considered as first. -- View this message in context: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSSION-Release-current-master-as-0-9-1-mod-few-changes-tp7679p7680.html Sent from the Apache Flink Maili

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Henry Saputra
I am +1 for this idea. - Henry On Wed, Aug 26, 2015 at 3:07 AM, Robert Metzger wrote: > I'm against using the current master for 0.9.1. > It contains too many changes, posing the risk of changing APIs/semantics/... > I agree with Max that there was no consensus or discussion regarding the > sco

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Till Rohrmann
+1, good solution. On Wed, Aug 26, 2015 at 3:11 PM, Márton Balassi wrote: > +1 > > On Wed, Aug 26, 2015 at 3:11 PM, Maximilian Michels > wrote: > > > We will have a proper minor release and a preview of 0.10. After all, > > a good compromise. > > > > +1 > > > > On Wed, Aug 26, 2015 at 2:57 PM,

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Márton Balassi
+1 On Wed, Aug 26, 2015 at 3:11 PM, Maximilian Michels wrote: > We will have a proper minor release and a preview of 0.10. After all, > a good compromise. > > +1 > > On Wed, Aug 26, 2015 at 2:57 PM, Chiwan Park > wrote: > > Robert's suggestion looks good. +1 > > > > Sent from my iPhone > > > >>

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Maximilian Michels
We will have a proper minor release and a preview of 0.10. After all, a good compromise. +1 On Wed, Aug 26, 2015 at 2:57 PM, Chiwan Park wrote: > Robert's suggestion looks good. +1 > > Sent from my iPhone > >> On Aug 26, 2015, at 9:55 PM, Aljoscha Krettek wrote: >> >> +1 seems to be a viable so

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Chiwan Park
Robert's suggestion looks good. +1 Sent from my iPhone > On Aug 26, 2015, at 9:55 PM, Aljoscha Krettek wrote: > > +1 seems to be a viable solution > >> On Wed, 26 Aug 2015 at 14:51 Stephan Ewen wrote: >> >> That sounds like a very good compromise. >> >> +1 >> >>> On Wed, Aug 26, 2015 at 2:

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Aljoscha Krettek
+1 seems to be a viable solution On Wed, 26 Aug 2015 at 14:51 Stephan Ewen wrote: > That sounds like a very good compromise. > > +1 > > On Wed, Aug 26, 2015 at 2:48 PM, Fabian Hueske wrote: > > > I'm +1 for Robert's proposal as well. > > > > 2015-08-26 14:46 GMT+02:00 Ufuk Celebi : > > > > > +1

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Kostas Tzoumas
+1 for Robert's proposal On Wed, Aug 26, 2015 at 2:48 PM, Fabian Hueske wrote: > I'm +1 for Robert's proposal as well. > > 2015-08-26 14:46 GMT+02:00 Ufuk Celebi : > > > +1 > > > > I very much like Robert's suggestion. This way we can proceed with the > > 0.9.1 release as planned for the remain

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
That sounds like a very good compromise. +1 On Wed, Aug 26, 2015 at 2:48 PM, Fabian Hueske wrote: > I'm +1 for Robert's proposal as well. > > 2015-08-26 14:46 GMT+02:00 Ufuk Celebi : > > > +1 > > > > I very much like Robert's suggestion. This way we can proceed with the > > 0.9.1 release as pla

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Fabian Hueske
I'm +1 for Robert's proposal as well. 2015-08-26 14:46 GMT+02:00 Ufuk Celebi : > +1 > > I very much like Robert's suggestion. This way we can proceed with the > 0.9.1 release as planned for the remaining part and have 0.10-milestone1 > with the fix. > > What about the others? Please give feedback

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Ufuk Celebi
+1 I very much like Robert's suggestion. This way we can proceed with the 0.9.1 release as planned for the remaining part and have 0.10-milestone1 with the fix. What about the others? Please give feedback early to allow me to proceed with the release.

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Robert Metzger
I'm against using the current master for 0.9.1. It contains too many changes, posing the risk of changing APIs/semantics/... I agree with Max that there was no consensus or discussion regarding the scope of the 0.10 release. How about we release a 0.9.1 version containing all fixes we can easily a

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Maximilian Michels
I might not have made my point clear but I wrote: >However, I can see applying a subset of carefully selected commits from the >master branch as an option. And you wrote: >We can also try and "rebase" a fork of the maser to the "0.9" branch, where >we select something like 70%-80% of the commits

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
@mxm: I know the textbook theory ;-) The whole point here is that it is not possible to do that. Fixes and major reworks changes go together so tightly that you can get none or both. Not having the fixes voids the purpose of the bugfix release. Having both means it is hard to guarantee all change

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Maximilian Michels
A bugfix release should not be forked from the current master. It is very hard to asses whether we don't break the API because there are many small fixes going in almost daily. However, I can see applying a subset of carefully selected commits from the master branch as an option. Only those commits

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
@Aljoscha: Correct me if I am wrong, but did the change actually break anything user facing? The source function and source context interface look still the same. The underlying changes to introduce watermarks should not be visible to any user anyways at this point (if we remove the additional sou

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
The timestamp thing is one of the biggest questions. The fixes that came as part of that pull request are crucial and hard to pull out of the change. On Wed, Aug 26, 2015 at 10:44 AM, Aljoscha Krettek wrote: > I don't think we had to many API breaking changes. If everyone was careful, > maybe t

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Aljoscha Krettek
I don't think we had to many API breaking changes. If everyone was careful, maybe these are even it: https://cwiki.apache.org/confluence/display/FLINK/0.10+Release I added my breaking stuff there. And of course the whole Timestamp thing is a change, but it does not affect the normal source interfa

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Fabian Hueske
I am a bit skeptical about this proposal. A bug fix release should not change the interface and semantics of the API. It might be possible to catch the interface changes, but it will be really hard to ensure that the semantics are not touched. I see that there are many important fixes in the curre

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Stephan Ewen
We can also try and "rebase" a fork of the maser to the "0.9" branch, where we select something like 70%-80% of the commits (all fixes and reworks) and drop the API beaking ones. Let me try this and see how feasible it is... On Wed, Aug 26, 2015 at 9:52 AM, Ufuk Celebi wrote: > I think you are

Re: [DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-26 Thread Ufuk Celebi
I think you are the best one to assess this at the moment since you are doing the hard work of back porting the changes. Are you suggesting this, because it is a) less error-prone/easier or b) faster to do? For those that haven't followed the discussion: Stephan is back porting fixes for the stre

[DISCUSSION] Release current master as 0.9.1 (mod few changes)

2015-08-25 Thread Stephan Ewen
Hi all! I have started to try and backport some of the bugfixes on the latest master to the 0.9 branch, to be part of the 0.9.1 bugfixing release. While doing this, I came across so many places where critical bugs were fixed as parts of larger refactorings. It is very hard to backport these bug f