Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-14 Thread Becket Qin
standing of the Flink internals. But > > this > > > > is > > > > > > > probably not a big problem, if the plan is to eventually make > > this > > > > > > feature > > > > > > > default and remove the configuration option. > > > > > > > > > > &

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-14 Thread Jark Wu
s the system by having multiple code paths for > > > > > > StreamElement (de)serialization, and the logic for deciding which > > > path > > > > to > > > > > > be used. Admittedly, this is not super expensive, but still worth > > > >

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-11 Thread Gyula Fóra
> > > > have, it seems better to just do this optimization for peace-of-mind, > > as > > > > supposed to tell users that "Your Flink job performance can be > > > considerably > > > > optimal if your job's average record size is too small"

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-11 Thread Becket Qin
> > > If the latencyTrackingInterval is set too small(like 5ms), it will > > > have a > > > > > large impact on performance. But if the latencyTrackingInterval is > > > > > configured to be relatively large, such as 10s, this impact can be > > > > ignored. > > > > > > > > > &g

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-11 Thread Dong Lin
hink the benefit of this proposal > is > > > worth the cost. > > > > > > Best, > > > > > > Xintong > > > > > > > > > > > > On Mon, Aug 7, 2023 at 4:24 PM Yunfeng Zhou < > flink.zhouyunf...@gmail.com > > > > > > wrote: > > > >

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-11 Thread Xintong Song
rs are disabled? > > > > > > > > 3. I plan to benchmark the performance of this POC against TPC-DS and > > > > hope that it could cover the common use cases that you are concerned > > > > about. I believe there would still be performance improvement when

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-10 Thread Dong Lin
er. > > > > > > We use a latency marker to monitor the end-to-end latency of flink > jobs. > > If the latencyTrackingInterval is set too small(like 5ms), it will have a > > large impact on performance. But if the latencyTrackingInterval is > > configured to be relatively

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-10 Thread Yunfeng Zhou
> We use a latency marker to monitor the end-to-end latency of flink jobs. > > If the latencyTrackingInterval is set too small(like 5ms), it will have a > > large impact on performance. But if the latencyTrackingInterval is > > configured to be relatively large, such as 10s,

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-10 Thread Xintong Song
e impact on performance. But if the latencyTrackingInterval is > configured to be relatively large, such as 10s, this impact can be ignored. > > > > > > > > -- > > > > Best, > > Matt Wang > > > > > > ---- Replied Message > > | F

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-07 Thread Yunfeng Zhou
eplied Message > | From | Yunfeng Zhou | > | Date | 07/14/2023 20:30 | > | To | | > | Subject | Re: [DISCUSS] FLIP-330: Support specifying record timestamp > requirement | > Hi Matt, > > 1. I tried to add back the tag serialization process back to my POC > code and r

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-08-02 Thread Yunfeng Zhou
f the latency maker cannot be used, it will greatly > > limit > > > the usage scenarios. Whether the solution design can retain the > > capability > > > of the latency marker; > > > 3. The data of the POC test is of long type. Here I want to see how much > > > pro

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-31 Thread Jark Wu
lity > > of the latency marker; > > 3. The data of the POC test is of long type. Here I want to see how much > > profit it will have if it is a string with a length of 100B or 1KB. > > > > > > -- > > > > Best, > > Matt Wang > > > >

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-17 Thread Jing Ge
ee how much > profit it will have if it is a string with a length of 100B or 1KB. > > > -- > > Best, > Matt Wang > > > Replied Message > | From | Yunfeng Zhou | > | Date | 07/13/2023 14:52 | > | To | | > | Subject | Re: [DISCUSS] FLIP-330: Su

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-16 Thread Matt Wang
latencyTrackingInterval is configured to be relatively large, such as 10s, this impact can be ignored. -- Best, Matt Wang Replied Message | From | Yunfeng Zhou | | Date | 07/14/2023 20:30 | | To | | | Subject | Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-14 Thread Yunfeng Zhou
-- Replied Message > | From | Yunfeng Zhou | > | Date | 07/13/2023 14:52 | > | To | | > | Subject | Re: [DISCUSS] FLIP-330: Support specifying record timestamp > requirement | > Hi Jing, > > Thanks for reviewing this FLIP. > > 1. I did change the names of some AP

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-13 Thread Matt Wang
how much profit it will have if it is a string with a length of 100B or 1KB. -- Best, Matt Wang Replied Message | From | Yunfeng Zhou | | Date | 07/13/2023 14:52 | | To | | | Subject | Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement | Hi Jing, Thanks for

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-12 Thread Yunfeng Zhou
Hi Jing, Thanks for reviewing this FLIP. 1. I did change the names of some APIs in the FLIP compared with the original version according to which I implemented the POC. As the core optimization logic remains the same and the POC's performance can still reflect the current FLIP's expected improvem

Re: [DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-12 Thread Jing Ge
Hi Yunfeng, Thanks for the proposal. It makes sense to offer the optimization. I got some NIT questions. 1. I guess you changed your thoughts while coding the POC, I found pipeline.enable-operator-timestamp in the code but is pipeline.force-timestamp-support defined in the FLIP 2. about the benc

[DISCUSS] FLIP-330: Support specifying record timestamp requirement

2023-07-10 Thread Yunfeng Zhou
Hi all, Dong(cc'ed) and I are opening this thread to discuss our proposal to support optimizing StreamRecord's serialization performance. Currently, a StreamRecord would be converted into a 1-byte tag (+ 8-byte timestamp) + N-byte serialized value during the serialization process. In scenarios wh