Re: [DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-06-19 Thread lorenzo . affetti
Hello guys and thank you for your feedback! Very well appreciated. Sorry for the late reply, but it took a lot of time to address your concerns. I had to re-design the refactor and convince myself of the best way to accomodate both rewriting existing connectors (e.g. Postgres) and new ones. Hope y

Re: [DISCUSS] FLIP-444: Native file copy support

2024-05-17 Thread lorenzo . affetti
Perfectly agree with all your considerations. Wee said. Thank you! On May 16, 2024 at 10:53 +0200, Piotr Nowojski , wrote: > Hi Lorenzo, > > > • concerns about memory and CPU used out of Flink's control > > Please note that using AWS SDKv2 would have the same concerns. In both > cases Flink can co

Re: [RESULT][VOTE] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-16 Thread lorenzo . affetti
Well, I give my +1 (non-binding), but we need more binding votes :) Looking forward to see this approved and see the changes. On May 16, 2024 at 03:37 +0200, Rui Fan <1996fan...@gmail.com>, wrote: > Thanks Joao Boto for driving the FLIP. We need 3 +1(binding) > votes according to Flink Bylaws[1] b

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-16 Thread lorenzo . affetti
Also reviewed your PubSub PR, thanks you for the great job! On May 15, 2024 at 17:28 +0200, Muhammet Orazov , wrote: > Thanks Ahmed! > > I have reviewed your PubSub and RabbitMQ PRs, please have a look. > > Best, > Muhammet

Re: [DISCUSS] FLIP-444: Native file copy support

2024-05-16 Thread lorenzo . affetti
Hello Piotr and thanks for this proposal! The idea sounds smart and very well grounded thank you! Also here, as others, I have some doubts about invoking an external binary (namely s5cmd): • concerns about memory and CPU used out of Flink's control • deployment concerns from the usability perspe

Re: [VOTE] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread lorenzo . affetti
As said on the discussion thread, +1 (non-binding) Thank you! On May 14, 2024 at 23:03 +0200, Rodrigo Meneses , wrote: > +1 (non-binding) > Thanks a lot for driving this effort!! > -Rodrigo > > > On Tue, May 14, 2024 at 11:00 AM Péter Váry > wrote: > > > +1 (non-binding) > > Thanks, Peter > > > >

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread lorenzo . affetti
Thank you Martijn for the detailed FLIP. Will save this for the future as an example for these kind of FLIPs :) This also shakes the adoption of the new interface for downstream connectors. Volunteered for the pubsub port (table API), and trying to assess the current status of pending PRs. I giv

Re: [DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-05-15 Thread lorenzo . affetti
Hello Muhammet and Jeyhun! Thanks for your comments! @Jeyhun: > Could you please elaborate more on how the new approach will be backwards compatible? In the FLIP I provide how the current Factories in JDBC would be changed with this refactor, do you mean something different? Can you be more spe

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-13 Thread lorenzo . affetti
Thanks Ahmed! +1 non binding On May 13, 2024 at 12:40 +0200, Jeyhun Karimov , wrote: > Thanks for driving this Ahmed. > > +1 (non-binding) > > Regards, > Jeyhun > > On Mon, May 13, 2024 at 12:37 PM Muhammet Orazov > wrote: > > > Thanks Ahmed, +1 (non-binding) > > > > Best, > > Muhammet > > > > On

[DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-05-13 Thread lorenzo . affetti
Hello dev! I want to share a draft of my FLIP to refactor the JDBC connector to improve its extensibility [1]. The goal is to allow implementers to write new connectors on top of the JDBC one for Table API with clean and maintainable code. Any feedback from the community is more and welcome. [

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-07 Thread lorenzo . affetti
Thanks joao for your replies! I also saw the latest PR that allows properties to be specified. Thank for adding the pain points as well, that clarifies a lot. On May 7, 2024 at 09:50 +0200, Muhammet Orazov , wrote: > Thanks João for pointing it out. I didn't know about the PR, I am going > to ch

Re: [DISCUSS] FLIP-XXX Support currentFetchEventTimeLag and processingLag metrics

2024-04-30 Thread lorenzo . affetti
Thank you for your efforts! I think that Qingsheng reported my concerns about discrepancies between event time from the external system and current system time in the Flink cluster in a more concrete fashion. Thank you for the catch! The FLIP definitely makes sense and would love to see your fix

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-04-30 Thread lorenzo . affetti
Hello Ron, thank you for your detailed answers! For the Visitor pattern, I thought about it the other way around, so that operations visit the scheduler, and not vice-versa :) In this way operations can get the required information in order to be executed in a tailored way. Thank you for your e

Re: [DISCUSSION] FLIP-449: Reorganization of flink-connector-jdbc

2024-04-26 Thread lorenzo . affetti
Hello Joao, thank your for your proposal, modularity is always welcome :) > To maintain clarity and minimize conflicts, we're currently leaning towards > maintaining the existing structure, where flink-connector-jdbc-${version}.jar > remains shaded for simplicity, encompassing the core functiona

Re: [DISCUSS] FLIP-XXX Support currentFetchEventTimeLag and processingLag metrics

2024-04-26 Thread lorenzo . affetti
Sorry for some mal-informed questions, and thanks for adding context here and to the FLIP. About 1: > I think this has been discussed in the FLIP-33 lists thread[2]. I could not find the precise comment in the thread you are referring to unfortunately. Do you have some specific point in the dis

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-04-26 Thread lorenzo . affetti
Hello Ron! > I've updated the FLIP, and added the Outline Design section, to introduce how Materialized Table interacts with the Workflow Scheduler in Full Refresh mode via a timing diagram, it can help to understand this proposal design. Thank you for the additions, the sequence diagram says a l

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread lorenzo . affetti
Hello yuema! Thank you for the proposal. In light of what is happening to state backends with FLIP-423 and others, it definitely makes sense to leverage the full power of latest FRocksDB. Small nit and question for you: do you have any idea how to justify the regression in write perf? Thank you

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-04-24 Thread lorenzo . affetti
Hello Ron Liu! Thank you for your FLIP! Here are my considerations: 1. About the Operations interfaces, how can they be empty? Should not they provide at least a `run` or `execute` method (similar to the command pattern)? In this way, their implementation can wrap all the implementations details

Re: [DISCUSS] FLIP-XXX Support currentFetchEventTimeLag and processingLag metrics

2024-04-24 Thread lorenzo . affetti
Hello jialiang tan, and thank you for your contribution! Here are my questions: 1 - I don't know if exposing this as metric to the user could create some harm. There can be major discrepancies between the absolute time got by the TaskManagers (if clocks are not synchronized via ntp for example)

Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-12 Thread lorenzo . affetti
Huge congrats! Well done! On Apr 12, 2024 at 13:56 +0200, Ron liu , wrote: > Congratulations, Lincoln! > > Best, > Ron > > Junrui Lee 于2024年4月12日周五 18:54写道: > > > Congratulations, Lincoln! > > > > Best, > > Junrui > > > > Aleksandr Pilipenko 于2024年4月12日周五 18:29写道: > > > > > > Congratulations, Lin

Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-12 Thread lorenzo . affetti
Congratulations Lincoln! On Apr 12, 2024 at 12:08 +0200, yuxia , wrote: > Congratulations, Lincoln! > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Feng Jin" > 收件人: "dev" > 发送时间: 星期五, 2024年 4 月 12日 下午 5:23:40 > 主题: Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee > > Congratulation

Re: [ANNOUNCE] New Apache Flink PMC Member - Jing Ge

2024-04-12 Thread lorenzo . affetti
Congratulations Jing! All the hard work paid off :) On Apr 12, 2024 at 11:46 +0200, weijie guo , wrote: > Congratulations, Jing! > > Best regards, > > Weijie > > > Feng Jin 于2024年4月12日周五 17:24写道: > > > Congratulations, Jing > > > > Best, > > Feng Jin > > > > On Fri, Apr 12, 2024 at 4:46 PM Samrat

Testing with custom generated data

2024-04-11 Thread lorenzo . affetti
Hello DEV! I am currently working on issue [1]. The contribution consists in migrating the batch SQL test from a bash implementation to a Java one. After a couple of rounds of review we agreed to proceed by removing the existing deprecations due to how the source table is generated. The main su

Re: [FYI] The Azure CI for PRs is currently not triggered

2024-04-04 Thread lorenzo affetti
The CI is back to normal since this morning. Thanks to the collaboration with Robert and Mathias. For more information, see the issue link in Matthias message. On Thu, Apr 4, 2024, 08:23 Matthias Pohl wrote: > Hi everyone, > just for your information: The Azure CI for PRs is currently not wor

Re: [DISCUSS] FLIP-435: Introduce a New Dynamic Table for Simplifying Data Pipelines

2024-04-03 Thread lorenzo . affetti
Hello everybody! Thanks for the FLIP as it looks amazing (and I think the prove is this deep discussion it is provoking :)) I have a couple of comments to add to this: Even though I get the reason why you rejected MATERIALIZED VIEW, I still like it a lot, and I would like to provide pointers on

Re: Re: [ANNOUNCE] Apache Paimon is graduated to Top Level Project

2024-04-03 Thread lorenzo . affetti
Congratulations! Big milestone reached :) Best, Lorenzo On Apr 2, 2024 at 03:50 +0200, Ron liu , wrote: > Congratulations! > > Best, > Ron > > Jeyhun Karimov 于2024年4月1日周一 18:12写道: > > > Congratulations! > > > > Regards, > > Jeyhun > > > > On Mon, Apr 1, 2024 at 7:43 AM Guowei Ma wrote: > > > > >

Re: [DISCUSS] Externalized Google Cloud Connectors

2024-04-03 Thread lorenzo . affetti
@Leonard @Martijn Following up on @Claire question, what is the role of Bahir (https://bahir.apache.org/) in this scenario? I am also trying to understand how connectors fir in the Flink project scenario :) Thank you, Lorenzo On Apr 2, 2024 at 06:13 +0200, Leonard Xu , wrote: > Hey, Claire > >

Re: [DISCUSS] FLIP-425: Asynchronous Execution Model

2024-03-22 Thread lorenzo . affetti
Thank you Yanfei for addressing all the questions! > I'm not sure if I understand your question. In Java, this case(modifying the local local variable) is not allowed[1], but there are ways to get around the limitation of lambda. In this case, the modification to x may be concurrent, which needs t

Re: [DISCUSS] FLIP-425: Asynchronous Execution Model

2024-03-21 Thread lorenzo . affetti
Thank you everybody for the questions and answers (especially Yanfei Lei), it was very instructive to go over the discussion. I am gonna add some questions on top of what happened and add some thoughts as well below. 1) About locking VS reference counting: I would like to clear out which mechani

Re: [DISCUSS] FLIP-434: Support optimizations for pre-partitioned data sources

2024-03-21 Thread lorenzo . affetti
Hello Jeyhun, I really like the proposal and definitely makes sense to me. I have a couple of nits here and there: For the interface `SupportsPartitioning`, why returning `Optional`? If one decides to implement that, partitions must exist (at maximum, return and empty list). Returning `Optional`

Re: Default scale and precision SQL data types

2024-03-07 Thread lorenzo . affetti
Hello Sergei! The proposal makes a lot of sense, and Martijn is right as well. Are you willing to drive the FLIP effort? Do you need any assistance with that? On Mar 4, 2024 at 01:48 +0100, Martijn Visser , wrote: > Hi, > > I think it would first require a FLIP, given it touches on the core type >

Re: Temporal join on rolling aggregate

2024-03-05 Thread lorenzo . affetti
I do agree with Ron Liu. This would definitely need a FLIP as it would impact SQL and extend it with the equivalent of TimestampAssigners in the Java API. Is there any existing JIRA here, or is anybody willing to drive a FLIP? On Feb 26, 2024 at 02:36 +0100, Ron liu , wrote: > +1, > But I think t

Re: [connectors] Notice to connector authors

2024-03-04 Thread lorenzo . affetti
Thanks Etienne for the pointers! Very useful Best, Lorenzo On Mar 4, 2024 at 11:53 +0100, Etienne Chauchot , wrote: > Hi Lorenzo, > > There is a umbrella ticket [1] but it is intended to track the CI > feature implementation and is now closed. > > I think the best is that each connector maintainer

Re: [connectors] Notice to connector authors

2024-03-04 Thread lorenzo . affetti
Thank you Etienne for the information. Is there any Jira ticket about this? Also an umbrella one? Or connector maintainers will do on their own? Thank you! On Mar 4, 2024 at 10:23 +0100, Etienne Chauchot , wrote: > Hi connector authors, > > I'd like to bring a piece of information about the CI o

[jira] [Created] (FLINK-34562) Port Debezium Avro Confluent changes (FLINK-34509) to Chinese

2024-03-01 Thread Lorenzo Affetti (Jira)
Lorenzo Affetti created FLINK-34562: --- Summary: Port Debezium Avro Confluent changes (FLINK-34509) to Chinese Key: FLINK-34562 URL: https://issues.apache.org/jira/browse/FLINK-34562 Project: Flink

[jira] [Created] (FLINK-34509) Docs: Fix Debezium JSON/AVRO opts in examples

2024-02-23 Thread Lorenzo Affetti (Jira)
Lorenzo Affetti created FLINK-34509: --- Summary: Docs: Fix Debezium JSON/AVRO opts in examples Key: FLINK-34509 URL: https://issues.apache.org/jira/browse/FLINK-34509 Project: Flink Issue

Use Flink's actor system

2017-07-12 Thread Lorenzo Affetti
Hello everybody, I want to do some experiments with communication across operators. Even if arguable, I wondered if it is possible to directly use the clustered actor system used by Flink. If so, how can I get an instance of the actor system in an Operator? Thank you in advance Lorenzo Affetti

Use Flink's actor system

2017-07-12 Thread Lorenzo Affetti
Hello everybody, I want to do some experiments with communication across operators. Even if arguable, I wondered if it is possible to directly use the clustered actor system used by Flink. If so, how can I get an instance of the actor system in an Operator? Thank you in advance Lorenzo Affetti