resolve the issue
> after your pull request has been merged. Resolving and closing might seem
> similar but there is a subtle difference.
>
> Cheers,
> Max
>
> On Fri, Jun 5, 2015 at 5:24 PM, Lokesh Rajaram
> wrote:
>
> > Hello,
> >
> > Typically when
e is in you are very welcome to close it
> yourself.
>
> Best,
>
> Marton
>
> On Fri, Jun 5, 2015 at 5:24 PM, Lokesh Rajaram
> wrote:
>
> > Hello,
> >
> > Typically when a pull request is accepted for a JIRA issue, can I close
> the
> > JIR
Hello,
Typically when a pull request is accepted for a JIRA issue, can I close the
JIRA or should I wait for pull request reviewer to close the issue. it's
done differently in various teams/projects. Just would like to know how
it's done here in Flink project so that I can follow for future pull
r
Thanks Chiwan. fixed it.
On Thu, Jun 4, 2015 at 10:48 PM, Chiwan Park wrote:
> Hi. You should send your PR to apache/flink-web repository not your
> flink-web repository.
>
> Regards,
> Chiwan Park
>
> > On Jun 5, 2015, at 2:46 PM, Lokesh Rajaram
> wrote:
> >
Hello,
For JIRA FLINK-2155 updated the document and created a pull request with
flink-web project as https://github.com/lokeshrajaram/flink-web/pull/1
I followed how to contrinute to create this pull request. can someone
please help me verify if this pull request is the right way of updating
flin
Lokesh Rajaram created FLINK-2155:
-
Summary: Add an additional checkstyle validation for illegal
imports
Key: FLINK-2155
URL: https://issues.apache.org/jira/browse/FLINK-2155
Project: Flink
ke it. :)
>>
>> On Wed, Jun 3, 2015 at 5:00 PM, Lokesh Rajaram
>> wrote:
>>
>>> Hello Marton,
>>>
>>> Nice find. can I work on this JIRA?
>>>
>>> Thanks,
>>> Lokesh
>>>
>>> On Wed, Jun 3, 2015 at 7:4
feature. Give a descriptive
> summary of the problem and if necessary a further explanation in
> description section.
>
> Having said this, it's mostly common sense what to fill in. And you can
> change everything later on as well, so don't worry.
>
> Cheers,
> Till
&
Sure, will add this to the list.
On Wed, Jun 3, 2015 at 8:20 AM, Ufuk Celebi wrote:
> Can you please also mark everything in the
>
> org.apache.flink.shaded.*
>
> namespace as illegal?
>
> On 03 Jun 2015, at 17:08, Lokesh Rajaram wrote:
>
> > Awesome. Will cre
+1. I like this idea, not sure if my vote counts :)
On Wed, Jun 3, 2015 at 8:21 AM, Robert Metzger wrote:
> Hi,
>
> as part of making our codebase ready for the upcoming 0.9 release, I've
> started to go over the documentation of Flink.
>
> It seems that our current approach for documenting stuf
Hello All,
Are there any guidelines followed in Flink community while raising a JIRA
Issue?
First time creating a JIRA here, your pointers will be very helpful to me.
Thanks,
Lokesh
t;
> On Wed, Jun 3, 2015 at 6:39 AM, Lokesh Rajaram
> wrote:
>
> > Hello Ufuk, Robert,
> >
> > @Ufuk if you can create a ticket and assign it to me that would be very
> > helpful
> >
> > @Robert I can definitely update those two documents. Just now I was
&
at 4:40 PM, Robert Metzger
> wrote:
>
> > Hi Lokesh,
> >
> > can you try this fix?
> >
> >
> http://dbknickerbocker.blogspot.de/2013/04/simple-fix-to-missing-toolsjar-in-jdk.html
> >
> > On Wed, Jun 3, 2015 at 4:27 PM, Lokesh Rajaram >
> &g
Thanks Robert. It works with the recommended changes.
On Wed, Jun 3, 2015 at 7:40 AM, Robert Metzger wrote:
> Hi Lokesh,
>
> can you try this fix?
>
> http://dbknickerbocker.blogspot.de/2013/04/simple-fix-to-missing-toolsjar-in-jdk.html
>
> On Wed, Jun 3, 2015 at 4:
Hi,
When I ran mvn checkstyle:checkstyle with the latest master branch. I see
the following failure:
[ERROR] Failed to execute goal on project flink-hbase: Could not resolve
dependencies for project org.apache.flink:flink-hbase:jar:0.9-SNAPSHOT:
Could not find artifact jdk.tools:jdk.tools:jar:1.7
:
> https://github.com/apache/flink-web
>
> We enforce coding guidelines using the maven checkstyle plugin. Maybe there
> is a way of forbidding certain imports
>
> On Tue, Jun 2, 2015 at 9:18 PM, Lokesh Rajaram
> wrote:
>
> > Hello Robert,
> >
> > I worked on that
Hello Robert,
I worked on that issue, if it's ok I can take this task.
Btw, how is anything enforced in Flink? Do I have to update how to contribute
guide or any thing else need to be done?
Sent from my iPhone
> On Jun 2, 2015, at 12:11 PM, Robert Metzger wrote:
>
> We have now replaced all
The KafkaITCase is not always failing. If you're lucky, it will pass with
> the next run.
>
> On Thu, May 14, 2015 at 5:48 PM, Lokesh Rajaram
> wrote:
>
> > If I understand it correct, I have to wait for your pull request to be
> > merged, I can rebase and trigger b
the view of the failed run.
> >
> > Hope that helps.
> >
> > Cheers,
> > Aljoscha
> >
> > On Thu, May 14, 2015 at 5:35 PM, Lokesh Rajaram
> > wrote:
> > > Thanks Aljoscha, Robert. After adding guava dependency for
> flink-sparg
vironment.
Thanks,
Lokesh
On Thu, May 14, 2015 at 1:39 AM, Robert Metzger wrote:
> I think flink-spargel is missing the guava dependency.
>
> On Thu, May 14, 2015 at 8:18 AM, Aljoscha Krettek
> wrote:
>
> > @Robert, this seems like a problem with the Shading?
> >
> &
> is null (or something like this)").
>
> On Mon, May 11, 2015 at 12:27 AM, Lokesh Rajaram
> wrote:
> > 1. I think I can use require for replacing Validate.isTrue
> > 2. What about Validate.notNull? If require is used it would throw
> > IllegalArgumentException
understanding is correct. Also, let me know your
thoughts.
Thanks,
Lokesh
On Sun, May 10, 2015 at 1:04 AM, Aljoscha Krettek
wrote:
> I would propose using the methods as Chiwan suggested. If everyone
> agrees I can change the Jira issue.
>
> On Sun, May 10, 2015 at 6:47 AM, Lokesh Raja
fects many other codes, so we should discuss about
> changing Guava's method to Scala’s method.
>
> Regards.
> Chiwan Park (Sent with iPhone)
>
>
>
> > On May 10, 2015, at 11:49 AM, Lokesh Rajaram
> wrote:
> >
> > Hello All,
> >
> > I
Hello All,
I am new to Flink community and am very excited about the project and work
you all have been doing. Kudos!!
I was looking to pickup some starter task. Robert recommended to pick up
https://issues.apache.org/jira/browse/FLINK-1711. Thanks Robert for your
guidance.
Sorry for a dumb ques
24 matches
Mail list logo
