Sure, will add this to the list. On Wed, Jun 3, 2015 at 8:20 AM, Ufuk Celebi <u...@apache.org> wrote:
> Can you please also mark everything in the > > org.apache.flink.shaded.* > > namespace as illegal? > > On 03 Jun 2015, at 17:08, Lokesh Rajaram <rajaram.lok...@gmail.com> wrote: > > > Awesome. Will create a JIRA and assign it to me. > > > > Thanks, > > Lokesh > > > > On Wed, Jun 3, 2015 at 8:03 AM, Robert Metzger <rmetz...@apache.org> > wrote: > > > >> Hi, > >> > >> the illegalImport check is exactly what I had in mind. Would be great if > >> you could add such a check. > >> You can also create JIRA issues yourself. > >> > >> On Wed, Jun 3, 2015 at 6:39 AM, Lokesh Rajaram < > rajaram.lok...@gmail.com> > >> wrote: > >> > >>> Hello Ufuk, Robert, > >>> > >>> @Ufuk if you can create a ticket and assign it to me that would be very > >>> helpful > >>> > >>> @Robert I can definitely update those two documents. Just now I was > >>> checking and looks like we can control this using checkstyle > >>> http://checkstyle.sourceforge.net/config_imports.html#IllegalImport > >>> > >>> Let me know if this is similar to what you guys were looking for. > >>> > >>> Thanks, > >>> Lokesh > >>> > >>> On Tue, Jun 2, 2015 at 12:21 PM, Robert Metzger <rmetz...@apache.org> > >>> wrote: > >>> > >>>> Adding an entry here: http://flink.apache.org/coding-guidelines.html > >> is > >>>> certainly good, yes. > >>>> You can contribute to the website here: > >>>> https://github.com/apache/flink-web > >>>> > >>>> We enforce coding guidelines using the maven checkstyle plugin. Maybe > >>> there > >>>> is a way of forbidding certain imports > >>>> > >>>> On Tue, Jun 2, 2015 at 9:18 PM, Lokesh Rajaram < > >> rajaram.lok...@gmail.com > >>>> > >>>> wrote: > >>>> > >>>>> Hello Robert, > >>>>> > >>>>> I worked on that issue, if it's ok I can take this task. > >>>>> > >>>>> Btw, how is anything enforced in Flink? Do I have to update how to > >>>>> contribute guide or any thing else need to be done? > >>>>> > >>>>> Sent from my iPhone > >>>>> > >>>>>> On Jun 2, 2015, at 12:11 PM, Robert Metzger <rmetz...@apache.org> > >>>> wrote: > >>>>>> > >>>>>> We have now replaced all commons validate calls with guava > >>>> preconditions > >>>>>> but its not written down anywhere or enforced by anything. > >>>>>> > >>>>>> Who would like to take care of that? > >>>>>> > >>>>>> On Thu, Mar 26, 2015 at 11:03 AM, Robert Metzger < > >>> rmetz...@apache.org> > >>>>>> wrote: > >>>>>> > >>>>>>> I didn't know that there was already an issue for this. I closed > >>>>>>> FLINK-1787. > >>>>>>> The correct issue is this one: > >>>>>>> https://issues.apache.org/jira/browse/FLINK-1711 > >>>>>>> > >>>>> > >>>> > >>> > >> > >
