[jira] [Created] (FLINK-7224) Incorrect Javadoc description in all Kafka consumer versions

Tzu-Li (Gordon) Tai created FLINK-7224: -- Summary: Incorrect Javadoc description in all Kafka consumer versions Key: FLINK-7224 URL: https://issues.apache.org/jira/browse/FLINK-7224 Project: Flink

[jira] [Created] (FLINK-7223) Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector

Bowen Li created FLINK-7223: --- Summary: Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector Key: FLINK-7223 URL: https://issues.apache.org/jira/browse/FLINK-7223 Project: Flink

[jira] [Created] (FLINK-7222) Kafka010ITCase fails on windows

Fang Yong created FLINK-7222: Summary: Kafka010ITCase fails on windows Key: FLINK-7222 URL: https://issues.apache.org/jira/browse/FLINK-7222 Project: Flink Issue Type: Bug Components: K

Re: [DISCUSS] A more thorough Pull Request check list and template

On Tue, Jul 18, 2017 at 11:03 PM, Chesnay Schepler wrote: > I'm sorry but i can't follow your logic. I understand where you're coming from Chesnay, but I agree with Stephan that a link is easier to ignore than a text. I think Stephan gave good pointers to why he thinks that people don't read the

Re: Using native library in Flink

The solution mentioned by Timo works well with a standalone Flink cluster but might not work with a YARN or Mesos cluster. An alternative is to have your Java library contain the native library within itself, and to extract it to a temporary directory before calling `System.loadLibrary(...)`. Note

Re: [DISCUSS] A more thorough Pull Request check list and template

I'm sorry but i can't follow your logic. Put text into template => contributor will definitely read it Put link to text into template => contributor will completely ignore the link The advantage of the link is we don't duplicate the contribution guide in the docs and in the template. Furtherm

Re: [DISCUSS] A more thorough Pull Request check list and template

Concerning moving text to the contributors guide: I can only say it again: I believe the contribution guide is almost dead text. Very few people read it. Before the current template was introduced, new contributors rarely gave the pull request a name with Jira number. That is a good indicator abou

[jira] [Created] (FLINK-7221) JDBCOutputFormat swallows errors on last batch

Ken Geis created FLINK-7221: --- Summary: JDBCOutputFormat swallows errors on last batch Key: FLINK-7221 URL: https://issues.apache.org/jira/browse/FLINK-7221 Project: Flink Issue Type: Bug

回复：[DISCUSS] A more thorough Pull Request check list and template

From my side, I also like the new template which contains more useful information, and both the reviewer and contributor may get benefits from it. For my previous pull requests as a contributor, I always listed the purpose of change and change log, but rarely mentioned how to verify the change an

Re: [DISCUSS] A more thorough Pull Request check list and template

Thanks for leading this discussion, Stephan. I don’t disagree with anything that has been said but am slightly concerned that the improvements in documenting pull requests won’t translate into the git commit messages. Acceptance of a higher standard will be swift as long as reviewers set the ex

Re: [DISCUSS] A more thorough Pull Request check list and template

I like the new template but also agree with the text being too long and would move the intro to the contributors guide with a link in the PR template. Regarding the questions to fill out - I'd like the headings to be short and have the affected components last so that documentation is not lost (

[jira] [Created] (FLINK-7220) Update RocksDB dependency to 5.5.1

Stefan Richter created FLINK-7220: - Summary: Update RocksDB dependency to 5.5.1 Key: FLINK-7220 URL: https://issues.apache.org/jira/browse/FLINK-7220 Project: Flink Issue Type: Improvement

Re: Using native library in Flink

Hi Mike, do you run Flink locally or in a cluster? You have to make sure that VM argument -Djava.library.path is set for all Flink JVMs. Job Manager and Task Managers might run in separate JVMs. Make also sure that the library is accessible from all node. I don't know what happens if the file

Re: [DISCUSS] GitBox

It appears the mirroring is bi-directional. Here's the output i got while pushing /remote: Sending notification emails to: ['"comm...@flink.apache.org" '] remote: To git@github:apache/flink-shaded.git remote:fd3033b..301c6bb 301c6bbc5e87c44eac48d43e3b9ce44f3b54b3eb -> test_bra

Re: [DISCUSS] A more thorough Pull Request check list and template

My thinking was exactly as echoed by Gordon and Ufuk: - The yes/no sections are also for reviewers a reminder of what to watch out for. Let's face it, probably half of the committers are not aware that these things need to be checked implicitly against every change. A good part of the re

Re: Dropping Java 7 support

Hurray! Finally IntStreams, LongStreams, etc. in our stream processor ;-) Timo Am 18.07.17 um 16:31 schrieb Stephan Ewen: Hi all! Over the last days, there was a longer poll running concerning dropping the support for Java 7. The feedback from users was unanimous - in favor of dropping Java 7

Re: [DISCUSS] GitBox

FWIW, the Apache OpenNLP project recently moved to gitbox and even had a release following that - if anything it makes a committers' PR merge workflow lot easier when having to rebase, squash and merge PRs. See the section about 'Merging a PR via Github' here - http://opennlp.apache.org/using-git

Re: [DISCUSS] GitBox

Well then, let's just try it out :) I'll push a branch to the apache repo. On 18.07.2017 16:16, Greg Hogan wrote: My understanding was that the synchronization was bidirectional but clearly we’re working without documentation. http://karaf.922171.n3.nabble.com/PROPOSAL-Apache-Karaf-Slack

Dropping Java 7 support

Hi all! Over the last days, there was a longer poll running concerning dropping the support for Java 7. The feedback from users was unanimous - in favor of dropping Java 7 and going ahead with Java 8. So let's do that! Greetings, Stephan -- Forwarded message -- From: Stephan Ew

Re: [DISCUSS] GitBox

My understanding was that the synchronization was bidirectional but clearly we’re working without documentation. http://karaf.922171.n3.nabble.com/PROPOSAL-Apache-Karaf-Slack-amp-discuss-about-GitBox-td4050669.html

[jira] [Created] (FLINK-7219) Current allocate strategy cann‘t achieve the optimal effect with input's location

Sihua Zhou created FLINK-7219: - Summary: Current allocate strategy cann‘t achieve the optimal effect with input's location Key: FLINK-7219 URL: https://issues.apache.org/jira/browse/FLINK-7219 Project: Fl

[jira] [Created] (FLINK-7218) ExecutionVertex.getPreferredLocationsBasedOnInputs() will always return empty

Sihua Zhou created FLINK-7218: - Summary: ExecutionVertex.getPreferredLocationsBasedOnInputs() will always return empty Key: FLINK-7218 URL: https://issues.apache.org/jira/browse/FLINK-7218 Project: Flink

RE: Facebook BSD+patents license and Apache products

Looking at the end of https://issues.apache.org/jira/browse/LEGAL-303 it seems that the issue has been (partially) resolved by RocksDB re-licensing under Apache V2 and GPL (dual license) but would only take effect for consumers (e.g. Flink) after a RocksDB release... so hopefully there isn't to

Re: [DISCUSS] GitBox

According to the JIRA you linked, you can push the the apache repo, but it will be overridden by GitHub. (as it should since the GitHub repo is the original) The solution offered in the JIRA is to (force) push to the github repo instead of the apache one. Unless I'm misunderstanding this doesn

Re: [DISCUSS] GitBox

You are not able to push to the ASF repo? This link implies that both work (and identify an issue now addressed): https://issues.apache.org/jira/browse/INFRA-14039 From my .git/config: [remote "origin"] url = g...@github.com:apache/f

Re: [DISCUSS] GitBox

So committers would still need to link their accounts. Source for the mirror info: https://issues.apache.org/jira/browse/INFRA-13926 On 18.07.2017 13:50, Chesnay Schepler wrote: Alright, so there is an apache repo that can found at https://gitbox.apache.org/repos/asf?p=flink-shaded.git but i

Re: [DISCUSS] GitBox

Alright, so there is an apache repo that can found at https://gitbox.apache.org/repos/asf?p=flink-shaded.git but it is a mirror of the github repo. For flink, we push to apache and it is mirrored to github. For flink-shaded, we push to github and it is mirror to apache. On 18.07.2017 13:47, Che

Re: [DISCUSS] GitBox

I'm not aware of any asf hosted repository for gitbox projects; if you look at the flink-shaded repository you will not see any mention of it being a mirror, compared to the flink repo. The git-wip-us.apache.org repo for flink-shaded was removed when we switched. On 18.07.2017 13:27, Greg Hog

Re: [DISCUSS] GitBox

Linking is required to commit to the ASF hosted repo as well as the GitHub repo? My understanding was that linking and 2FA was only required to commit through GitHub, so no one would have diminished capabilities. I’d generally recommend only ever writing to a single repo to prevent concurrent co

Re: [DISCUSS] GitBox

We recently moved flink-shaded to GitBox; overall I'm quite happy with how it works. However, it is not possible for committers to push commits that haven't gone through the github/asf account linking process (https://gitbox.apache.org/setup/). I verified this today in an experiment with the

Re: [DISCUSS] A more thorough Pull Request check list and template

On Tue, Jul 18, 2017 at 10:47 AM, Fabian Hueske wrote: > For example even if the question about changed dependencies is answered > with "no", the reviewer still has to check that. But having it as a required option/text in the PR descriptions helps reviewers to actually remember to check that. I

Re: [DISCUSS] A more thorough Pull Request check list and template

I fully agree with Fabian. Multiple-choice questions provide little value to the reviewer, since the validity has to be verified in any case. While text answers have to be validated as well, they give some hint to the reviewer as to how it can be verified and which steps the contributor did to

Re: [DISCUSS] A more thorough Pull Request check list and template

I like the sections about purpose, change log, and verification of the changes. However, I think the proposed template is too much text. This is probably the reason why the first attempt to establish a PR template failed. I would move most of the introduction and explanations incl. examples to the

[jira] [Created] (FLINK-7217) Give hints about unsupported SQL / Table API features.

Fabian Hueske created FLINK-7217: Summary: Give hints about unsupported SQL / Table API features. Key: FLINK-7217 URL: https://issues.apache.org/jira/browse/FLINK-7217 Project: Flink Issue Ty

Re: [DISCUSS] A more thorough Pull Request check list and template

+1, I like this a lot. With the previous template, it doesn’t really resonate with what we should care about, and therefore most of the time I think contributors just delete that template and write down something on their own. I would also like to add: “Savepoint / checkpoint binary formats” to

Re: [DISCUSS] A more thorough Pull Request check list and template

I really like this and vote to change our current template. The simple yes/no/... options are a really good idea. I would add to your email that the questions will equally help reviewers to remember to look at these things, which is just as important. When we merge this, we should make sure to st