Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

2017-06-10 Thread Harbs
+1 Package http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs_release_branch/lastSuccessfulBuild/artifact/out/apache-flex-flexjs-0.8.0-src.tar.gz Java 1.8 OS: Mac OS X x86_64 10.10.5 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICE

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

2017-06-11 Thread Harbs
+1 Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/apache-flex-falconjx-0.8.0-src.tar.gz Java 1.8 OS: Mac OS X x86_64 10.10.5 Source kit signatures match: y Source kit builds: y README is ok: y README_JX is ok: y RELEASE_NOTES is ok: y RELEASE_NOTES_JX is ok: y NOTICE is ok: y

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-11 Thread Harbs
probably npm too). Harbs > On Jun 10, 2017, at 10:14 PM, piotrz wrote: > > Hi Carlos, > > Unfortunately Maven is not the main way of building of FlexJS. > > - Flex installer still serves Ant build of FlexJS for the user. > - Maven distribution package of FlexJS has some

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
= true;// or val = false; should not initialize val, but: var val:Boolean; // further down if(val == someotherval){ // do something } should initialize it. But I don’t see this as critical for now. Harbs > On Jun 11, 2017, at 10:56 AM, Justin Mclean wrote: > > Hi, > >> Th

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
nce: This takes about 700 ms for a million iterations on my machine. Setting it once instead of twice cuts off about 100ms. Harbs > On Jun 11, 2017, at 10:56 AM, Justin Mclean wrote: > >> Safe, but inefficient at times. > > So far I not seen any inefficiency in fact the opp

Re: [FlexJS] more on undefined / non initialised values

2017-06-11 Thread Harbs
" code. These changes are not PAYG, > until we get more of these optimizations in. I'm still interested in how > many of these cases there are. Some day I'll find out. But probably not > right away. > > -Alex > > On 6/11/17, 1:21 AM, "Harbs" wrote

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-13 Thread Harbs
All Flex project repos are prefixed with flex- > On Jun 13, 2017, at 9:59 AM, Christofer Dutz > wrote: > > By the way … why is this directory called “flex-typedefs” and not > “flexjs-typedefs”? > > Chris > > Am 13.06.17, 08:55 schrieb "Christofer Dutz" : > >Hi all, > >Please don’t

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

2017-06-14 Thread Harbs
/** * @param {string} type * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener * @param {boolean=} opt_useCapture */ SVGElementInstance.prototype.addEventListener = function(type, listener, opt_useCapture){}; /** * @param {string} type * @param {!EventListener

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

2017-06-14 Thread Harbs
Quite frankly, I don’t know how to read patch files, and I don’t know what it’s supposed to be doing. I’m going to leave this to someone who understands this better than I do to figure out… ;-) > On Jun 14, 2017, at 12:12 PM, Justin Mclean wrote: > > Hi, > >> I assume this is from the patch.

Re: [5/8] git commit: [flex-asjs] [refs/heads/tlf] - remove buttonDown from JS. It is supposedly unreliable on JS. Folks will have to track mouseDown and mouseUp

2017-06-18 Thread Harbs
I beg to differ. Yes. The HTML one is always false for mouse move events, but I do think the Flex MouseEvent should have a buttonDown property. (Actually, it should probably have a property for info on which button is pressed.) The state tracking should be passed along with the event. > On Jun

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-18 Thread Harbs
said; if you want to create the maven build, I will not stand in your way. Harbs > On Jun 18, 2017, at 1:27 PM, piotrz wrote: > > Hi Harbs, > > I noticed that TLF branch do not have proper Maven build on jenkins. I would > like to create one for you. In order to do this I nee

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-18 Thread Harbs
Does develop have all the changes in the release branch? Make sure you don’t revert any changes there… > On Jun 18, 2017, at 2:49 PM, piotrz wrote: > > Harbs, > > Creating this means that I will have to update your tlf branch with > 0.9.0-SNAPSHOT. ("develop&qu

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-18 Thread Harbs
Yes. it was merged not too long ago. Sounds good. > On Jun 18, 2017, at 3:04 PM, piotrz wrote: > > I did following things: > > Merge develop to tlf - conflicts only in poms - as expected. > Merge release branch to tlf - conflicts in poms. Changes are in UIBase > related to Justin's findings !=

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-18 Thread Harbs
> There is possibility that some dependencies are missing, but not sure what > Text module need in order to build. I add only Core and Binding. It needs Core, Basic and HTML. > On Jun 18, 2017, at 4:28 PM, piotrz wrote: > > Here you go your private tlf pipeline on Jenkins :) [1]. Compiler and t

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-18 Thread Harbs
Nice. I’ll try not to break this… ;-) > On Jun 18, 2017, at 10:33 PM, piotrz wrote: > > Wow :) After 4 shots it is finally blue [1] :) > > > [1] > https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/4/ > > Piotr > > > > > > - > Apache Flex PMC > piotrzarzyck

Re: git commit: [flex-asjs] [refs/heads/tlf] - Added callLater

2017-06-18 Thread Harbs
Right. (I copied most of the code from there.) But that can only be called from a strand. I wanted a stand alone function that can be called from anywhere. I needed to call a method that breaks out of recursion in a non-strand class. > On Jun 19, 2017, at 7:39 AM, Alex Harui wrote: > > FWIW, T

Re: [3/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== where needed

2017-06-21 Thread Harbs
This commit broke UIBase. I’m reverting a lot of these strict equalities. > On Jun 3, 2017, at 4:43 AM, jmcl...@apache.org wrote: > > use === and !== where needed > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/com

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-21 Thread Harbs
> Hi Harbs, > > What was wrong with that ? > > Thanks, Piotr > > 2017-06-21 17:42 GMT+02:00 : > >> Repository: flex-asjs >> Updated Branches: >> refs/heads/tlf c40993826 -> 3d2190621 >> >> >> Reverted strict equality >> >

Re: [3/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== where needed

2017-06-21 Thread Harbs
new UIBase() simply no longer worked… > On Jun 21, 2017, at 6:34 PM, piotrz wrote: > > Actually it would be good if you could point some UI scenario where it breaks > something if it is possible. > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-21 Thread Harbs
Yes. Go ahead. I think this missed the 0.8.0 release though. > On Jun 21, 2017, at 7:01 PM, piotrz wrote: > > Harbs, > > If it is breaking in a simple cases, can we propagate this changes to > develop ? I don't wanna chase issue in a real world application caus

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-21 Thread Harbs
use strict equality against null unless there is a very strong argument to do so in a specific case. Thanks, Harbs > On Jun 22, 2017, at 2:03 AM, Justin Mclean wrote: > > Hi, > >> It broke when element was undefined. > > So why not only change / revert that? >

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-21 Thread Harbs
come from using strict equality is probably worse and we should prefer regular equality. > On Jun 22, 2017, at 9:45 AM, Harbs wrote: > > I’m not going to invest a lot more time into this. > > You willy-nilly changed equality to strict equality. That cost me time and > mo

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
I just looked at the code and I see at least one possible bug. Assigning the source to undefined will fail. > On Jun 22, 2017, at 9:44 AM, piotrz wrote: > > Hi Harbs, > > That's a strong point to your changes. Compiler protect us. I'm wondering > there were also c

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
> On Jun 22, 2017, at 10:07 AM, Justin Mclean wrote: > I got performance gains of 30-40%. Of what? Percentages when dealing with such cheap operators are generally meaningless.

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
> On Jun 22, 2017, at 10:14 AM, Justin Mclean wrote: > > Hi, > >> The main argument for using strict equality is because it does type >> conversions which can cause bugs. > > Incorrect strict equality doesn’t do type conversion, but I assume you meant > to say "it doesn’t do type conversion”

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
Again; this means nothing to me. What is your app doing and how much CPU time was spent? > On Jun 22, 2017, at 10:33 AM, Justin Mclean wrote: > > Hi, > >>> I got performance gains of 30-40%. >> >> Of what? Percentages when dealing with such cheap operators are generally >> meaningless. > >

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
> On Jun 22, 2017, at 10:07 AM, Justin Mclean wrote: > > or do your own tests No need: https://jsperf.com/triple-equals-vs-twice-equals https://jsperf.com/triple-equals-vs-double-equals/3

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
Your link is actually arguing for use for non-strict equality… But again: Some places you need == and some places you need ===. Bugs can be introduced both ways. This is getting tiring, and I have work to do. > On Jun 22, 2017, at 10:38 AM, Justin Mclean wrote: > > HI, > > Point 1 may explai

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
And the only thing you changed was strict equality? I find that VERY hard to believe. I see you made lots of other changes. For example, I see you removed a try/catch in SimpleCSSValuesImpl. That seems like a much more likely culprit for performance improvement. > On Jun 22, 2017, at 10:43 AM,

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
+1. If we have a sample app, we can analyze where performance problems might be and make an educated decision based on that. I am making more reverts (and optimizations) in the TLF branch. If there proves to be a compelling reason to use strict equality I will be happy to audit my code. > On

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-22 Thread Harbs
The changes are quite extensive, but I’ll break it up into a lot of smaller commits. > On Jun 22, 2017, at 12:04 PM, piotrz wrote: > > Harbs, > > Make sure that those changes are simply, cause I will do cherry pick up. > > Piotr > > > > - > Apache

[FlexJS] getElementIndex()

2017-06-22 Thread Harbs
Is there a reason we are using the underlying node lists for our collection of elements? I would think that it would be more performant (at the possible cost of some extra memory) to keep a list of FlexJS elements. childNodes are live collections which need to constantly be resolved so they sh

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-24 Thread Harbs
Thanks. Assuming the numbers are really indicative, you’ve just shown it to be no significant increase in performance. It’s also quite possible that the browser is optimizing some of the checks away. There’s no way that a performance difference of less than a microsecond (one way or the other)

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-24 Thread Harbs
Not unless you can demonstrate there’s a good reason to do so. I have yet to see that. > On Jun 24, 2017, at 5:45 AM, Justin Mclean wrote: > > Are you OK for Objects and Strings to default to null as well?

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-24 Thread Harbs
, that is generally not an issue. Justin raised a valid argument to initialize Booleans and Numbers. It should not be taken any further than that. Harbs > On Jun 24, 2017, at 8:04 PM, Josh Tynjala wrote: > > I'm +1 on changing to null by default on objects and strings. I kn

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-24 Thread Harbs
ints to null will generally get the same result as initializing them to 0… > On Jun 24, 2017, at 10:35 PM, Harbs wrote: > > I have never seen real world ActionScript code which uses strict equality for > null. > > The argument to use strict equality “because of modern js advi

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread Harbs
ree/99864a8c >> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/99864a8c >> >> Branch: refs/heads/tlf >> Commit: 99864a8cd3605a5030adbec67083f7de7865462b >> Parents: 26b15e5 >> Author: Harbs >> Authored: Sun Jun 25 12:36:47 2017 +0300 >> Co

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread Harbs
I’m actually thinking of merging TLF back sometime over the next few weeks. I’m at the point where TLF is working pretty well… If there’s specific commits that someone wants before then, I’ll be happy to help with cherry picking. > On Jun 25, 2017, at 3:14 PM, piotrz wrote: > &

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
ects, I will not put up a fuss. Thanks, Harbs > On Jun 25, 2017, at 7:39 PM, Josh Tynjala wrote: > > I should make clear that even though I said "at the very least", which > might sounds like it's minor, I actually think this parity is more > important than any per

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
For kicks I just checked my minified code of my app for equality and inequality checks and there were 5466 instances. Just adding strict equality would add 3KB to my file size. (out of 1.8 MB, but still...) It would be an interesting exercise to see much much adding null initialization would ad

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
code size.) Harbs > On Jun 25, 2017, at 10:15 PM, Josh Tynjala wrote: > > I'd also be curious to see size comparisons using gzip too, which is pretty > standard in the JS world. > > - Josh > > On Jun 25, 2017 10:57 AM, "Harbs" wrote: > > For kicks

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
, the Javascript version is about 1/3 of the original size. That’s pretty amazing. Harbs > On Jun 25, 2017, at 10:15 PM, Josh Tynjala wrote: > > I'd also be curious to see size comparisons using gzip too, which is pretty > standard in the JS world. > > - Josh >

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
No I don’t. > On Jun 26, 2017, at 1:04 AM, Justin Mclean wrote: > > you keep forgetting that the closure compiles optimises the code

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
I’m not sure how you will do that unless you use every part of the SDK. My point was that I would like to try it on my own app which does have quite extensive SDK use (as well as many, many other classes). I will do that if and when we have these compiler options in Falcon. > On Jun 26, 2017, a

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-26 Thread Harbs
used) and was able to locate the error quickly. Our specific case was one where there was not getter defined at all for the value. > On Jun 25, 2017, at 8:30 PM, Harbs wrote: > > However, after thinking about this some more, I’m not sure that the SWF > behavior is actually desir

[FlexJS] Use of innerHTML

2017-06-27 Thread Harbs
]? Harbs [1]https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML#Security_considerations <https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML#Security_considerations> [2]https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/append <https://developer.mo

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-27 Thread Harbs
falcon changes that are required.) > On Jun 27, 2017, at 9:46 PM, piotrz wrote: > > Hi Harbs, > > I see that your TLF branch is failing on Maven build [1] with following > stack: > > Loading configuration: > F:\jenkins\jenkins-slave\wo

Re: [FlexJS,TLF] Tlf branch and Maven build

2017-06-28 Thread Harbs
Yes. You need that branch. > On Jun 28, 2017, at 9:34 AM, yishayw wrote: > > I'll try switching falcon to tlf branch. I was using release up to now. > > > > -- > View this message in context: > http://apache-flex-development.247.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
My suggestion was to copy it and prune the ones that are not used. > On Jun 29, 2017, at 9:49 AM, Justin Mclean wrote: > > Hi, > >> AllCSSValuesImpl - is not enough performant cause of lack of strict >> comparison ? > > Just the large number of styles.When Ha

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
And it was about AllCSSStyles and not AllCSSValuesImpl. I see no reason to not use that one. > On Jun 29, 2017, at 10:14 AM, Harbs wrote: > > My suggestion was to copy it and prune the ones that are not used. > >> On Jun 29, 2017, at 9:49 AM, Justin Mclean

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
fine. Harbs > On Jun 29, 2017, at 10:26 AM, Justin Mclean wrote: > > Hi, > > But you did agreed that the code in question should stay in CSSValuesImpl. > > From you last email in that thread: > > "I agree with Justin on this. I don’t see why numeric f

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
A font weight of 600 will fail in Flash. It’s CSS that only works in HTML. > On Jun 29, 2017, at 10:49 AM, Justin Mclean wrote: > > Hi, > >> Considering we have AllCSSValuesImpl, I think that should be the default for >> apps which are expecting HTML CSS. > > It’s not about HTTML CSS. > > Th

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
I’m not sure what your point is. That’s why you should use SimpleCSSValuesImpl is supposed to be a simple implementation which works the same in Flash and HTML. AllCSSValuesImpl is supposed to be an implementation which works with valid HTML CSS. Thanks, Harbs > On Jun 29, 2017, at 11:34

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

2017-06-29 Thread Harbs
was that Chrome was roughly twice as fast as Firefox and the Flash version took about 3 times as long in Chrome. I did not bother testing the Flash version in Firefox because I have the debug Flash plugin installed there. Harbs > On Jun 29, 2017, at 10:23 AM, Alex Harui wrote: > > Now

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
No. It’s there. Make sure you have commit af1f5c9 in your build of Core. > On Jun 29, 2017, at 12:21 PM, Justin Mclean wrote: > > Hi, > >> That’s why you should use > > You can’t in this case as it doesn’t compile with the following error: > > This tag could not be resolved to an ActionScri

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

2017-06-29 Thread Harbs
> On Jun 29, 2017, at 12:19 PM, Justin Mclean wrote: > > Hi, > >> The JS version of the test is here: >> http://home.apache.org/~aharui/FlexJS/FLEX35330/bin/js-release/ >> >> The SWF version of the test is here: >> http://home.a

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
Check your basic-manifest.xml for Core. Do you see

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

2017-06-29 Thread Harbs
be interested in hearing his findings. Thanks, Harbs > On Jun 29, 2017, at 1:07 PM, Justin Mclean wrote: > > HI, > >> There are tests for both, and you DON’T get type conversions unless it’s >> required. Browsers are smarter than that. > > See [1] and follow th

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Harbs
Yes. > On Jun 29, 2017, at 12:54 PM, Justin Mclean wrote: > > Did you actually try using that class / compiling it?

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-06-30 Thread Harbs
help. Good luck! Harbs > On Jun 30, 2017, at 3:19 PM, Allen YANG wrote: > > Hi Team, > I have a Flex 3 project that was built on Adobe Flash Builder 3.6 (SDK Flex > 3.6A); it needs to be ported to support a non-flash environment. This > program was not originally written

Re: [FalconJX] Slower builds after dual merge

2017-06-30 Thread Harbs
I initially thought that I was getting slower build times, but I’m no longer so sure. Using these options, I’m getting roughly 10 second build times --debug=true --targets=JSFlex That’s about the same as I was getting before the switch to dual. Using debug=false sometimes takes over 3 minutes.

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-06-30 Thread Harbs
They have build scripts for both Ant and Maven. You can probably build them using any one of the other build chains, but those are the only build scripts included. Harbs > On Jun 30, 2017, at 6:07 PM, Allen YANG wrote: > > Piotr, > Thank you. Are these examples all built on M

Re: [FlexJS] PAYG definitions and guidance, Please participate

2017-07-02 Thread Harbs
need better documentation and guides. Unfortunately most of us are not great writers. :-( Harbs > On Jul 2, 2017, at 1:40 AM, Greg Dove wrote: > > Thanks Alex, > > I look forward to your feedback. It would be great to see (from you or > anyone else) - within this

Re: [FlexJS] PAYG definitions and guidance, Please participate

2017-07-02 Thread Harbs
have layout beads which go in both directions relative to what we currently have: Leaner beads which are more performant, and more robust beads which have more ease of layout. Harbs > On Jul 2, 2017, at 9:44 AM, Alex Harui wrote: > > Documentation is always a good thing, but as

Re: [FlexJS] PAYG definitions and guidance, Please participate

2017-07-02 Thread Harbs
was being extreme with his use of PAYG and splitting up of beads. However, I went along with it, and with time, I see the wisdom of this approach. Thanks, Harbs > On Jul 2, 2017, at 4:44 PM, yishayw wrote: > > Alex Harui-2 wrote >> One thing I wanted put up >> for discuss

Re: [ANNOUNCE] Apache FlexJS 0.8.0 and Apache Flex FalconJX 0.8.0 Released

2017-07-03 Thread Harbs
It looks like something is messed up with the mirror. I’ve never spent the time to figure out how the installer works… :-( > On Jul 3, 2017, at 9:35 AM, piotrz wrote: > > I just tried it and also have problems [1] > > [1] https://paste.apache.org/wWPR > > Piotr > > > > - > Apache Flex

Re: [ANNOUNCE] Apache FlexJS 0.8.0 and Apache Flex FalconJX 0.8.0 Released

2017-07-03 Thread Harbs
Did Apache change something with preferred mirrors? > On Jul 3, 2017, at 10:08 AM, Harbs wrote: > > It looks like something is messed up with the mirror. > > I’ve never spent the time to figure out how the installer works… :-( > >> On Jul 3, 2017, at 9:35 AM, piot

Re: [ANNOUNCE] Apache FlexJS 0.8.0 and Apache Flex FalconJX 0.8.0 Released

2017-07-03 Thread Harbs
This is probably the issue: http://archive.apache.org/dist/flex/flexjs/0.5.0/binaries/"; file="apache-flex-flexjs-0.5.0-bin"/> http://archive.apache.org/dist/flex/flexjs/0.6.0/binaries/"; file="apache-flex-flexjs-0.6.0-bin"/> http://archive.apache.org/dist/flex/flexjs/0.6.0/binaries/"; file="apa

Re: [ANNOUNCE] Apache FlexJS 0.8.0 and Apache Flex FalconJX 0.8.0 Released

2017-07-03 Thread Harbs
Fixed. > On Jul 3, 2017, at 11:15 AM, piotrz wrote: > > Hi Harbs, > > Thanks! Awesome! > > Let me know and I will at least test it. Didn't have enough time todays > morning to look into that. > > Piotr > > > > - > Apache Flex PMC &g

Re: git commit: [flex-asjs] [refs/heads/tlf] - First implementation of FileProxy which takes on some of the functions of FileReference in Flash. More beads coming soon.

2017-07-03 Thread Harbs
Not sure. It relies on Network. Adding it to Storage would add a Network dependency to Storage. > On Jul 3, 2017, at 2:40 PM, piotrz wrote: > > Another thing which come up to my mind is - Maybe this FileProxy > implementation should be included in Storage module. > > Just thinking loudly. >

TLF Branch merged back

2017-07-03 Thread Harbs
those in when a feature is complete. Is that right? Harbs

Feature Branches (was Re: TLF Branch merged back)

2017-07-03 Thread Harbs
preference is to only bother with feature branches for changes that have a decent chance of breaking things. I don’t really care about naming convetions, but naming a branch with a JIRA id for cross-referencing JIRA fixes makes sense. Thanks, Harbs > On Jul 3, 2017, at 4:29 PM, piotrz wrote: > &

[Legal] Code from Stack Overflow

2017-07-03 Thread Harbs
March 2016, where should attribution be put? Should a link be included in the code? A mention of the author in NOTICE? Should we include a link back to the SO post? Should this be asked on legal? Harbs [1]https://stackoverflow.com/a/2401861 [2]https://meta.stackexchange.com/questions/272956/a-new

Re: Installer Problems

2017-07-03 Thread Harbs
I tried and this time it worked. Earlier today I got the same error that others reported. > On Jul 3, 2017, at 9:06 PM, piotrz wrote: > > Hi Alex, > > I just tried and got error [1] same as previous I think. > > [1] https://paste.apache.org/90UQ > > Thanks, > Piotr > > > > - > Apache

Re: Installer Problems

2017-07-03 Thread Harbs
However,. it looks like it still download it from Downloading Apache FlexJS from:http://www-us.apache.org/dist/flex/flexjs/0.8.0/binaries/ > On Jul 3, 2017, at 9:27 PM, Harbs wrote: > > I tried and this time it worked. > > Earlier today I got the same error that others reporte

Re: Installer Problems

2017-07-03 Thread Harbs
Yeah. That’s probably the issue with AIR 25 being too big… > On Jul 3, 2017, at 10:08 PM, piotrz wrote: > > Alex, Olaf, > > I just tried after some time installer and it's downloaded FlexJS and > compiler, but it failed in uncompressing Adobe Air 25 [1]. > > With configuration FlexJS 0.8.0 and

Re: TLF Branch merged back

2017-07-03 Thread Harbs
BTW: Sorry for forgetting to merge Falcon as well and thanks Alex for taking care of it. > On Jul 3, 2017, at 4:41 PM, Harbs wrote: > > I just merged the TLF branch back into develop. > > TLF is still “alpha quality”, so unless you do a LOT of custom work on a > propr

Re: Installer Problems

2017-07-04 Thread Harbs
https://www.npmjs.com/package/flexjs > On Jul 4, 2017, at 2:13 PM, piotrz wrote: > > Do we have some alternative to provide users where we can download by SDK > with all dependencies ? > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > V

[FlexJS] Use of typeof

2017-07-04 Thread Harbs
you to do that and complains that process is an undefined property. In the browser you can use window[“process”] == undefined and in node you can (theoretically) use global[“process”] == undefined. I can’t think of a generic way to do this though. Thoughts? Harbs

Re: Installer Problems

2017-07-04 Thread Harbs
Thanks for taking care of that. :-) > On Jul 4, 2017, at 8:10 PM, piotrz wrote: > > Issue has been fixed. Everyone who had the problems can try to download > FlexJS. > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: > http:/

Re: [FlexJS] Use of typeof

2017-07-04 Thread Harbs
n order to get trace() working in > Node.js, I had to figure out how to find the console object on window > versus global. I feel like I remember using typeof, but maybe it was > something else. Take a look at the implementation of Language.trace() to > see what I did. > > -

Re: [FlexJS] Use of typeof

2017-07-04 Thread Harbs
{!Process} * @const */ var process; However, it seems like a drag to have to add a typedef every time a developer needs to check for the existence of a global that we did not think of. > On Jul 4, 2017, at 9:13 PM, Harbs wrote: > > Thanks. Here’s what I see: > > if(typeof window

Re: [FlexJS] Use of typeof

2017-07-04 Thread Harbs
in case I’m missing something.) Harbs > On Jul 5, 2017, at 12:00 AM, Harbs wrote: > > Looks like it. > > I see this in missing.js: > > /** > * @export > * This gets mapped to org.apache.flex.utils.Language.trace() by the compiler > * @param {...} r

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-04 Thread Harbs
Where is that from? In build.properties I see this: # flex-sdk-description values release.name = Apache Flex (FlexJS) # this is the version that appears in the flex-sdk-description tag # and on the package name. This is the publicly known version of FlexJS release.version = 0.9.0 # fb.release.

Re: [FlexJS] Use of typeof

2017-07-05 Thread Harbs
think that would offer a solution everywhere. > On Jul 5, 2017, at 7:48 PM, Alex Harui wrote: > > Sure, I know it wouldn't work at runtime, but it sounded like Harbs > couldn't even get the compiler to accept window["process"] which it should. > > So, it

Re: [FlexJS] technical debt

2017-07-06 Thread Harbs
A large percentage of the complaints are inaccurate. The reason the technical debt increased is largely because of the new TLF code. Who made these rules and how do we change them? We can make it look much better by just changing some of the rules… Harbs > On Jul 6, 2017, at 2:24 AM, Jus

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-06 Thread Harbs
VS Code is reporting all kinds of issues that are not problems since the switch to dual. Maybe that’s related as well? > On Jul 6, 2017, at 9:06 PM, Josh Tynjala wrote: > > I don't see why -targets wouldn't work when it works elsewhere, but I just > tried -compiler.targets too, and that also fa

Re: [FlexJS] technical debt

2017-07-06 Thread Harbs
Yup. For example: I’d say an extremely large percentage of the “technical debt” in TLF is there for a reason. Do NOT “fix” any of that… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > But IMO, for right now, if "it ain't broke, don't fix it".

FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-06 Thread Harbs
Where are the instructions on how to use it? If I know how to write tests, I’d be much better about doing so… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > I have put in place a test infrastructure

[FlexJS][VS Code] dual issues

2017-07-06 Thread Harbs
are specific to SWF-only output: a. I’m not getting JS specific classes recognized. b. I’m getting lots of incompatible overrides (to Flash methods) c. I’m getting overriding function not marked for override errors on functions that are implemented in flash (i.e. public function get scaleX():Number) d. conflicts between variables and Flash getters. e. etc... Thanks, Harbs

Re: [FlexJS] technical debt

2017-07-07 Thread Harbs
Considering you did not answer the most significant part of my question. I’m asking it again. > On Jul 6, 2017, at 9:13 PM, Harbs wrote: > > and how do we change them?

Re: [FlexJS] technical debt

2017-07-07 Thread Harbs
I don’t see any options like that (logged in using my Apache account). Does someone need to add permissions? > On Jul 7, 2017, at 10:49 AM, Justin Mclean wrote: > > Hi, > >>> and how do we change them? > > In the sonar cube web interface (same url as before) under rules/quality > profile. It

Re: [FlexJS][VS Code] dual issues

2017-07-07 Thread Harbs
Sounds great! Looking forward! Harbs > On Jul 7, 2017, at 2:12 AM, Josh Tynjala wrote: > > Okay, I figured out how to make VSCode switch to JS APIs instead of SWF > APIs for completion and things. In the next version of the extension, when > the targets compiler option

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-07 Thread Harbs
liking Mustella and some > thoughts about how to make FlexUnit run on both platforms. > > My personal preference is that tests should be written in MXML and/or AS > and run on both platforms. Bonus points if existing tests can be run > unmodified or mostly unmodified. > > -Alex

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

2017-07-07 Thread Harbs
the JS run, but some manual > intervention is currently required. > > -Alex > > On 7/7/17, 3:16 AM, "Harbs" wrote: > >> The checkintests target currently fails. I’m guessing the build file was >> not updated for dual. >> >> Selenium has a JS API[1]

Re: [FlexJS] technical debt

2017-07-08 Thread Harbs
should be constant is not something that Flex ever enforced. I don’t really see the value for this rule, but I could go either way. There are some other rules which should be discussed, but we can do that on the wiki. Feel free to revert my changes, but the discussion should be about defaults for

Re: [FlexJS] Use of typeof

2017-07-09 Thread Harbs
eck for "window" and a few > other things. > > HTH, > -Alex > > On 7/5/17, 1:54 PM, "Harbs" wrote: > >> No. I was trying to use process to check whether it’s running in a Node >> runtime (such as Node or Electron). window does not have proce

Re: [FlexJS] technical debt

2017-07-09 Thread Harbs
rift. You can see the source code here.[2] As you can see on the SonarQube dashboard[3], there are a total of 21 projects using SonarQube. 5 of those are Flex projects. Of the remaining 16 projects, it’s very easy to see that none of them are using the Flex language. Thanks, Harbs [1]https://

Re: [FlexJS] technical debt

2017-07-09 Thread Harbs
Actually I did not miss that. The Flex code is an external project: https://code.google.com/archive/p/jsf-flex/ <https://code.google.com/archive/p/jsf-flex/> I’ll be happy to communicate. Thanks, Harbs > On Jul 9, 2017, at 1:39 PM, Justin Mclean wrote: > > Hi, > >

[FlexJS]DropDownList dataProvider

2017-07-09 Thread Harbs
). I leaning to classifying it as a bug because it seems like having a requirement that the bindable property should be initialized is overly stringent. Thoughts? Harbs

  1   2   3   4   5   6   7   8   9   10   >