I’m just catching up on email. I made two changes on Friday. I deactivated the following two rules for the Flex language. (Please note that I only deactivated them. I did not delete them.) I wanted to see how much that would effect the score: "===" and "!==" should be used instead of "==" and "!=“ and "public static" fields should be constant
There are others that would be interesting to see how they effect the score as well. It’s important to note that these changes were only to the “Flex” language. Considering that we’re the only project using this language at all, it does not effect anyone else. Additionally, as best as I can tell, the language was first defined in the end of December. Considering we “own” the language, it seems reasonable that we should define sane defaults in case any other project DOES use the language. "===" and "!==" should be used instead of "==" and "!=“ is simply incorrect for ActionScript. I flies in the face of accepted coding practices for the language, and should be removed completely. It causes thousands of complaints. "public static" fields should be constant is not something that Flex ever enforced. I don’t really see the value for this rule, but I could go either way. There are some other rules which should be discussed, but we can do that on the wiki. Feel free to revert my changes, but the discussion should be about defaults for the language, and not just about a custom rule set. Thanks, Harbs > On Jul 8, 2017, at 6:41 AM, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > >> Before you accuse anyone (even if you expressed doubt) do you have a way to >> determine who made the change to the Sonar Cube configuration? > > I can’t see anything in the interface no, but the changes are logged and > infra will be able to tell. If it wasn’t him I’ll appoligise. > > Thanks, > Justin
