Re: Commit of table work

2014-11-24 Thread piotrz
Harbs, If you think that preparing such shape it is a good idea please send here list of class which you have created and which you potentially want to test. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble

Re: Commit of table work

2014-11-24 Thread piotrz
Harbs, For sure TableTests won't work and They should be completle rewrite. I could prepare some shape for such tests and based on this shape show you where you can put your tests logic. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex

Re: Commit of table work

2014-11-24 Thread Harbs
I just poked through the tests a bit. The TableTests are definitely not going to work. They look like they were written for the old Table architecture. The class names do not even match. I should rewrite the tests to work on tables, but I have no idea how the tests are supposed to work. Is the

Re: Commit of table work

2014-11-24 Thread piotrz
Hi Harbs, That is great!! Before the merge with your branch I had everything set up in my IDE Intellij and was able to build project and debug, but now I can't figure out why it doesn't work. That's why I've added to our ant script ability to build project in debug mode. :) In build.properties y

Re: Commit of table work

2014-11-23 Thread Harbs
Hi Piotr, I fixed the bug that was causing the vast majority of the errors. Currently there’s no errors, but six failures in FloatTest: [flexunit] Suite: UnitTest.Tests.FloatTest [flexunit] Tests run: 56, Failures: 6, Errors: 0, Skipped: 1, Time elapsed: 22.253 sec [flexunit] [flexunit] Re

Re: Commit of table work

2014-11-20 Thread Harbs
FWIW, the stack trace for almost all the failures is very similar to the error I’m seeing in the other case with threaded text. There’s a good chance when I fix that, most of these errors will go away. I had very little time this week to work on that. I’m hoping to be able to tackle that first

Re: Commit of table work

2014-11-20 Thread Harbs
It’s running now. There was a commit to the tables branch that I did not notice. I pulled that commit and it’s working now. How do I step into the debugger to see what’s failing? On Nov 20, 2014, at 11:27 AM, Erik de Bruin wrote: > I have set FLEX_HOME as an environment variable for all insta

Re: Commit of table work

2014-11-20 Thread Erik de Bruin
I have set FLEX_HOME as an environment variable for all instances of Bash (the command line/terminal). So I'm not using the env.properties file ... All I did was make my branch 'tables' the HEAD, pull to make it up to date, and run 'ant all'. I'm running Java version 1.7.0_67, not the Mac 'built

Re: Commit of table work

2014-11-20 Thread piotrz
Thanks Erik. Tests launched for you it's good but now I am wondering what's is the diff between your environment and Harbs that on his Mac they didn't launch. As for this errors this is something what we are trying to resolve, that's why I wanted to Harbs launch the tests. Piotr - Apache

Re: Commit of table work

2014-11-20 Thread Erik de Bruin
The test run reports: [flexunit] Suite: UnitTest.Tests.FloatTest [flexunit] Tests run: 56, Failures: 1, Errors: 92, Skipped: 1, Time elapsed: 5.214 sec and then the build fails. EdB On Thu, Nov 20, 2014 at 9:56 AM, Erik de Bruin wrote: > Thanks. > > I get a 'good' run, but for the tests I g

Re: Commit of table work

2014-11-20 Thread Erik de Bruin
Thanks. I get a 'good' run, but for the tests I get (literally) 92 errors like this one: [flexunit] FlexUnit test [variable] in suite UnitTest.Tests.FloatTest had errors. Where [variable] is 92 instance or classNames like: "composeAcrossControllers" Is that expected? EdB On Thu, Nov 20, 20

Re: Commit of table work

2014-11-20 Thread piotrz
Hi Erik, This is the steps for launch tests: 1) In tlf folder - build.properties file set up minimalTests = true flexdebug = false - only if you want debuggable swf 2) Create env.properties file in tlf folder and add there FLEX_HOME path 3) Run the tests using ant "all" target Thank you.

Re: Commit of table work

2014-11-20 Thread Erik de Bruin
I can run the tests. What do I launch? EdB On Thu, Nov 20, 2014 at 9:24 AM, piotrz wrote: > Harbs, > > I will be having next free cycles on Monday. It would be great if anyone > who > use Mac OSX could try to launch Unit Tests in tlf from Harbs's tables > branch > earlier. I just wanted to co

Re: Commit of table work

2014-11-20 Thread piotrz
Harbs, I will be having next free cycles on Monday. It would be great if anyone who use Mac OSX could try to launch Unit Tests in tlf from Harbs's tables branch earlier. I just wanted to confirm whether this is something specific for his environment or not. Thanks, Piotr - Apache Flex PMC

Re: Commit of table work

2014-11-19 Thread piotrz
For some reason tests didn't launch. I have to analyze your ant output and compare with mine. I see that Flow.swf launched without a problem - This is module you can see at the bottom. Pete - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-de

Re: Commit of table work

2014-11-19 Thread Harbs
I don’t see any progress. Here’s what I see: https://www.evernote.com/shard/s143/sh/0264fd2e-1d63-4887-9a9f-a4c8a8103238/184e2fee807124f8f0b29694c69ff569 I feel like I’m groping in the dark. I have no idea what any of this is doing… On Nov 19, 2014, at 11:09 AM, piotrz wrote: > Did tests start

Re: Commit of table work

2014-11-19 Thread piotrz
Did tests start ? Or there is no progress ? bin\apps\automation_apps\bin\ - Do you have in this location html wrapper for VellumUnit.swf ? You could try to launch it in web browser to see whether tests are launching. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message i

Re: Commit of table work

2014-11-19 Thread Harbs
I changed the default app on my machine to open swf files to the Flash Player Debugger. I got further now, but I don’t think I got as far as you: flexunnit_tests: [flexunit] Validating task attributes ... [flexunit] Generating default values ... [flexunit] Using default working dir [/Users/h

Re: Commit of table work

2014-11-19 Thread Harbs
I assume the problem is here: [flexunit] Executing 'open' with arguments: [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf' [flexunit] [flexunit] The ' characters around the executable and arguments are [flexunit] not part of the command. I’

Re: Commit of table work

2014-11-19 Thread Harbs
I just added flexdebug = true It’s now opening VellumUnit in Flash CS5 and stalling in the same place. Suggestions? BTW, I recently started seeing this in the output when building tlf: Please use CMSClassUnloadingEnabled in place of CMSPermGenSweepingEnabled in the future I believe it started

Re: Commit of table work

2014-11-19 Thread Harbs
The Flash Player app? It doesn’t use the browser? On Nov 19, 2014, at 10:42 AM, piotrz wrote: > Harbs, > > Did Flash Player launch for you ? Probably unit tests couldn't launch flash > player. I don't have access to my dev environment now maybe should be setted > path to the FlashPlayer.exe som

Re: Commit of table work

2014-11-19 Thread piotrz
Harbs, Did Flash Player launch for you ? Probably unit tests couldn't launch flash player. I don't have access to my dev environment now maybe should be setted path to the FlashPlayer.exe somewhere... I will check later today and let you know. Piotr - Apache Flex PMC piotrzarzyck...@gmail

Re: Commit of table work

2014-11-19 Thread Harbs
Here’s the full output: http://pastebin.com/RLCg8XGb On Nov 19, 2014, at 10:25 AM, Harbs wrote: > After running ant all, these are the only files I see in that bin folder: > > automation_core.swc > automation_tests.swc > Flow.swf > swfobject.js > VellumUnit.html > VellumUnit.swf > > On Nov 19,

Re: Commit of table work

2014-11-19 Thread Harbs
After running ant all, these are the only files I see in that bin folder: automation_core.swc automation_tests.swc Flow.swf swfobject.js VellumUnit.html VellumUnit.swf On Nov 19, 2014, at 10:23 AM, Harbs wrote: > What’s this about? > > flexunnit_tests: > [flexunit] Validating task attributes

Re: Commit of table work

2014-11-19 Thread Harbs
What’s this about? flexunnit_tests: [flexunit] Validating task attributes ... [flexunit] Generating default values ... [flexunit] Using default working dir [/Users/harbs/Documents/ApacheFlex/flex-tlf] [flexunit] Using the following settings for the test run: [flexunit] FLEX_HOME: [/User

Re: Commit of table work

2014-11-19 Thread piotrz
Hi Harbs, > 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere > else? I mean flex-tlf build.properties > 2) I’m not sure what you mean about FLEX_HOME. Is there something special > I need to do there besides what I’d do to make the SDK build? You have to create file e

Re: Commit of table work

2014-11-18 Thread Harbs
It’s quite possible that I completely broke composition of floats. None of my test cases use floats. I tried to stay away from changing anything that could affect floats, but I might have not been successful… Some clarifications: 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or

Re: Commit of table work

2014-11-18 Thread piotrz
Harbs, I did quick look into the errors of failing tests. I don't know what could be the cause of this errors - you have to look into that on your own. :/ Class FloatTest - every test in this class is failing with the same error: http://paste.ofcode.org/VJTfQaGaDgxeGnyRXg8jKu Try to analize for

Re: Commit of table work

2014-11-17 Thread Harbs
I’ve tried to make as few changes to the APIs as possible. 99.9% of users will be able to switch transparently. I am currently using the tables branch in the beta version of my software. That’s how I’m turning up these bugs. When I’m ready to push out to production, it should be in pretty good

Re: Commit of table work

2014-11-17 Thread piotrz
Harbs, Once you will be ready to start working on tests for tables we can schedule another session on skype. I will guide you through code one of the existing test class. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.2

Re: Commit of table work

2014-11-17 Thread piotrz
Hi Erik, I did merge of my code (TLF unit tests - develope) into the Harbs's branch (tables). I have managed to successful launch most of the tests on Harbs's code however couple of them failed. I will try to find some time later this week and look into this. Piotr - Apache Flex PMC pio

Re: Commit of table work

2014-11-17 Thread Erik de Bruin
What is you 'gut feeling' about the backwards compatibility of the table branch? In your project, I assume you use a lot of TLF code. I think I remember you have a very large text based application ... Will you be using your branch for your release software? I'm asking so I can figure out if we wa

Re: Commit of table work

2014-11-17 Thread Harbs
Right now I’m working on a pretty serious bug in the table code related to recomposition of TextFlowLines. (See the other thread.) Once I have that behind me, I plan on trying to get some tests set up. Piotr already merged the test code in with the table code, so that part is done. On Nov 17, 2

Re: Commit of table work

2014-11-17 Thread Erik de Bruin
Hi guys, Can you update us on the status and "planning" (note the quotes, the project doesn't require any schedule) of your contributions? Thanks, EdB On Wed, Oct 29, 2014 at 12:13 PM, piotrz wrote: > Thanks Erik! :) > > Harbs I've sent you an invitation on skype. > > Piotr > > > > - >

Re: Commit of table work

2014-10-29 Thread piotrz
Thanks Erik! :) Harbs I've sent you an invitation on skype. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Commit-of-table-work-tp41095p41913.html Sent from the Apache Flex Development mailing list a

Re: Commit of table work

2014-10-29 Thread Erik de Bruin
Awesome, have fun! EdB On Wed, Oct 29, 2014 at 11:49 AM, Harbs wrote: > I’m in Israel. > > I’ll email you directly. > > On Oct 29, 2014, at 11:44 AM, piotrz wrote: > > > Hi Harbs, > > > > Where are you from ? > > We could schedule some meeting and try to do this together. > > > > Piotr > > >

Re: Commit of table work

2014-10-29 Thread Harbs
I’m in Israel. I’ll email you directly. On Oct 29, 2014, at 11:44 AM, piotrz wrote: > Hi Harbs, > > Where are you from ? > We could schedule some meeting and try to do this together. > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context

Re: Commit of table work

2014-10-29 Thread piotrz
Hi Harbs, Where are you from ? We could schedule some meeting and try to do this together. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Commit-of-table-work-tp41095p41908.html Sent from the Apache

Re: Commit of table work

2014-10-29 Thread Harbs
I’ve been fixing bugs as I find them in the tables branch. I’m still finding bugs. For me to be confident that merging it into develop is a good idea I’d need help putting together test suites… Any volunteers? On Oct 29, 2014, at 9:27 AM, Erik de Bruin wrote: > Hi, > > Any news on merging t

Re: Commit of table work

2014-10-29 Thread Erik de Bruin
Hi, Any news on merging the work on the tests in ‘develop’ with the ‘tables’ branch, such that we may start to consider including support for Tables in the next SDK release? EdB On Mon, Oct 6, 2014 at 9:56 AM, piotrz wrote: > Hi Harbs, > > Awesome work! > I will try to merge your branch with

Re: Commit of table work

2014-10-06 Thread piotrz
Hi Harbs, Awesome work! I will try to merge your branch with mine and launch current available tests on your code. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Commit-of-table-work-tp41095p41110

Re: Commit of table work

2014-10-05 Thread Harbs
Agreed. I just made the same suggestion. Harbs On Oct 6, 2014, at 9:08 AM, Erik de Bruin wrote: > Hi, > > 1) There are NO unit tests. I have not run any existing test nor have I >> created any new tests. I have zero experience with tests. I’ll be happy to >> do some work on this, but I will ne

Re: Commit of table work

2014-10-05 Thread Harbs
I’m not sure. I will personally be using the code in production by then. I’d love to have unit tests and the like working, but I’m not sure what’s involved in that. (I need help with unit tests.) I’ve “touched” an incredible amount of TLF code and this stuff is unbelievably fragile. Tiny little

Re: Commit of table work

2014-10-05 Thread Erik de Bruin
Hi, 1) There are NO unit tests. I have not run any existing test nor have I > created any new tests. I have zero experience with tests. I’ll be happy to > do some work on this, but I will need direction Isn’t Piotr working on this? I believe he just checked in his code into flex-tlf -> develop …

Re: Commit of table work

2014-10-05 Thread Erik de Bruin
Thank you Harbs! If we release 4.14 in a “few” weeks, do you think the tables work will be in such a shape that we can ship it? EdB On Mon, Oct 6, 2014 at 6:15 AM, Alex Harui wrote: > Awesome! > > On 10/5/14, 12:57 PM, "Harbs" wrote: > > >One more thing: > > > >I¹m pretty sure there were ch

Re: Commit of table work

2014-10-05 Thread Alex Harui
Awesome! On 10/5/14, 12:57 PM, "Harbs" wrote: >One more thing: > >I¹m pretty sure there were changes done to TLF in develop after I forked >the code, so this changes will need to be merged in. > >On Oct 5, 2014, at 10:53 PM, Harbs wrote: > >> I just committed my work on tables to the repository

Re: Commit of table work

2014-10-05 Thread Harbs
One more thing: I’m pretty sure there were changes done to TLF in develop after I forked the code, so this changes will need to be merged in. On Oct 5, 2014, at 10:53 PM, Harbs wrote: > I just committed my work on tables to the repository. I committed it to a new > branch called tables. There