Re: [FlexJS] About Material Icons

Tested and working good! Thanks Piotr! :))) 2017-01-23 22:01 GMT+01:00 piotrz : > Thank you Alex for explanation. > > Carlos it is fixed - you can test it. :) > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: http://apache-flex- > developme

Re: [FlexJS] About Material Icons

Thank you Alex for explanation. Carlos it is fixed - you can test it. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-About-Material-Icons-tp58562p58601.html Sent from the Apache Flex Develop

Re: [FlexJS] About Material Icons

On 1/23/17, 12:08 PM, "piotrz" wrote: >Carlos, Alex, > >Fix is ready, but before I will commit it I have to ask about something. > >In order to fix this I need to remove from ContainerDataBinding following >code: > >if (binding.source[0] in _strand) >{ >} > >What actually is for this "in" attri

Re: [FlexJS] About Material Icons

Carlos, As for my first commit related to this issue, where I removed MaterialIconType from mdl-manifest.xml and push it to MDLClasses. - Compiler haven't seen class with static variables in ActionScript cause it wasn't added there. Once I did it _bindings array was generated correctly + One fix i

Re: [FlexJS] About Material Icons

Carlos, Alex, Fix is ready, but before I will commit it I have to ask about something. In order to fix this I need to remove from ContainerDataBinding following code: if (binding.source[0] in _strand) { } What actually is for this "in" attribute ? Why we are checking something like that in str

Re: [FlexJS] About Material Icons

Thanks Carlos. I've updated a bit description and title. I will look into that later today. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-About-Material-Icons-tp58562p58595.html Sent from the

Re: [FlexJS] About Material Icons

Hi Piotr, I tried with ContainerDataBiding and doesn't work already. here's the link to the issue created in JIRA: FLEX-35249 - Data binding fails in Container with constants 2017-01-23 16:11 GMT+01:00 piotrz : > Hi Carlos, > > I think you are d

Re: [FlexJS] About Material Icons

On 1/22/17, 10:58 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >On Sun, Jan 22, 2017 at 9:19 PM, Alex Harui wrote: > >> That reminds me: it has always bugged me that the compiler makes you >> write: >> >> >> >> >> (which sets up a binding), instead of just: >> >> >>

Re: [FlexJS] About Material Icons

Hi Carlos, I think you are doing it right, maybe something is wrong in case of MDL + DataBinding beads. Please try also ContainerBinding instead ViewDataBinding and let me know. If it won't work file a bug and I will take a look into that probably today. :) Thanks, Piotr - Apache Flex PMC

Re: [FlexJS] About Material Icons

Hi, I'm trying to make data binding but Can't get it work I have the following code. Someone could let me know whats needed to make all icons get the binding of the constant type? http://ns.adobe.com/mxml/2009"; xmlns:js="library://ns.apache.org/flexjs/basic" xm

Re: [FlexJS] About Material Icons

If we choose the constant method I think It's better remove the few specific classes. Right? Don't worry, I'll include it in my current task of giving final touches to MDL lib 2017-01-23 11:08 GMT+01:00 piotrz : > Hi Carlos, > > I'm fine with that. Are you going to remove current mechanism ? > >

Re: [FlexJS] About Material Icons

Hi Carlos, I'm fine with that. Are you going to remove current mechanism ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-About-Material-Icons-tp58562p58585.html Sent from the Apache Flex Deve

Re: [FlexJS] About Material Icons

Hi Om, thanks for pointing this. I was just thinking on this way few hours ago and want to propose it here. Maybe is more verbose but we save us to write 900 classes and 900 constants...only we do the second. @Pitor, what do you think? About Alex proposal, I should think about it if there's some

Re: [FlexJS] About Material Icons

To me it makes it clear what’s a string literal and what’s not. Of course, there’s no reason for binding overhead in this case. When something is a constant, there’s no reason why the compiler couldn’t just automatically replace it with the value. Is there? > On Jan 23, 2017, at 7:19 AM, Alex H

Re: [FlexJS] About Material Icons

On Sun, Jan 22, 2017 at 9:19 PM, Alex Harui wrote: > That reminds me: it has always bugged me that the compiler makes you > write: > > > > > (which sets up a binding), instead of just: > > > > Can anyone think of a reason the compiler shouldn't allow that? > What is the advantage of wri

Re: [FlexJS] About Material Icons

That reminds me: it has always bugged me that the compiler makes you write: (which sets up a binding), instead of just: Can anyone think of a reason the compiler shouldn't allow that? Also, maybe more into the future, maybe the constants should be considered of type FontAwsomeIconTyp

Re: [FlexJS] About Material Icons

On Sun, Jan 22, 2017 at 10:17 AM, Carlos Rovira wrote: > Hi, > > while doing thing to close MDL implementation I saw that Material Design > Icons library is about 900 icons (60Mb). You can see all here: > > https://material.io/icons/ > > We was pushing a class for every icon (i.e: MaterialIconAdd

Re: [FlexJS] About Material Icons

Hi Piotr, right, I think we should continue pushing icons. I think we should go through the list in order: https://material.io/icons/ btw, just make an upload where: * fixed size of icons (18, 24, 36 or 48px). We need to introduce some CSS. Don't know why this is not part of MDL css... (I rememb

Re: [FlexJS] About Material Icons

I won't oppose to have second option, but for sure we shouldn't abandon current implementation. If I will be writing some code in MDL current implementation will be my first choose. I just think that sometimes batter do not give to much options. Piotr - Apache Flex PMC piotrzarzyck...@

Re: [FlexJS] About Material Icons

Hi Piotr, I think we could do both. My point is to give access to all icons from now and we could implement the rest of classes or make people interested make pull request. This is one of the thing community could help to make us to move to other things. 2017-01-22 19:21 GMT+01:00 piotrz : > H

Re: [FlexJS] About Material Icons

Hi Carlos, I was thinking about like that some time, but in the end I decided to have strong typed mechanism rather than generic. W don't have in our MDL all icons - Let user implement for himself whatever he want's to have. For me have specific class which makes one thing is a way better than