Re: [Falcon] operand stack underflow?

j%2BQLhaog >> 6J7PtqxlFPFzv7AhOSN6OMMkyOQS5poGs%3D&reserved=0 >> >> From: Yishay Weiss<mailto:yishayj...@hotmail.com> >> Sent: Monday, July 17, 2017 4:24 PM >> To: dev@flex.apache.org<mailto:dev@flex.apache.org> >> Subject: RE: [Falcon] operand st

Re: [Falcon] operand stack underflow?

data=02%7C01%7C%7Cf1bb25daf78840b0f68e08d4cd191b07%7Cfa7b1b >5a7b34438794aed2c178decee1%7C0%7C0%7C636358955087940048&sdata=SMj%2BQLhaog >6J7PtqxlFPFzv7AhOSN6OMMkyOQS5poGs%3D&reserved=0 > >From: Yishay Weiss<mailto:yishayj...@hotmail.com> >Sent: Monday, July 17, 2017 4:24 PM >To: dev

RE: [Falcon] operand stack underflow?

[1] https://paste.apache.org/STWV From: Yishay Weiss<mailto:yishayj...@hotmail.com> Sent: Monday, July 17, 2017 4:24 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: RE: [Falcon] operand stack underflow? I’m actually able to build after running the following batch file: cd \dev\flexj

RE: [Falcon] operand stack underflow?

I’m actually able to build after running the following batch file: cd \dev\flexjs\flex-falcon git pull call ant wipe-all cd \dev\flexjs\flex-typedefs call ant wipe git pull cd \dev\flexjs\flex-asjs call ant super-clean git pull ant clean all I am however getting a runtime error because of the fo

Re: [Falcon] operand stack underflow?

The previous error was what I got when using asconfigc in VS Code. Here’s the stack trace when building using Ant: https://paste.apache.org/Sy93 > On Jul 17, 2017, at 3:09 PM, Harbs wrote: > > I just updated flex-falcon and flex-asjs. After rebuilding everything,

Re: Falcon build failing

(aside) Your client knows there are top level domains with more than 4 characters ? And that neither local parts or domain names are limited to ASCII any more ? Tom On 20/04/17 17:50, Harbs wrote: private static const emailRegExp:RegExp = /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i;

Re: Falcon build failing

THANK YOU!!! That did it. Phew! I’m going to push my change to NativeUtils as well. > On Apr 20, 2017, at 11:16 PM, Alex Harui wrote: > > > > On 4/20/17, 7:44 PM, "Harbs" wrote: > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apa >> che.org%2FElpk&data=02%7C01%7

Re: Falcon build failing

On 4/20/17, 7:44 PM, "Harbs" wrote: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apa >che.org%2FElpk&data=02%7C01%7C%7C163cde5e1733430a17ff08d488605310%7Cfa7b1b >5a7b34438794aed2c178decee1%7C0%7C0%7C636283394673664681&sdata=yjTVit%2FtW8 >5rsXtx%2FRJZODRK15PM1GrpZNUf5C

Re: Falcon build failing

gt;> >>>>>> I have not been able to figure out how to reproduce the problem yet >>>>>> in >>>>>> test case. >>>>>> >>>>>>> On Apr 20, 2017, at 9:38 AM, Alex Harui wrote: >>>>>>> &

Re: Falcon build failing

t; >>>>>> Should I be able to reproduce by building the branch? >>>>>> >>>>>> Get Outlook for >>>>>> >>>>>> >>>>>>Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2 >

Re: Falcon build failing

the branch? >>>>> >>>>> Get Outlook for >>>>> >>>>> Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F% >>>>> 2F >>>>> >>>>> aka.ms%2Fghei36&data=02%7C01%7C%7C6196b71086814d9bf10d08d487f819ea%7Cfa >>>

Re: Falcon build failing

t;> >>>>aka.ms%2Fghei36&data=02%7C01%7C%7C6196b71086814d9bf10d08d487f819ea%7Cfa >>>>7b >>>> >>>>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636282947035930968&sdata=ykrDo05 >>>>QM >>>> %2FE3G4aj45PuuOpSeOtdE4VwRQj2%2BeLX

Re: Falcon build failing

rotection.outlook.com/?url=https%3A%2F%2F >>> aka.ms%2Fghei36&data=02%7C01%7C%7C6196b71086814d9bf10d08d487f819ea%7Cfa7b >>> 1b5a7b34438794aed2c178decee1%7C0%7C0%7C636282947035930968&sdata=ykrDo05QM >>> %2FE3G4aj45PuuOpSeOtdE4VwRQj2%2BeLX7Uk%3D&reserved=0> >&g

Re: Falcon build failing

gt;>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636282947035930968&sdata=ykrDo05QM >>%2FE3G4aj45PuuOpSeOtdE4VwRQj2%2BeLX7Uk%3D&reserved=0> >> >> >> ________ >> From: Harbs >> Sent: Thursday, April 20, 2017 6:21:56 AM >> To: dev@flex.apach

Re: Falcon build failing

ui wrote: >> >> Should I be able to reproduce by building the branch? >> >> Get Outlook for Android<https://aka.ms/ghei36> >> >> >> >> From: Harbs >> Sent: Thursday, April 20, 2017 6:21:56 AM >

Re: Falcon build failing

ps://aka.ms/ghei36> > > > > From: Harbs > Sent: Thursday, April 20, 2017 6:21:56 AM > To: dev@flex.apache.org > Subject: Re: Falcon build failing > > Right. But I need the TLF build to work… ;-) > > FWIW, I’m having trouble coming up with a test

Re: Falcon build failing

Should I be able to reproduce by building the branch? Get Outlook for Android<https://aka.ms/ghei36> From: Harbs Sent: Thursday, April 20, 2017 6:21:56 AM To: dev@flex.apache.org Subject: Re: Falcon build failing Right. But I need the TLF build t

Re: Falcon build failing

Right. But I need the TLF build to work… ;-) FWIW, I’m having trouble coming up with a test case which shows the problem. > On Apr 20, 2017, at 8:53 AM, Christofer Dutz > wrote: > > Even if there is currently an issue not making all parts of the build chain > run automatically … the Maven bu

Re: Falcon build failing

Even if there is currently an issue not making all parts of the build chain run automatically … the Maven build is currently fully operational (as far as I can tell) Chris Am 20.04.17, 12:30 schrieb "Harbs" : This issue has me stalled. If anyone could help with this, it would be greatly

Re: Falcon build failing

This issue has me stalled. If anyone could help with this, it would be greatly appreciated. > On Apr 19, 2017, at 6:27 PM, Harbs wrote: > > FWIW, I tried adding RegExp("RegExp”), to NativeUtils.NativeJSType, but for > some reason it did not help. > >> On Apr 19, 2017, at 5:05 PM, Harbs wrote

Re: Falcon build failing

FWIW, I tried adding RegExp("RegExp”), to NativeUtils.NativeJSType, but for some reason it did not help. > On Apr 19, 2017, at 5:05 PM, Harbs wrote: > > I just got this one: > No GoogDep for RegExp > >> On Mar 29, 2017, at 12:52 AM, Alex Harui wrote: >> >> Yep, but I just added it about 10 m

Re: Falcon build failing

I just got this one: No GoogDep for RegExp > On Mar 29, 2017, at 12:52 AM, Alex Harui wrote: > > Yep, but I just added it about 10 minutes ago. > > -Alex > > On 3/28/17, 9:50 PM, "Harbs" wrote: > >> I’m getting this with a different project: >> No GoogDep for NaN >> >> I guess NaN needs to

Re: Falcon build failing

Well, I just pushed more changes so FlexJSStore compiles and loads without errors, but it doesn't look right yet. I'll be digging into that shortly. Thanks, -Alex On 3/30/17, 12:18 PM, "Alex Harui" wrote: >I pushed some changes that might fix that. Let me know. FlexJSStore >still isn't runni

Re: Falcon build failing

Alex, Your last commit had to break something. On jenkins and locally I'm getting following error [1] [1] https://paste.apache.org/MoHw Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Falcon-build-fai

Re: Falcon build failing

Now something else seems to be broken. The test_project I linked to earlier now gets no js files from the SDK other than Application.js and ApplicationBase.js. The compiler errs on Could not find file for class: org.apache.flex.core.UIHTMLElementWrapper Sorry… ;-) Harbs > On Mar 30, 2017, at

Re: Falcon build failing

I pushed some changes that might fix that. Let me know. FlexJSStore still isn't running with -remove-circulars so I'm using that as my test case. -Alex On 3/29/17, 2:06 PM, "Harbs" wrote: >I pulled in your latest changes. The NaN error is fixed, but I’m still >having the problem with the miss

Re: Falcon build failing

I pulled in your latest changes. The NaN error is fixed, but I’m still having the problem with the missing Application dependency. Here’s a really simple project which has the problem for me including my configuration and the erroneous output. https://www.dropbox.com/s/eig8348o4kevpcq/test_proje

Re: Falcon build failing

In index.html, I replaced this: goog.addDependency('../../../test_project.js', ['test_project'], ['org.apache.flex.core.IBeadModel', 'org.apache.flex.events.ValueChangeEvent', 'org.apache.flex.core.IFlexJSElement', 'org.apache.flex.html.beads.layouts.BasicLayout', 'org.apache.flex.utils.MXMLDat

Re: Falcon build failing

What did you add that fixed it? -Alex On 3/29/17, 1:47 PM, "Harbs" wrote: >Yes. Once I added the dependency manually, the app works as expected. > >I am now in NY and I can test your latest changes. I will do so and >report whether I’m still getting the error. > >Harbs > >> On Mar 29, 2017, at

Re: Falcon build failing

Yes. Once I added the dependency manually, the app works as expected. I am now in NY and I can test your latest changes. I will do so and report whether I’m still getting the error. Harbs > On Mar 29, 2017, at 2:09 AM, Alex Harui wrote: > > > > On 3/28/17, 11:01 PM, "Harbs" wrote: > >> I’

Re: Falcon build failing

I'll give a shot later today! Maybe it's gone. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Falcon-build-failing-tp60790p60886.html Sent from the Apache Flex Development mailing list archive at Nabbl

Re: Falcon build failing

I cloned flex-tourjs, checked out develop branch. Ran "mvn clean install". Build was successful. Did you verify that you are no longer getting errors in your frameworks Maven build and that the SWCs are built correctly? -Alex On 3/28/17, 11:08 PM, "piotrz" wrote: >Alex, > >Try to build by M

Re: Falcon build failing

Alex, Try to build by Maven TourJS - you should reproduce it. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Falcon-build-failing-tp60790p60883.html Sent from the Apache Flex Development mailing list

Re: Falcon build failing

On 3/28/17, 11:01 PM, "Harbs" wrote: >I’ll let you know if I do. > >Have you been able to reproduce the problem with the missing >org.apache.flex.core.Application dependency? No. I haven't hit that one. Earlier I listed things to check: Is the right SWC there? Does the SWC have the right c

Re: Falcon build failing

I’ll let you know if I do. Have you been able to reproduce the problem with the missing org.apache.flex.core.Application dependency? > On Mar 29, 2017, at 8:48 AM, Alex Harui wrote: > > > > On 3/28/17, 10:40 PM, "Harbs" wrote: > >> Can I assume that any types in external swcs will not have

Re: Falcon build failing

On 3/28/17, 10:40 PM, "Harbs" wrote: >Can I assume that any types in external swcs will not have this issue? Don't know. I don't think I've had to add anything like that so far. If you are running into that, then I need to adjust the logic. -Alex > >> On Mar 29, 2017, at 8:11 AM, Alex Haru

Re: Falcon build failing

Can I assume that any types in external swcs will not have this issue? > On Mar 29, 2017, at 8:11 AM, Alex Harui wrote: > > > > On 3/28/17, 9:58 PM, "Harbs" wrote: > >> OK. Why is this happening now? > > In order to handle the reordering of dependencies, I needed to collect > types used in

Re: Falcon build failing

On 3/28/17, 9:58 PM, "Harbs" wrote: >OK. Why is this happening now? In order to handle the reordering of dependencies, I needed to collect types used in static initializers. The code is throwing a big net over all sorts of identifiers. I suppose I need to make it smarter, not sure. But it c

Re: Falcon build failing

OK. Why is this happening now? > On Mar 29, 2017, at 7:52 AM, Alex Harui wrote: > > Yep, but I just added it about 10 minutes ago. > > -Alex > > On 3/28/17, 9:50 PM, "Harbs" wrote: > >> I’m getting this with a different project: >> No GoogDep for NaN >> >> I guess NaN needs to be added too?

Re: Falcon build failing

Yep, but I just added it about 10 minutes ago. -Alex On 3/28/17, 9:50 PM, "Harbs" wrote: >I’m getting this with a different project: >No GoogDep for NaN > >I guess NaN needs to be added too? > >> On Mar 28, 2017, at 8:49 PM, Harbs wrote: >> >> Progress! >> >> It looks like the only problem I

Re: Falcon build failing

I’m getting this with a different project: No GoogDep for NaN I guess NaN needs to be added too? > On Mar 28, 2017, at 8:49 PM, Harbs wrote: > > Progress! > > It looks like the only problem I now have is the missing dependency on > org.apache.flex.core.Application > >> On Mar 28, 2017, at 8:

Re: Falcon build failing

Hi, I think I have same problem but with TourJS and Maven build. [1] :) [1] https://paste.apache.org/JWPJ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Falcon-build-failing-tp60790p60861.html Sent f

Re: Falcon build failing

Progress! It looks like the only problem I now have is the missing dependency on org.apache.flex.core.Application > On Mar 28, 2017, at 8:00 PM, Alex Harui wrote: > > OK. I think I've fixed the getListOfFiles problem. > > The Maven examples build seems to be turning on remove-circulars where

Re: Falcon build failing

OK. I think I've fixed the getListOfFiles problem. The Maven examples build seems to be turning on remove-circulars where the Ant build doesn't. That might need to be fixed up, but actually it helps test the code paths in the dependency management. -Alex On 3/28/17, 9:54 AM, "Alex Harui" wrot

Re: Falcon build failing

There are lots of issues being dealt with so I don't know which one you are referring to. I'm still working on the exception in getListOfFiles. -Alex On 3/28/17, 9:42 AM, "Harbs" wrote: >Looking at you change, I doubt it’ll fix my problem because I WAS using >remove-circulars, but I’m trying a

Re: Falcon build failing

Looking at you change, I doubt it’ll fix my problem because I WAS using remove-circulars, but I’m trying anyway… > On Mar 28, 2017, at 6:50 PM, Alex Harui wrote: > > Hmm. Looks like I broke something. Even DataBindingExample didn't run. > I just pushed a change to fix DataBindingExample and

Re: Falcon build failing

Hmm. Looks like I broke something. Even DataBindingExample didn't run. I just pushed a change to fix DataBindingExample and hopefully all other apps. Please pull flex-falcon and try again. Sorry about the delay, -Alex On 3/28/17, 7:13 AM, "Harbs" wrote: >Thanks, but I’m having bigger proble

Re: Falcon build failing

Thanks, but I’m having bigger problems. Hopefully Alex will look into the other issues… > On Mar 28, 2017, at 4:55 PM, Josh Tynjala wrote: > > I have moved my new tests into the Ant integration tests, so they should no > longer block you. > > - Josh > > On Tue, Mar 28, 2017 at 1:21 AM, Harbs

Re: Falcon build failing

I have moved my new tests into the Ant integration tests, so they should no longer block you. - Josh On Tue, Mar 28, 2017 at 1:21 AM, Harbs wrote: > It was Josh’s tests that were tripping me up. The build fails after doing > a wipe-all. > > I’ve been having other problems with Falcon, and the l

Re: Falcon build failing

Yes. That’s what happened, and I got past that problem. My problem now is not related to the tests. I’m having two problems: 1. org.apache.flex.core.Application is not being added as a dependency to the main app. 2. Any app which uses BinaryData fails to compile. This app: https://paste.apache.o

Re: Falcon build failing

Just an edjucated guess from my side … There is a cycle in the dependencies. Maven has problems with this and simply fails to start. Ant doesn’t do this sort of check. If you do a wipe all, eventually the prerequisites of your test get wiped and therefore you can’t run the test so you would hav

Re: Falcon build failing

Harbs, I saw that error a short while ago, but I am not sure it is related to the native classes. Dependencies calculated for 'org.apache.flex.states.SetProperty' org.apache.flex.states.SetProperty depends on org.apache.flex.core.IDocument was all the appeared immediately before I saw it. If you

Re: Falcon build failing

It’s really weird: I can’t see anything in my app which relies on Uint8Array and Uint32Array, and I’m still getting this error. :-( > On Mar 28, 2017, at 11:21 AM, Harbs wrote: > > It was Josh’s tests that were tripping me up. The build fails after doing a > wipe-all. > > I’ve been having ot

Re: Falcon build failing

It was Josh’s tests that were tripping me up. The build fails after doing a wipe-all. I’ve been having other problems with Falcon, and the latest logging seems to shed some light on what’s wrong: [java] Dependencies calculated for 'org.apache.flex.states.SetProperty' [java] org.apache

Re: Falcon build failing

On 3/26/17, 1:19 PM, "Harbs" wrote: >I’m having trouble building Falcon. > >It looks like it’s failing because a text in FlexJSTestBase.java is >failing. It’s looking for a file >flex-asjs/frameworks/as/basic-manifest.xml which does not exist. That output has been there for months. It isn't t

Re: Falcon build failing

Yup. I’m still waiting for you to show me what I’m missing about Maven in Miami… ;-) > On Mar 26, 2017, at 11:40 PM, Christofer Dutz > wrote: > > Probably the Ant build … correct? > > The Maven build shouldn’t care about that. > > Chris > > > > > Am 26.03.17, 22:19 schrieb "Harbs" : > >

Re: Falcon build failing

Probably the Ant build … correct? The Maven build shouldn’t care about that. Chris Am 26.03.17, 22:19 schrieb "Harbs" : I’m having trouble building Falcon. It looks like it’s failing because a text in FlexJSTestBase.java is failing. It’s looking for a file flex-asjs/frameworks/

RE: [Bindable] and private setters (was Re: [Falcon])

+1 for leaving the setter private. -Mark -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Tuesday, November 22, 2016 1:01 PM To: dev@flex.apache.org Subject: Re: [Bindable] and private setters (was Re: [Falcon]) On 11/22/16, 9:26 AM, "Josh Tynjala" wrote:

Re: [FALCON][FALCONJX} org.json replacement

https://mail-archives.apache.org/mod_mbox/www-legal-discuss/201611.mbox/browser On Nov 23, 2016, at 8:52 PM, OmPrakash Muppirala wrote: > Is there a link to the announcement? Or any other source for more details? > > Thanks, > Om > > On Wed, Nov 23, 2016 at 8:57 AM, Alex Harui wrote: > >> H

Re: [FALCON][FALCONJX} org.json replacement

The announcement was on legal-discuss. Someone said the archives haven't caught up yet. -Alex On 11/23/16, 10:52 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Is there a link to the announcement? Or any other source for more >details? > >Thanks, >Om > >On Wed, Nov 23, 2016

Re: [FALCON][FALCONJX} org.json replacement

Is there a link to the announcement? Or any other source for more details? Thanks, Om On Wed, Nov 23, 2016 at 8:57 AM, Alex Harui wrote: > Hi, > > Today, Apache's VP Legal announced that ASF projects can no longer use > org.json due to licensing issues. Apparently, there are replacements such

Re: [Bindable] and private setters (was Re: [Falcon])

That works for me. I wonder if we can show a different error if there's a non-public setter. I remember being confused for a bit the first time I saw that error about the property being read-only. - Josh On Tue, Nov 22, 2016 at 10:01 AM, Alex Harui wrote: > > > On 11/22/16, 9:26 AM, "Josh Tynja

Re: [Bindable] and private setters (was Re: [Falcon])

On 11/22/16, 9:26 AM, "Josh Tynjala" wrote: >If they make the getter public and the setter private, it's probably on >purpose. If the compiler then forces the setter to be public for >[Bindable], it should at least tell them that something probably >unexpected >is happening. I think a warning m

Re: [Bindable] and private setters (was Re: [Falcon])

If they make the getter public and the setter private, it's probably on purpose. If the compiler then forces the setter to be public for [Bindable], it should at least tell them that something probably unexpected is happening. I think a warning makes sense. [Bindable(eventName)] is definitely the

Re: [Bindable] and private setters (was Re: [Falcon])

I think it should be possible to generate the right code for [Bindable] so that the setter remains private. But then when the code tries to access the setter without the "private::" namespace you will get a "read-only" error. Regarding Josh's feedback, I'm not sure we should detect a mismatch bet

Re: [Bindable] and private setters (was Re: [Falcon])

Perhaps Falcon should have a specific compiler error or warning that says that setters must be public when using [Bindable]. I assume that the current error is kind of generic, so something more specific would help make it clear what's wrong and how to fix it. - Josh On Mon, Nov 21, 2016 at 9:48

Re: [Bindable] and private setters (was Re: [Falcon])

Agreed. It should not do automatic conversions. Now that you mention it, I’ve been getting Bindable warnings on those classes for years. Everything worked, so I ignored it, but I would not be surprised if the warnings were related to this issue. Thanks for looking into this. Harbs On Nov 22,

[Bindable] and private setters (was Re: [Falcon])

After some investigation, it appears that for classes with [Bindable], with MXMLC you could get away with having a public getter and private setter. But that is because the MXMLC compiler converts the setter to a public setter, defeating the whole point of making a private setter. So, I'd like to

Re: [Falcon]

I changed it to this.regular = font and I’m still getting the same error. On Nov 21, 2016, at 10:18 AM, Harbs wrote: > Huh. > > I just did a code review, and it looks like “this” was removed from the > FlexJS code a number of months ago. Not sure why… > > On Nov 21, 2016, at 9:41 AM, Alex Har

Re: [Falcon]

Huh. I just did a code review, and it looks like “this” was removed from the FlexJS code a number of months ago. Not sure why… On Nov 21, 2016, at 9:41 AM, Alex Harui wrote: > Please post a small test case I can compile with MXMLC. > > -Alex > > On 11/20/16, 11:37 PM, "Harbs" wrote: > >> Y

Re: [Falcon]

Please post a small test case I can compile with MXMLC. -Alex On 11/20/16, 11:37 PM, "Harbs" wrote: >Yes. This code is about 4 or 5 years old and I’ve had no errors to date. > >On Nov 21, 2016, at 9:35 AM, Alex Harui wrote: > >> Are you sure MXMLC compiles your code without error? MXMLC repor

Re: [Falcon]

Yes. This code is about 4 or 5 years old and I’ve had no errors to date. On Nov 21, 2016, at 9:35 AM, Alex Harui wrote: > Are you sure MXMLC compiles your code without error? MXMLC reported the > "read-only" error for me. > > -Alex > > On 11/20/16, 10:44 PM, "Harbs" wrote: > >> The latest F

Re: [Falcon]

Are you sure MXMLC compiles your code without error? MXMLC reported the "read-only" error for me. -Alex On 11/20/16, 10:44 PM, "Harbs" wrote: >The latest Falcon breaks valid existing code patterns. > >I know there was a recent discussion on related, but I can’t find it >right now. > >I have so

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 10/5/16, 11:13 AM, "Harbs" wrote: >And what’s the reason we’re not just using Foo.someOtherStaticProperty? >Is this a getter issue? Getters/Setters need to be defined via Object.defineProperty. It is the only way to access a function via a property name (without using parentheses). IOW

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 10/5/16, 11:10 AM, "Harbs" wrote: >So, this is only an issue for static functions and vars? Constants should >be fine. Right? Actually, only for static getters and setters. The output for vars, consts and functions are not being changed at all and GCC will rename them and set up aliases fo

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

And what’s the reason we’re not just using Foo.someOtherStaticProperty? Is this a getter issue? On Oct 5, 2016, at 9:08 PM, Alex Harui wrote: > > > On 10/5/16, 10:43 AM, "Harbs" wrote: > >> I have not been following this discussion very well, so I’m not sure I >> got the issue, but will th

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

So, this is only an issue for static functions and vars? Constants should be fine. Right? On Oct 5, 2016, at 9:08 PM, Alex Harui wrote: > > > On 10/5/16, 10:43 AM, "Harbs" wrote: > >> I have not been following this discussion very well, so I’m not sure I >> got the issue, but will this prev

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 10/5/16, 10:43 AM, "Harbs" wrote: >I have not been following this discussion very well, so I’m not sure I >got the issue, but will this prevent optimization of minimized code which >accesses static properties? I think I have discovered that static getters/setters were never getting renamed

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

I have not been following this discussion very well, so I’m not sure I got the issue, but will this prevent optimization of minimized code which accesses static properties? On Oct 5, 2016, at 7:26 PM, Alex Harui wrote: > Anyway, I wanted to see if anyone objects to this change before I push it

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

This seems like a reasonable enough workaround. I really wish GCC weren't always giving us so many issues. I know many of them are "by design", but it gets frustrating very quickly. - Josh On Wed, Oct 5, 2016 at 9:26 AM, Alex Harui wrote: > So I replaced the @expose usage with @export on Access

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

So I replaced the @expose usage with @export on Accessors and looked into why things don't work when you do that. It probably is a bug in GCC, but I saw an article where GCC developers say that all static definitions are considered separate "globals" and not properties of something. It is an inte

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

I pushed changes to generate exportSymbol/exportProperty for certain metadata names. It fixed the ReflectionTests in GenericTests. I also modified ObservedBugs so that it wouldn't get optimized away. IMO, folks will just have to realize that certain patterns can be optimized away. It might be p

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 10/3/16, 10:51 AM, "Greg Dove" wrote: >That sounds great Alex. Good sleuthing. As keep as3 metadata provides for >specific metadata don't you think this could be default for the class >members with specific kept metadata? Given that the only reason for >keeping >it would be for reflection,

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

That sounds great Alex. Good sleuthing. As keep as3 metadata provides for specific metadata don't you think this could be default for the class members with specific kept metadata? Given that the only reason for keeping it would be for reflection, I mean? I will be happy with the option here no ma

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Update: Turns out that FalconJX already calls GCC with --generate-exports, and methods are being exported in the js-release version. What it looks like to me is that for the one case I am debugging (ReflectionTesterTest), the setUpBeforeClass method is removed by GCC dead code removal since there

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 10/1/16, 12:37 PM, "Greg Dove" wrote: >Sorry I did not have time to read up on this yet. > >If --generate-exports can somehow restore that naming retention for public >static members annotated with '@export' then that will be a great starting >point as an option to switch this on or off when

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Sorry I did not have time to read up on this yet. If --generate-exports can somehow restore that naming retention for public static members annotated with '@export' then that will be a great starting point as an option to switch this on or off when needed. If I consider where I have used refllect

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Change GoogDocEmitter got rid of the warnings but broke GenericTests for now. I will next try --generate-exports, but I'm thinking we want to allow control at the file and property/method level. Thoughts? -Alex On 9/30/16, 12:27 PM, "Greg Dove" wrote: >Thanks for the explanation! >I guess I mi

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Thanks for the explanation! I guess I missed the distinction with the accessors, but I had remembered the 'solution' and just assumed it was appropriate when it 'worked' for static variables and methods (not realizing the other consequences). In any case it appears that @export does not prevent re

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

IMO, there are two separate issues. I think Josh found that static accessors couldn't be accessed via normal code "ClassName.propertyName". I ran into this for instance accessors as well. The instance accessors are defined in a Object.defineProperty call separate from the usual ClassName.prototy

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

I read that link, it's very helpful. It seems that this is going to be a challenge. I suggest you revert that as you suggested. Josh discovered this originally for static accessors I think (the fact that @export does not prevent renaming on statics and @expose was the only other option that seemed

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Alex, @export did not work for me on any static members. You cannot reflect into the field names unless you use @expose. You can double check this via generictests reflection tests. -Greg [sent from my phone] On 1/10/2016 5:21 AM, "Alex Harui" wrote: > > > On 9/29/16, 11:36 PM, "Alex Harui" w

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 9/29/16, 11:36 PM, "Alex Harui" wrote: > >Now that I got rid of the circularity in Ibead/Istrand I am also getting a >ton of warnings that say: > > WARNING - incomplete alias created for namespace goog I think is is being caused by the change from @export to @expose [1] What was the scenar

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 9/28/16, 11:43 AM, "Alex Harui" wrote: > > >On 9/28/16, 11:23 AM, "Greg Dove" wrote: > >>OT: I am getting a lot of warnings in the GCC release build phase. I >>recall >>you mentioning something in the past about this being related to GCC >>versions - is there anything I can do to address this

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 9/28/16, 11:36 AM, "Greg Dove" wrote: >Thanks for clarifying. I see that you mentioned that originally now :) >I think if GCC is smart enough to follow the indirection between those >reflection field names and all possible uses of reflection it would be >quite impressive. I don't think it wo

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 9/28/16, 11:23 AM, "Greg Dove" wrote: >OT: I am getting a lot of warnings in the GCC release build phase. I >recall >you mentioning something in the past about this being related to GCC >versions - is there anything I can do to address this? Every once in a while, we have to upgrade to the

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

Thanks for clarifying. I see that you mentioned that originally now :) I think if GCC is smart enough to follow the indirection between those reflection field names and all possible uses of reflection it would be quite impressive. I don't think it works as is, because if it wasn't for some static f

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

On 9/28/16, 11:19 AM, "Greg Dove" wrote: >I hadn't investigated any of this, just wondered about it I will check the >reflection results today. >I had actually assumed that @export and @expose explicitly prevented >renaming, but also had not checked this. > Maybe I wasn't clear. @export and @

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

OT: I am getting a lot of warnings in the GCC release build phase. I recall you mentioning something in the past about this being related to GCC versions - is there anything I can do to address this? On Thu, Sep 29, 2016 at 7:19 AM, Greg Dove wrote: > I hadn't investigated any of this, just wo

Re: Variable Renaming (was Re: [Falcon] Proposal for new ActionScript language feature: Optionally rename an import)

I hadn't investigated any of this, just wondered about it I will check the reflection results today. I had actually assumed that @export and @expose explicitly prevented renaming, but also had not checked this. On Thu, Sep 29, 2016 at 7:13 AM, Alex Harui wrote: > In fact, when I last touched i

  1   2   3   4   5   6   >