Ps: Indeed if the file is modified localy, git wont conplain during the
checkout :-)
Envoyé depuis un mobile Samsung
Message d'origine De : webdoublefx
Date :06/02/2014 15:53 (GMT+00:00)
A : dev@flex.apache.org Objet : RE : FLEX-34070
Sorry, short answer because
(GMT+00:00)
A : dev@flex.apache.org Objet : RE: FLEX-34070
>IMO any non binary item in the source release should be under version control
>so we have a history of how it how changed - just because it's generated
>doesn't mean >you don't want to know how it changed fr
Definitely not trying to make more work for the RM. Can you remind me of
the details of what went wrong with the -config.xml that one time?
On 2/6/14 2:33 AM, "Justin Mclean" wrote:
>Hi,
>
>Sorry - but seriously why are we trying to make things more difficult for
>a release manager and increase
Hi,
> OK, but in daily bug fixing, every time I run ant main, I have to clean up
> those files before committing, pulling, etc. Why is that not happening
> for others?
No idea sorry. I've made 100's of commits with no issues with this.
> Can we just put a Fail condition if build number is 0?
Pr
Hi,
Sorry - but seriously why are we trying to make things more difficult for a
release manager and increase the change a release candidate may be
rejected/have to be redone?
Again this issue caused a release candidate to be rejected with all that wasted
time and effort involved - why are peo
On 2/5/14 11:23 PM, "Justin Mclean" wrote:
>Hi,
>
>> Aren't all four generated? If so, I'm still not understanding why we
>>call
>> them source and have them under version control if
>They are part of the source and binary release zips/tar. I guess another
>option is to not have these files at
software.com]
Envoyé : jeudi 6 février 2014 08:24
À : dev@flex.apache.org
Objet : Re: FLEX-34070
Hi,
> Aren't all four generated? If so, I'm still not understanding why we
> call them source and have them under version control if
They are part of the source and binary release
Hi,
> Aren't all four generated? If so, I'm still not understanding why we call
> them source and have them under version control if
They are part of the source and binary release zips/tar. I guess another option
is to not have these files at all in the releases then there also no chance
they w
On 2/5/14 5:53 PM, "Justin Mclean" wrote:
>Hi,
>
>> I find myself doing 'git checkout' on these four files pretty often.
>Not sure why you need to do that - but perhaps having untokenised
>versions of these files checked in would solve that?
>
>They are generated from the templates not themselv
Hi,
> I find myself doing 'git checkout' on these four files pretty often.
Not sure why you need to do that - but perhaps having untokenised versions of
these files checked in would solve that?
They are generated from the templates not themselves right?
Thanks,
Justin
I'm sorry I don't remember the actual history. I'm trying to understand
how making a mistake in the -template files is more likely to happen or
less likely to be caught when making the RC. When you make a full RC, at
least the flex-config.xml is used to compile the binary release.
I find myself
Hi,
OK I believe the issue was than between making a build and zipping it up for a
release it's possible that something else can change those files (ide scripts
for instance). If the files are in git ignore you have no way of knowing that
they have been changed and then release something that i
Config files are generated by the basic build (frameworks/build.xml
target=main)
On 05/02/2014 23:34, Justin Mclean wrote:
I think (but not 100% sure) the config files may only be generated with a full
release build not an ordinary build.
Justin
--
Lee Burrows
ActionScripter
HI,
> Interesting. Why does flex-config.xml have to be in the source release if
> it is generated by the build. It isn't source if it is generated, IMO.
Because then you don't how it was changed which can be dangerous, I said we had
to scrap an entire RC because of this. I think (but not 100%
.@adobe.com]
Envoyé : jeudi 6 février 2014 00:18
À : dev@flex.apache.org
Objet : Re: FLEX-34070
Interesting. Why does flex-config.xml have to be in the source release if it
is generated by the build. It isn't source if it is generated, IMO.
-Alex
On 2/5/14 3:08 PM, "Lee Burrows"
g.xml is not in .gitignore
Maurice
-Message d'origine-
De : Lee Burrows [mailto:subscripti...@leeburrows.com]
Envoyé : jeudi 6 février 2014 00:08
À : dev@flex.apache.org
Objet : Re: FLEX-34070
Indeed; i have my interested-user hat on rather than my thats-my-patch hat ;)
Looks li
>
>> Maurice
>>
>> -Message d'origine-
>> De : Lee Burrows [mailto:subscripti...@leeburrows.com]
>> Envoyé : mercredi 5 février 2014 23:57
>> À : dev@flex.apache.org
>> Objet : Re: FLEX-34070
>>
>> My feeling is that the non-templat
bscripti...@leeburrows.com]
Envoyé : jeudi 6 février 2014 00:08
À : dev@flex.apache.org
Objet : Re: FLEX-34070
Indeed; i have my interested-user hat on rather than my thats-my-patch hat ;)
Looks like Justin added flex-config.xml with the reasoning: "File in source
release should be under v
but let's see what others will say.
Maurice
-Message d'origine-
De : Lee Burrows [mailto:subscripti...@leeburrows.com]
Envoyé : mercredi 5 février 2014 23:57
À : dev@flex.apache.org
Objet : Re: FLEX-34070
My feeling is that the non-template versions should be ignored; seems odd t
;Agree, but let's see what others will say.
>
>Maurice
>
>-Message d'origine-
>De : Lee Burrows [mailto:subscripti...@leeburrows.com]
>Envoyé : mercredi 5 février 2014 23:57
>À : dev@flex.apache.org
>Objet : Re: FLEX-34070
>
>My feeling is that the non
Hi,
>> flex-config.xml, air-config.xml and airmobile-config.xml are not in
>> .gitignore, although they are generated by the build, from template files.
>> Is that ok ?
BTW I believe they were in .gitignore at one point which caused a release
candidate to be incorrect/have issues - so please do
Agree, but let's see what others will say.
Maurice
-Message d'origine-
De : Lee Burrows [mailto:subscripti...@leeburrows.com]
Envoyé : mercredi 5 février 2014 23:57
À : dev@flex.apache.org
Objet : Re: FLEX-34070
My feeling is that the non-template versions should be ignored;
My feeling is that the non-template versions should be ignored; seems
odd to include them only for them to be overwritten by the build
On 05/02/2014 22:43, Maurice Amsellem wrote:
I have reviewed and committed FLEX-34070 patch
Little question:
flex-config.xml, air-config.xml and airmobile
23 matches
Mail list logo
