In the other thread, Justin says that these files " need to be committed and tagged with each build." So that's why they can't be in .gitignore.
So maybe we could commit and tag the *-template.xml files instead. I am not too familiar with the installer script, but probably it's excepting *-config.xml files to be present in the download. So maybe these scripts could be changed to use the *-config-template.xml instead, and instanciate them to generate the *-config.xml, on the fly. WDYT? Maurice -----Message d'origine----- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 6 février 2014 00:18 À : dev@flex.apache.org Objet : Re: FLEX-34070 Interesting. Why does flex-config.xml have to be in the source release if it is generated by the build. It isn't source if it is generated, IMO. -Alex On 2/5/14 3:08 PM, "Lee Burrows" <subscripti...@leeburrows.com> wrote: >Indeed; i have my interested-user hat on rather than my thats-my-patch >hat ;) > >Looks like Justin added flex-config.xml with the reasoning: "File in >source release should be under version control", so a precedent has >been set. > > >On 05/02/2014 22:59, Maurice Amsellem wrote: >> Agree, but let's see what others will say. >> >> Maurice >> >> -----Message d'origine----- >> De : Lee Burrows [mailto:subscripti...@leeburrows.com] >> Envoyé : mercredi 5 février 2014 23:57 À : dev@flex.apache.org Objet >> : Re: FLEX-34070 >> >> My feeling is that the non-template versions should be ignored; seems >>odd to include them only for them to be overwritten by the build >> >> On 05/02/2014 22:43, Maurice Amsellem wrote: >>> I have reviewed and committed FLEX-34070 patch >>> >>> Little question: >>> flex-config.xml, air-config.xml and airmobile-config.xml are not in >>>.gitignore, although they are generated by the build, from template >>>files. >>> Is that ok ? >>> >>> If it's ok, then maybe I should update them with more recent version >>>of FP (eg 11.9) and recommit ? >>> >>> Maurice >>> >>> -----Message d'origine----- >>> De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : >>> mercredi >>> 5 février 2014 22:46 À : dev@flex.apache.org Objet : JIRA bugs >>> raised on the rise >>> >>> Hi, >>> >>> Over the last couple of months bugs are being raised twice as fast >>>as they being fixed and there's only a few committers who are >>>actively fixing bugs. While everyone is free to do what they want to >>>do on a project (including nothing) being a committer does mean you >>>have a responsibility to the current users of the software.[1] If >>>all of the current committer fixed only a single bug a month we would >>>outstrip the number of bugs being raised. >>> >>> There are some bugs with patches that would be simple to apply and >>>test - for instance this one re the new installer script: >>> https://issues.apache.org/jira/browse/FLEX-34070 >>> >>> Also remember we need help from users as well - confirming that a >>>bug exits is helpful and would get the bug noticed. Supplying patches >>>to bugs is also one way to become a committer. >>> >>> If you're looking for something to fix and don't know where to start >>>the "easytest"[2] or "easyfix"[3] bugs are a good place to find easy >>>to solve bugs. >>> >>> For more info on have to how to fix bugs see [4]. >>> >>> Thanks, >>> Justin >>> >>> 1. >>> http://www.apache.org/dev/committers.html#committer-responsibilities >>> 2. >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLEX%20AN >>> D% >>> 20labels%20%3D%20EasyTest 3. >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLEX%20AN >>> D% >>> 20labels%20%3D%20EasyFix 4. >>> https://cwiki.apache.org/confluence/display/FLEX/Bug+Fixing >>> >> >> -- >> Lee Burrows >> ActionScripter >> >> > > >-- >Lee Burrows >ActionScripter >
