On 2/5/14 11:23 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> Aren't all four generated? If so, I'm still not understanding why we >>call >> them source and have them under version control if >They are part of the source and binary release zips/tar. I guess another >option is to not have these files at all in the releases then there also >no chance they will be incorrect. > >IMO any non binary item in the source release should be under version >control so we have a history of how it how changed - just because it's >generated doesn't mean you don't want to know how it changed from release >to release - it may not always be directly obvious from the generating >template and build scripts. Ant and the installer can do token replacement. Do we really need -template files or just check them in with the final name and require replacement? > >> The diff on these four files shows an updated build number in >> flex-sdk-description. How is it that you don't also show this file as >> modified? >Because it gets checked in before the release is tagged. OK, but in daily bug fixing, every time I run ant main, I have to clean up those files before committing, pulling, etc. Why is that not happening for others? > >Again you could accidentally make a release with "0" as the build number >(quite easy to do/seen quite a few time - not 100% why it happens) so >best IMO to have this file under version control. Can we just put a Fail condition if build number is 0? -Alex
