Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Alex Harui
On 9/6/13 4:29 PM, "Mark Kessler" wrote: >Well I found a better way to check it out if we want to find out when it >first started. Look through the log on the image file. You put the >image >in on 9/5/1012 and it shows correctly... It shows the image without a >line. Carol put in a new ve

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Mark Kessler
Well I found a better way to check it out if we want to find out when it first started. Look through the log on the image file. You put the image in on 9/5/1012 and it shows correctly... It shows the image without a line. Carol put in a new version on 12/21/2012 when she added that huge datag

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Alex Harui
On 9/6/13 3:58 PM, "Mark Kessler" wrote: > >My question would be do the tests no show the image compare failures or >further errors if a previous testID failed higher up in the same file. >Such as [4] which I fixed. Theoretically, the tests continue on unless an exception is thrown, so if the t

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Mark Kessler
The line was in the image for months at least. Not sure why it wasn't found until recently. But [1] and [2] were specifically about the DataGrid itemEditor stopping in weird places while editing after having scrolled. Which to mean would have been caused a line to appear since it would have disp

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Alex Harui
On 9/6/13 1:48 AM, "Mark Kessler" wrote: >Yeah I got the horizontal line myself. I bet that was originally a bug >from before we fixed the scrolling itemEdit issue. The correct image >should not show the line through the box. Hmm. That scrolling position issue wasn't one of the three changes

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-06 Thread Mark Kessler
Yeah I got the horizontal line myself. I bet that was originally a bug from before we fixed the scrolling itemEdit issue. The correct image should not show the line through the box. -Mark On Thu, Sep 5, 2013 at 10:58 PM, Alex Harui wrote: > Ran the tests myself. The bitmap shows a horizonta

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Alex Harui
Ran the tests myself. The bitmap shows a horizontal line through the reference image that is not in the result image. Please verify that you are seeing the same. You'll need to investigate whether that line should be there or not and if it is, figure out which code change resulted in the line no

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Alex Harui
On 9/5/13 3:43 PM, "Mark Kessler" wrote: >Ok so I ran [1] with createdImages and the test passed. Deleted the two >XML files it created and ran [2] without the create option and it still >passed. Image looks fine. So do I upload the two new baseline images ? Well, what are the differences be

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Mark Kessler
Ok so I ran [1] with createdImages and the test passed. Deleted the two XML files it created and ran [2] without the create option and it still passed. Image looks fine. So do I upload the two new baseline images ? [1] mini_run.sh -caseName=Editable_variableRowHeight tests/gumbo/components/Dat

Re: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Alex Harui
mm...@flex.apache.org; kesslerconsult...@gmail.com; >jmcl...@apache.org; bigosma...@gmail.com; ftho...@apache.org; >cyrill.za...@gmail.com >Subject: Build failed in Jenkins: flex-sdk_mustella #290 > >See <http://localhost:8080/job/flex-sdk_mustella/290/changes> > >Changes: > &

RE: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Kessler CTR Mark J
mailto:aha...@adobe.com] Sent: Thursday, September 05, 2013 12:41 PM To: dev@flex.apache.org Subject: Re: Build failed in Jenkins: flex-sdk_mustella #290 On 9/5/13 6:47 AM, "Kessler CTR Mark J" wrote: >Not sure how we changed a bitmap for variableRowHeight with the 3 below >commits. I ca

RE: Build failed in Jenkins: flex-sdk_mustella #290

2013-09-05 Thread Kessler CTR Mark J
From: flex.muste...@gmail.com [mailto:flex.muste...@gmail.com] Sent: Thursday, September 05, 2013 9:30 AM To: comm...@flex.apache.org; kesslerconsult...@gmail.com; jmcl...@apache.org; bigosma...@gmail.com; ftho...@apache.org; cyrill.za...@gmail.com Subject: Build failed in Jenkins: flex-sdk_mus