The line was in the image for months at least.  Not sure why it wasn't
found until recently.  But [1] and [2] were specifically about the DataGrid
itemEditor stopping in weird places while editing after having scrolled.
Which to mean would have been caused a line to appear  since it would have
displayed incorrectly.  If you run the test manually you can see it
displaying properly and before those other two [1][2] issues were fixed
would have been probably displayed partially through the bottom of the
datagrid border line.

The test itself says "verify variableRowHeight=true, different
columnWidth,editor should show in different size", it doesn't show it's
testing it to stop inbetween the rows.


My question would be do the tests no show the image compare failures or
further errors if a previous testID failed higher up in the same file.
Such as [4] which I fixed.


[1] https://issues.apache.org/jira/browse/FLEX-33665
[2] https://issues.apache.org/jira/browse/FLEX-33666
[3] mustella/tests/gumbo/components/DataGrid/SWFs/DataGrid_itemEditor.swf

[4] Editable_startItemEditorSesision_inValidParams



-Mark


On Fri, Sep 6, 2013 at 5:00 PM, Alex Harui <aha...@adobe.com> wrote:

>
>
> On 9/6/13 1:48 AM, "Mark Kessler" <kesslerconsult...@gmail.com> wrote:
>
> >Yeah I got the horizontal line myself.  I bet that was originally a bug
> >from before we fixed the scrolling itemEdit issue.  The correct image
> >should not show the line through the box.
> Hmm.  That scrolling position issue wasn't one of the three changes that
> could cause this failure was it?
>
> The conservative approach would be to locally revert all three changes and
> see if the test runs successfully.  I set a breakpoint on the test's
> CompareBitmap.as:execute to see what else was on-screen at the time.  I
> don't see a dark line in the DG, so I'm not sure it is the row separators.
>  My concern is that the dark line is the border of the editor and that
> border is now hidden, but I also can't imagine which of the three changes
> could affect that either, and I would expect other tests to fail as well
> unless it is an issue with the editor border only when scrolled.
>
> -Alex
>
>

Reply via email to