Ok so I ran [1] with createdImages and the test passed.  Deleted the two
XML files it created and ran [2] without the create option and it still
passed.  Image looks fine.  So do I upload the two new baseline images ?

[1] mini_run.sh  -caseName=Editable_variableRowHeight
tests/gumbo/components/DataGrid/Properties/DataGrid_Properties_editable.mxml
-createImages

[2] mini_run.sh  -caseName=Editable_variableRowHeight
tests/gumbo/components/DataGrid/Properties/DataGrid_Properties_editable.mxml


-Mark

On Thu, Sep 5, 2013 at 12:41 PM, Alex Harui <aha...@adobe.com> wrote:

>
>
> On 9/5/13 6:47 AM, "Kessler CTR Mark J" <mark.kessler....@usmc.mil> wrote:
>
> >Not sure how we changed a bitmap for variableRowHeight with the 3 below
> >commits.  I can look at the bitmaps when I get home.  If it looks
> >correct, how do I update the bitmap it uses to check with?  Just copy
> >it's compared one and push it back to the sdk?
> Recommended practice is to run the test with -createImages option (and
> then delete the associated png.xml and run it again without to verify that
> there aren't any differences caused by that option).
>
> Sometimes there are differences and the test needs upgrading to eliminate
> those differences.  If you just push the "compared one" then someone else
> will be confused later if another change is required.
>
> Did this run use a different player?  If so, I wouldn't push a new bitmap,
> I would investigate the differences, and if they are just anti-aliasing
> differences, then I would add the png.xml file generated from the 11.1
> player if that gets it to pass.
>

Reply via email to