Thanks Alex, much appreciated
On Wed, Mar 8, 2017 at 7:24 PM, Alex Harui wrote:
> OK. I'll take care of it.
>
> On 3/7/17, 10:11 PM, "Greg Dove" wrote:
>
> >Yes, I think they are errors with the tests.
> >
> >iirc it was
> >
> >
> >
> >
> >
> >or something like that. So I think the new code i
OK. I'll take care of it.
On 3/7/17, 10:11 PM, "Greg Dove" wrote:
>Yes, I think they are errors with the tests.
>
>iirc it was
>
>
>
>
>
>or something like that. So I think the new code is picking up the right
>things :)
>
>I am struggling for time right now, if you have time that would be
>fan
Yes, I think they are errors with the tests.
iirc it was
or something like that. So I think the new code is picking up the right
things :)
I am struggling for time right now, if you have time that would be
fantastic, otherwise I will try to get to it later tonight.
On Wed, Mar 8, 2017
Greg,
I just realized that these might be legitimate errors. I can fix them if
you don't have time.
-Alex
On 3/7/17, 1:32 PM, "Alex Harui" wrote:
>
>
>On 3/7/17, 1:04 PM, "Greg Dove" wrote:
>
>>I had never run those tests specifically - I was not even aware of those
>>yet, the unit tests run
On 3/7/17, 1:04 PM, "Greg Dove" wrote:
>I had never run those tests specifically - I was not even aware of those
>yet, the unit tests run during ant all build had proceeded without
>problems:
There are three sets of unit tests. Because the compiler is needed to
build the AS framework, we can'
I had never run those tests specifically - I was not even aware of those
yet, the unit tests run during ant all build had proceeded without problems:
I am seeing this:
[junit] Running
org.apache.flex.compiler.internal.codegen.js.flexjs.TestFlexJSFile
[junit] Unable to parse
D:\FLEXSDKS\_a
On 3/7/17, 9:41 AM, "Greg Dove" wrote:
>Anything else I should be doing?
If you are using Ant to build flex-falcon, please run
ant flexjs.dependent.tests
This may require setting up an ASJS_HOME environment variable or setting
in env.properties to point to the flex-asjs repo that has prev
Anything else I should be doing?
One thing I did not check (and generally have not checked specifically with
anything I did so far in FlexJS) is anything to do with inline
(fx:Component) mxml.
I *think* there are some unit tests for these, I would need to double
check but if you are using tha
I have noticed that MXML compiling does not produce the greatest error reports.
I should have recorded issues as I saw them, but I didn’t. :-(
These two cases make sense to me, and thanks for fixing them. I’ll be happy to
update falcon and make sure that things still compile correctly in my apps
"It sound to me like you know what you’re talking about"
Haha, Harbs that's probably more reassuring to me than it should be to you.
In terms of anything at all in the compiler, I am still LAYG (learning as
you go) here ;)
(btw, you can never have too many 'as you go' acronyms)
I actually shared
I have to admit that you lost me pretty quickly… ;-)
It sound to me like you know what you’re talking about, so I’m fine with
whatever you did/want to do… :-)
Harbs
> On Mar 5, 2017, at 9:31 AM, Greg Dove wrote:
>
> OK please brace yourself for an onslaught of text.
>
> I tested across F
Hi Greg,
My main goal was to make sure the code that decides some set of child tags
is an array wasn't going to get messed up by trying to fix these bugs,
especially the multiple initializers being assigned to something that
isn't an Array.
Other than that, I'm really don't have any opinion on wh
OK please brace yourself for an onslaught of text.
I tested across Flex 4 and FlexJS through a bunch of variations. This
change passes all tests. In the end this is a very small and isolated code
change (I am almost certain it will not contribute to anyone's merge
conflicts) and I believe it g
I believe MXML is supposed to treat more than one child in a child tag as
an array. And thus, the equivalent AS code for:
is:
initialView = [ new MyInitialView, new MyOtherInitialView];
I understood the same, but I had thought it was supposed to be a bit
smarter than that and only
Hi Greg,
Thanks for digging into this.
Without having dug into it myself, I would like to suggest returning a
type mismatch error of some sort. IIRC, the DuplicateChildTagProblem is
for the following:
The child tag (js:initialView) is really in there twice.
I believe MXML is suppo
I have been looking into FLEX-35273 [1].
This is a compiler bug where it is possible to do things that don't make sense,
like:
or even this :
Neither of the above caused compile time errors.
I have a fix for both the above scenarios.
For the first one, I used
16 matches
Mail list logo
