Thanks Alex, much appreciated
On Wed, Mar 8, 2017 at 7:24 PM, Alex Harui <aha...@adobe.com> wrote: > OK. I'll take care of it. > > On 3/7/17, 10:11 PM, "Greg Dove" <greg.d...@gmail.com> wrote: > > >Yes, I think they are errors with the tests. > > > >iirc it was > > > ><initialView> > ><Label> > ><initialView> > > > >or something like that. So I think the new code is picking up the right > >things :) > > > >I am struggling for time right now, if you have time that would be > >fantastic, otherwise I will try to get to it later tonight. > > > > > > > > > > > > > > > >On Wed, Mar 8, 2017 at 7:06 PM, Alex Harui <aha...@adobe.com> wrote: > > > >> Greg, > >> > >> I just realized that these might be legitimate errors. I can fix them > >>if > >> you don't have time. > >> > >> -Alex > >> > >> On 3/7/17, 1:32 PM, "Alex Harui" <aha...@adobe.com> wrote: > >> > >> > > >> > > >> >On 3/7/17, 1:04 PM, "Greg Dove" <greg.d...@gmail.com> wrote: > >> > > >> >>I had never run those tests specifically - I was not even aware of > >>those > >> >>yet, the unit tests run during ant all build had proceeded without > >> >>problems: > >> > > >> >There are three sets of unit tests. Because the compiler is needed to > >> >build the AS framework, we can't have the compiler tests require the AS > >> >framework, so the set of tests that runs automatically don't have any > >>AS > >> >framework dependencies, then there is a set of tests with flex-sdk > >> >dependencies and one with flex-asjs dependencies, which is what you > >>just > >> >ran. > >> > > >> >Ignore the "Unable to parse" for now. > >> > > >> >IMO, no need to revert the changes. I've got plenty of other things to > >> >do. > >> > > >> >Thanks for digging into it. > >> >-Alex > >> > > >> > >> > >
