Alex-
It's actually mainly just the compc target-player in the build.xml of the CI
project. So the issue would only appear if trying to launch the a flash or air
instance to run tests against.
Cyril actually asked me this question (as noted about 5 years ago) and I
completely missed it until t
>It looks to me like the intention of the person who originally created the new
>ArrayList (Michael A. Labriola) was for it to be tested with the rest of the
>framework and then to replace the original ArrayList:
Nope, I don't think that was me. I was just changing the itemUp
>- FlexUnit (If none else wants to)
Chris,
I can't commit to doing the talk but, if you or anyone else wants to do so, I
would be happy to provide you with any/all of the FlexUnit slide decks and
talks I have done in the past as well as content around a bunch of really
useful but under-documen
get this correct: With "we" you are refering to you and the company you work
for? Would It be possible to rearange things? Sort of having a nice and tidy
core library and have one fb-compatability lib to make FB work with FlexUnit?
If you could provide a little more details, p
Question for the group:
The FlexUnit dependencies could be a lot cleaner but right now we have static
classes that reach out to try to figure out if it's an AS only application or a
Flex application among other things. The reason we do this is that Flash
Builder has a wrapper for the FlexUnit c
I could be wrong but I suspect the core of flexunit doesn't have sdk
dependencies. The CI functions can run without a gui.
>Correct. The FlexUnit core is just AS but there are hooks for the GUI. Its
>honestly something I wanted to refactor more. Right now it's possible to build
>a version with
>"checkfirstBaselineOffset" and "checkColumnWidthOnGapChangeTest"
>I will create -> https://paste.apache.org/7Qka
This is pretty close to what I was suggesting in my original comment.
Mike
I would look at your code again. I don't think it's doing what you think it's
doing. A few things including that slice returns a shallow copy. You make a
copy and pass the original up.
However, you don't need a rule at all. Just do this work in the loader.
Load your data but ensure you only pas
PROBLEM:
[Test(dataProvider=dp)]
public function checkColumnWidthOnGapChangeTest(dpData:Object):void
{
}
>If I add my data provider to the test above it will launch 100 times, but only
>two cases from this xml file is for this test.
This is just not how you are supposed to use this feature. It's
tely so I didn't have a way to hook in the Randori work there or I
would have, and I haven't kept up with it to see if that changed.
Mike
On Wed, Dec 17, 2014 at 12:14 PM, Michael A. Labriola <
labri...@digitalprimates.net> wrote:
>
> Om-
>
> >Thanks for the link.
Om-
>Thanks for the link. I went through the whole documentation (still have some
>questions, though). It looks pretty solid. Any reason there has not been
>much activity on Randori for a while? Are you planning some new updates any
>time soon?
Nope. There wasn't enough interest in cross-c
>1. An overview of the tools would be great. The README does not have a lot
>to start with. Or, are there any other documentation that I am missing?
You don't need to read through all of this, but if you want to get a sense of
what it was all about, there are a bunch of tutorials, etc. Most a
>In case you want to dig into (what I didn't do), this is the code [1], indeed,
>an explanation from M.Labriola or Roland would be welcome :-)
Happy to answer questions as they come up.
Mike
>Question: Can you “un-delete” a deleted branch in case we find later there is
>something in one of them that we need? Also, other than a smaller list of
>branches, what else does it save us? Does it make the repo >smaller?
Alex-
Branches are really just a pointer to a commit in the repo. So
>Anyone else? Or can I just delete any branch that is not master, develop,
>FDBWorkers or an old release branch? My guess would be:
>"no!", but it would sure be nice if you left a note saying you are still
>working on a branch ;-)
Erik,
I believe I still have mine out there and, if time ever pe
Welcome
-Mike
>I have merged my code to develop branch. I saw that TLF build correctly so I
>can assume that everything is working fine. :)
Nice work. Congratulations and good job
>I have missed something from your previous response and didn't try CIListener.
>- I am really sorry about it.
Now it is working, I can move forward.
No problems at all. I just wanted to know if you had tried so I could help you
debug it.
Hi,
Asking again, are you using the CIListener or the AIRCIListener? Those are the
components that do this work for you.
Mike
-Original Message-
From: piotrz [mailto:piotrzarzyck...@gmail.com]
Sent: Sunday, September 28, 2014 2:45 PM
To: dev@flex.apache.org
Subject: RE: Unit tests in
Piotr-
> Should I dispatch some event through the -> flexunituirunner:TestRunnerBase ?
If you are using any of the flexunit CI pieces they take care of that
communication back to the launching process for you. I don't know if you are or
are not. Dispatching an event is not ideal as the TestRunn
>Does anyone have an idea of which Flex SDK was used for the examples?
It was probably the original 4.0 SDK
>Applications that rely on pixel perfect text layout can not use the
>browser DOM because most everything in the browser world it is
>dependent on what browser and OS you use. This has led companies like
>Prezi, who is trying to get off FP, to use Emscripten for HarfBuzz in
>the browser then t
>Long story short we are trying to do what the Flash Player does outside of
>Flash. We have seen other companies have success using Emscripten and asm.js
>so if Adobe could open source parts of the Flash Player then we could get some
>of the Flash Player functionality in javascript. FTE and the
Just to provide some context. OSMF is still used in a few things Adobe sells. I
am glad to have Alex ask about it but I wouldn’t hold your breath on donation.
That was the response I got last time I asked (which has admittedly been a year
or so)
> My understanding is that a contractor "must" have the option of doing
> non-client work. If that's true, if you found an SDK bug while working for a
> client, would you "stop the clock", fix the bug, then "start the clock"
> again? That way the fix would be owned by you. If the fix is owned
TextFieldHTMLImporter:
/** Parse the formatting element
* Calculates the new format to apply to _activeFormat and continues
parsing down the hierarchy
* @private
*/
static public function
parseStrikeThrough(importer:TextFieldHtmlImpor
>Started to think about updating the tutorial to also walk them through the UI
>differences too. Before I get too far into this, I wanted to run it past the
>team. Is it cool if I go ahead and update the tutorials to also include the
>variations in FB 4.7 versus FB 4.6?
I don't have time to w
>As far as I understood the problem. Whenever the build was hanging, I could
>see a Flashplayer instance complaining about a timeout of 15 seconds having
>expired and if the user whiches to continue or cancel, hereby blocking the
>instance and the associated test.
I never finished it but we wer
>I have about 80 or so FlexUnit collection tests that were in my white board to
>supplement the mustella ones, but they are not currently run automatically.
I also have some in my whiteboard for VectorCollection and there are the
FlexUnit tests themselves in the FlexUnit repo.
But no, there
>However much I'd like to "kill" a commit (or commit a kill?), my very limited
>Git knowledge would surely bork the repo big time. Can you give me a pointer
>on how to safely handle this?
No worries. I should be able to take care of it today if you aren’t comfortable
with it (and I don’t blame
@flex.apache.org; Michael A. Labriola; Alex Harui
Subject: Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Fix for issue
FLEX-34320
Bump...
EdB
On Thu, Jun 5, 2014 at 9:53 AM, Erik de Bruin
mailto:e...@ixsoftware.nl>> wrote:
-1 (binding)
I'm vetoing this commit because it
>I haven't looked at the failing tests, but could it be true that those tests
>are not using XMLListCollection directly? They may wrap the XML in an
>XMLListCollection or just pass XML directly into the control where it gets
>wrapped, and then they manipulate the XML? I think there are lots of
>Are you saying that using XMLListCollection APIs to modify the source data has
>always been broken, or that you didn't like the behavior in how it >set up the
>parent? If there is some debate on what the behavior should be then there
>probably needs to be a flag to control that behavior. If i
> -1 for Cygwin too :-(
Something to note for Windows Users, if you install git bash (which is
generally part of the windows install for git) you can use it in place of
Cygwin. It might be a much easier way for us to move forward instead of
requiring Cygwin.
Mike
>Makes sense and we probably should have done that in the first place. But
>since we didn't, do we change behavior and risk breaking folks or add a flag
>and keep both code paths?
The problem I have with two code paths is how do we choose between them? Are we
going to do a version number check
>A totally reasonable scenario. It is tempting to simply remove this check,
>but you never know when someone is relying on this behavior.
I am not really suggesting that we remove it completely, just rather that we
consider it an OR. A SortField's name must either be valid or it must have a
co
>It's a valid question. There is probably no one right answer. My answer is
>that, if you didn't intend the compareFunction to use the field name in the
>SortField, why use a SortField at all? Why not just use the top-level Sort
>compareFunction.
Just continuing the discussion. I think the c
>>>You should get an arg count mismatch. By changing the
>>>(!hasFieldName) test on Sort.as line 413 I got the expected result
>>>("Find criteria must contain all sort fields")
>>
Okay, so this is where I have an issue that I am not sure how we should
resolve. I don't agree with the expected r
>I just looked at another failure (DataGroup). It also points at this set of
>changes. It turns out that Sort.fields can be null if you don't have any
>SortFields and only a Sort.compareFunction. It >fails on line 395.
>You'll need a null check there.
Thanks, that is the one I actually failed
>- The Menu/MenuBar/Tree/DataGrid/MXItemRenderer failures are a result of the
>XMLListCollection change. I looked at MXItemRenderer and it appears that the
>test is expecting an updateComplete when an XML node is added to the
>collection. Does this no longer happen because the parent is not no
>You should get an arg count mismatch. By changing the (!hasFieldName) test on
>Sort.as line 413 I got the expected result ("Find criteria must contain all
>sort fields")
Thanks. I think there may have been a bad merge on my part too as it seems the
logic that was checked in is also missing an
>Mike, your thoughts on the logic? The test sets up two SortFields and a
>compare function on the Sort (not the SortFields) then calls findItem.
The first SortField's field name is a non-existent field. I think the old
logic would see if the field existed in the data item. The new logic seems
> I've also heard of FlexUnit, which I believe is more tuned for class
> testing rather than UI interaction testing. I have heard of it being
> used for UI testing, but it was tricky to setup.
Just to reiterate, FlexUnit is definitely unit and some integration testing.
It's not intended to do
>Its intended so that if multiple people call disable() or enable() that it
>will only dispatch events if the net result gets back to 0.
>So, if two listeners disable() and one says enable() it shouldn't dispatch
>again until the last one says enable()
On a side note, I also see these methods ca
Gary,
Its intended so that if multiple people call disable() or enable() that it will
only dispatch events if the net result gets back to 0.
So, if two listeners disable() and one says enable() it shouldn't dispatch
again until the last one says enable()
Mike
-Original Message-
From:
One more possible solution I had pondered:
#3 We don't store the XML nodes in an XMLList internally. We store them in an
array. When someone calls addItemAt() we add it to the correct index in the
array, but to the end of the source XMLList. So the XMLList would always look
like we appended the
Nick,
It's harder than that:
Answer's integrated.
>Working on this bug, where addItemAt / addItem on the XMLListCollection was
>not parenting all the children properly. In particular, it was updating the
>XML Parents of items that were not modified (rather, were simply bumped to a
>later pos
>Would someone mind setting up a whiteboard for me. I have a bunch of bug fixes
>and minor features I want to get up there.
So, I did not just resend this and even just checked my mail server. It didn't
originate from here...
What is going on with the mailing list...
Mike
>I will set it up whenever I get a chance.
Thanks for the efforts,
Mike
Would someone mind setting up a whiteboard for me. I have a bunch of bug fixes
and minor features I want to get up there.
Github: https://github.com/labriola
Default email: labri...@acm.org
Repo name: whitboard_labriola
Thanks,
Mike
>Ok ... glad to help.
>But I have to admit that I have never done an Apache release before.
>So a little coaching from you guys would be great :)
Side note, I would like to get one bug fix in before we release too. After this
release, I think we should update Mockolate and Hamcrest version comp
> Ok ... so I got further than I expected today ... Actually I'm finished :-)
Nice work
>By the way: I read in this post [1] that FlexUnit 4.2 will support Code
>Coverage with Apparat. When will this be available?
People are needed to work on it
Jason Gardner did some great work on this [1], but it would require work to get
it into Apache. This is still the goal for anyone who can
>I have been looking for a way to contribute. I am mainly a doc person these
>days, although I have built a bunch of Flex apps over the past five or >six
>years. I would be happy to take on documenting the EventRule.
Awesome, Amy Blankenship started on some of this a while back. If she is on
th
>> If you are all ok with this I would like to volunteer to handle maven
>>deployment tasks as this does fit quite nicely into my area of
>>involvement ;-)
If I can help with anything let me know, else please do this :)
Anyone have spare cycles they could use the document a FlexUnit feature.
There is a feature of FlexUnit called the EventRule which I have never had time
to document. It's actually extraordinarily useful and really helpful. I slipped
it into an older FlexUnit release but never told anyone about
Download page with versions:
https://github.com/drewbourne/mockolate/downloads
Mike
-Original Message-
From: Justin Mclean [mailto:jus...@classsoftware.com]
Sent: Monday, April 14, 2014 4:56 PM
To: dev@flex.apache.org
Subject: Re: FlexUnit 4.2.0 release
Hi,
Checked all of the links b
Don't count this a second time, but forgot these details:
Windows 7 sp1/x64, java 7, FP 11.6.602.168, Air 4.0.0.1390
-Original Message-
From: Michael A. Labriola [mailto:labri...@digitalprimates.net]
Sent: Thursday, April 10, 2014 3:33 PM
To: dev@flex.apache.org
Subject: RE:
+1(Binding)
Tested on cadre of existing tests on a large project.
Mike
>In flex unit 4 most of those information about test we have got into
>TestRunnerBase. When I add FU 4 to project I've simple removed all of those
>methods and UI for display information and I replaced it one line of code
>.
In FlexUnit4, the information doesn't do into TestRunnerBase really.
>I used to pronounce them SWIK and SWIF ... is that the officially correct form?
Yep, that is correct.
Mike
>Do anyone have any any objections to the current RC (copyright or otherwise)
>before I go to the effort of making another one? Has anyone actually tested
>the current RC for things that actually matter? Like that the signed fields
>are correct, it can compile and it actually works? I would like
>My understanding is that Adobe donated stuff to fluint under Adobe copyright
>and BSD. That's why you put the Adobe header back in a bunch of files. My
>view says that two of these Adobe files are in CIListener. I think we need
>Mike to verify or provide a more detailed explanation of how th
>OK, I just wanted to make sure. If the agreement was similar to the one Adobe
>had you sign when submitting patches then I think we're set on LICENSE and
>NOTICE. If the agreement was more Apache-like, then Brian has copyright and
>DP has license and then we may need to ask him.
Yep, we basi
>Sorry about that - changed to Apache header and checked in.
No worries. Easy mistake as they were in similar packages. I just want Apache
headers on everything that can have them.
Mike
>I would change the notice to say that some of the code (instead of original,
>since original is Adobe) was developed by DP.
It was not originally Adobe code. FlexUnit 4 is a complete rewrite. We included
FlexUnit1 for backward compatibility. FlexUnit 4 will run without a single line
of Adobe c
And these 2 files were missing from the list which I assume should be Adobe
licensed.
>/FlexUnit4UIListener/src/org/flexunit/flexui/data/filter/IgnoredTestFunctionStatus.as
No, we wrote this one
>/FlexUnit4UIListener/src/org/flexunit/listeners/UIListener.as
No, this one was ours
>I checkout out the code from fluint.googlecode.com. An examination of the
>logs indicates that Xavi contributed files in FlexUnit4CIRunner as well as
>FlexUnit4UIRunner. Does that match your understanding? Were >those files
>brought into GitHub?
The UIRunner yes, it morphed into the UI List
>And in it I found AbstractRowData.as which looks exactly like the one on
>github for FlexUnit4 that Mike linked to earlier in this thread. I
haven't done any forensics on who checked it in and when, but keep in mind that
I am assuming that this code base on Adobe svn is the source for FlexUnit
>Thicker still, I found this:
>http://opensource.adobe.com/svn//opensource/flexunit/trunk/FlexUnitLib/
Good find Alex. I didn't realize the UI was checked in here. This looks like
the original version checked in by Alistair on August 15th, 2008. I think we
can use this repo as part of our refere
>Sadly I can't even get at the original source code to compare now vs then as
>it look like Adobe removed it from source forge. There's only a binary
>download.
The plot thickens.
I went through old emails like an auditor and found a bit more detail. The
original code was committed by Xavi Beu
>2) The code was modified by DP folks.
It was modified significantly as the original code was intended to work with
FlexUnit .9 alone and we modified it to work with both projects.
>It is important to verify that the copyright license text is not MPL.
It's a BSD-2 header.
Mike
>Are we talking about a single file here?
>https://github.com/apache/flex-flexunit/blob/master/FlexUnit4Test/src/UIRunner.mxml
No, we are talking about the code in the tag below:
Which resides here:
https://github.com/apache/flex-flexunit/tree/master/FlexUnit4UIListener
It was originally writ
>BTW, a key motivating factor in creating a set of FlexUnit tests is to try to
>conform to that government standard you told me about. Do you have a 5
>sentence summary of what a test suite needs to cover? Is it measured purely
>by code coverage or do you have to have boundary tests, negative
>FlexJS will keep metadata on the JS side, probably as simple properties on the
>classes and/or functions. I imagine we'll write a library that abstracts the
>fetching of metadata and returns it as an array of strings or maybe as JSON.
>If we could easily retrofit the metadata fetching in Flex
>I'd like Labriola to verify that DP should be in the NOTICE and whether anyone
>else like Adobe should also be in there.
I will make time to review but may have some questions as I feel a bit
mal-informed on procedure on these fronts.
Members of Adobe Consulting did write and donate the UIRunn
>OK, I didn't see any non-Flex apps around the runners. The deal is the mx and
>Spark apps can't wrap the runners and load in FlexJS classes at the same time.
> I think I'll just have to replace the Spark app with a FlexJS app.
No problem. We even got FlexUnit working in Flash pro at one point.
>BTW, was one of the enhancements automated test generation? Maybe from
>metadata on the class?
There was a bigger project on that, yes, although we didn't get particularly
far before the Apache switch so most of it was put on hold. Also, Flash Builder
would create stubs for you based on the c
Piotr,
>For ex: http://bit.ly/1jjjhJ8
>They do not have any tags [Test] above the methods and so on.
These should still be able to be run through FlexUnit 4.x FlexUnit 4
understands how to run FlexUnit 4.x, FlexUnit 1.x and Fluint 1.x tests.
However, it may still be worthwhile to update them s
major pieces
fit together.
Mike
-Original Message-
From: Michael A. Labriola [mailto:labri...@digitalprimates.net]
Sent: Sunday, March 23, 2014 11:57 AM
To: dev@flex.apache.org
Subject: FlexUnit was Unit tests in TLF
I put together a presentation years ago on FlexUnit for contributors
>Should there be mention of how to swap out Flash Builder's flexunit for this
>one in the readme?
Side not on this. The way to swamp out Flash Builder's version is convoluted.
Good reference:
http://probertson.com/articles/2011/05/03/flash-builder-4-5-tip-use-a-custom-flexunit-sdk/
As Paul ind
I put together a presentation years ago on FlexUnit for contributors that
explained the architecture. I will find it and get that posted somewhere.
Additionally, if anyone is interested, I would be happy to do a session
sometime on the internals of it as well as talk about what was in the future
>I found when trying to get FlexUnit to work with FlexJS that there is some
>work needed there as well since the FlexUnit demos use mx or Spark
>applications around the runners.
Alex, this isn't completely true and I can help you with it. The runner itself
is entirely AS only, no Flex depende
>Question is what should we do with this ? Should we change it to FlexUnit ?
That is more commonly known as FlexUnit 1. FlexUnit 4 should already run those
tests internally.
>More over I think library was modified in some way for TLF tests purposes. for
>ex: Couple of properties from TestCase
>What does UIListener do and why does it require embedded fonts?
Our good friends at Adobe Consulting wrote and contributed it many moons ago.
It just provides a user interface of test progress. It could certainly be
tweaked to not use those fonts and instead just use the system defaults.
Mike
>Open a JIRA ticket at https://issues.apache.org/jira/secure/Dashboard.jspa
>for the Infrastructure project. Tell them what you want to do and we'll see
>what happens.
Thanks.
I will give it a whirl,
Mike
> Labriola or some other FlexUnit expert can tell us if they are for
> required features?
I will do my best to monitor this thread. I think all relevant issues have been
discussed in threads before but, if for any reason, you are waiting on a
response here from me or need technical info and don
>Mike, I'm pretty sure in past threads I've asked you to work with Infra
>directly by filing a JIRA. Can you do that? I >think it would go more
>smoothly if you worked directly with them.
Please feel free to send me that thread. I was fairly certain you were
discussing this with infra.
I kno
>What need to be done to complete the donation of Flex Unit.
Yes, it just needs a release.
Other outstanding issues on FlexUnit which I don't have answers too... just in
case anyone cares to help:
1) The FlexUnit.org domain name. I am willing to pay for 10 years and point it
to Apache servers
Going to check one last time before I just down this but I would like to take
down the FlexUnit github repo. People continue to comment and attempt to work
there and are frustrated because it's not active.
Any final objections or can I just do this...
Mike
Alex,
>Did you decide the content is already listed in a Grant doc? Otherwise it
>might be a good idea to do that.
Any content that I think you would actually like to have was included in the
original grant.
The rest is blog posts and fluff I don't think you need/want.
Mike
Alex,
Since this seems to have 'passed' any idea of next steps? I am happy to do the
transfer paperwork but need the destination information... i.e. who will own it
and DNS server info.
Mike
>private function updateCompositionShapes():void
> {
> for each (var controller:ContainerController in
> controller)
> controller.updateCompositionShapes();
> }
Hmm. That's fun. It will end up doing nothing. Since th
A quick reminder in case anyone has cycles:
https://issues.apache.org/jira/browse/FLEX-33490
We donated the entire FlexUnit courseware and did the work to strip the HTML
down and make it easier to add to Apache. It does still need some decisions on
final binaries, etc. If anyone finds the cycl
>>That pattern works for mx components in MX DataGrid, but Spark components do
>>not "drop-in" as item renderers.
>Oleg says he is using mx components only.
>"(we use Flex3 MX and datagrids/ADGs throughout that app, so switching to
>Flex4 DGs/ADGs is not an option)."
"Now I am able to render C
>Hi Mike do you if anything has been done to solve the external dependencies
>issue so it could be donated to FlexUnit?
Nothing has been done.
>My bad for not actually looking at the site. I just tried though and it isn't
>responding. What do you mean by "domain staying intact?" Are you saying we
>should just map flexunit.org to a brand new site on Apache hardware and not
>take any of the old content?
Probably. And if there is some
>So, were the files on flexunit.org in the original FlexUnit donation? If not,
>what is the licensing on the site content? You may need to do another
>donation.
They likely weren't but I will look back at the language I wrote in the grant.
No problem if I need to do another.
As far as the si
>BTW, Infra did say they can host flexunit.org, but they did not answer my
>question about what form the files need to be. It won't be any fun if we have
>to convert it to mdtext.
So agree.
Mike
> Execute my FlexUnit4 Tests and write the results in a log
Daniel,
For the FlexUnit question you may want to look at the build scripts that Apache
is using to build FlexUnit and run the tests itself from Jenkins.
Mike
1 - 100 of 259 matches
Mail list logo
