Re: [FlexJS]Promises

2016-11-16 Thread Harbs
It seems to me that the extern is wrong. According to MDC, the return type for all Promise methods should be of type Promise.[1] Maybe Promise should implement IThenable (and possibly ICatchable), but I think Promise should return Promise. How do we patch the js files? I could also try to make

Re: [FlexJS]Promises

2016-11-16 Thread Josh Tynjala
Based on that really strange @template tag, Object is definitely the correct response from externc. Google seems to be doing something advanced there that I'm not even sure is documented. I also don't think we want to try to parse that mess. If we want it to return IThenable or something, then we

Re: [FlexJS]Promises

2016-11-16 Thread Harbs
On Nov 16, 2016, at 11:20 PM, Alex Harui wrote: > > > On 11/16/16, 11:07 AM, "Harbs" wrote: > >> >> So you are suggesting to make it a top-level class. Right? Otherwise >> we’re not good to go. >> >> Another problem with the definition in js.swc is that then() returns an >> Object, while i

Re: AW: [FlexJS/Falcon] Build concerns

2016-11-16 Thread piotrz
Chris, I looked into this code yesterday cause I was curious whether I understand some logic quickly, but without to much luck. I don't have setup which allow me debug compiler etc. I think it will be better if you fix this issue. I would like to move forward with some help on FlexJS sight. I fi

Re: [FlexJS]Promises

2016-11-16 Thread Alex Harui
On 11/16/16, 11:07 AM, "Harbs" wrote: > >So you are suggesting to make it a top-level class. Right? Otherwise >we’re not good to go. > >Another problem with the definition in js.swc is that then() returns an >Object, while it should really return a Thenable. I don’t think Thenable >is defined a

Re: [FlexJS] how to set an id in html tag

2016-11-16 Thread Alex Harui
Sounds good to me. I will look into the mxmlID property at some point that won't be reflected into the element. -Alex On 11/16/16, 11:29 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi Alex, > >I introduced in HTML UIBase.as set id method this: > > >COMPILE::JS

Re: FlexJS] ComboBox Broken in JS

2016-11-16 Thread Peter Ent
Thanks. I found the cause of the problem: when the list is to be re-displayed, the elements in the list are supposed to be removed, but they are not and so the number of items in the drop list keeps growing with each appearance. The items aren't repeated, just blank slots are appearing. The element

Re: [FlexJS] how to set an id in html tag

2016-11-16 Thread Carlos Rovira
Hi Alex, I introduced in HTML UIBase.as set id method this: COMPILE::JS { element.id = _id; } so for HTML elements if we set the id in mxml we'll get the same in HTML. I think this works ok, unless you think is not the best way to handle it l

Re: FlexJS] ComboBox Broken in JS

2016-11-16 Thread yishayw
If you run this test app. https://paste.apache.org/D1Ct You'll see there are problems with DropDownList as well. Basically, the drop down menu doesn't show. However, it's not related to the original bug, as far as I can tell. -- View this message in context: http://apache-flex-development.2

Re: [FlexJS]Promises

2016-11-16 Thread Harbs
I did not realize there was already a Promise implementation. Cool! It does need catch(), but otherwise it seems pretty complete. > Please create an HTTPServiceWithPromises instead. Fine. > There is a Promise class in js.swc in the global package. If you > implement a SWF side for it you shou

Re: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Alex Harui
On 11/16/16, 10:33 AM, "Yishay Weiss" wrote: >That’s basically what happens. I decided to separate the collapse >mechanism from the view, thinking that it’s an isolated enough concern to >warrant a separate bead. The default implementation uses CollapseBead, >which does not depend on Effects.

RE: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Yishay Weiss
That’s basically what happens. I decided to separate the collapse mechanism from the view, thinking that it’s an isolated enough concern to warrant a separate bead. The default implementation uses CollapseBead, which does not depend on Effects. >IOW, the basic implementations should not assume

Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Alex Harui
On 11/16/16, 10:23 AM, "Yishay Weiss" wrote: >Basically, it comes down to whether HTML dependes on Effects or the other >way around. I guess I can reverse it, but that would mean Effects will >have a new dependency. I’ll try not to mess up Jenkins’ build this time. Ah, I thought Effects alread

RE: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Yishay Weiss
Basically, it comes down to whether HTML dependes on Effects or the other way around. I guess I can reverse it, but that would mean Effects will have a new dependency. I’ll try not to mess up Jenkins’ build this time. From: Alex Harui Sent: Wednesday, November 16, 2016

RE: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Yishay Weiss
Hi Alex, Accordion, as I wrote it, will not function properly without some mechanism for collapsing items. This code calls get accordionCollapseBead() which searches for beads that implement ICollapseBead, either in the beads collection or in CSS. It’s similar to the way UIBase initializes mo

Re: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Alex Harui
On 11/16/16, 10:06 AM, "Yishay Weiss" wrote: >Hi Alex, > > > >Accordion, as I wrote it, will not function properly without some >mechanism for collapsing items. This code calls get >accordionCollapseBead() which searches for beads that implement >ICollapseBead, either in the beads collection or

Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Alex Harui
On 11/16/16, 9:46 AM, "Yishay Weiss" wrote: >I agree, and don’t mind reversing that. The question is where would that >bead exist. The only dependency one Effects in HTML now, is in the form >of an optional bead that depends on HTML and Effects, namely >EasyAccordionCollapseBead. Where do you

RE: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Yishay Weiss
I agree, and don’t mind reversing that. The question is where would that bead exist. The only dependency one Effects in HTML now, is in the form of an optional bead that depends on HTML and Effects, namely EasyAccordionCollapseBead. Where do you propose to put it? From: Alex Harui

Re: FlexJS] ComboBox Broken in JS

2016-11-16 Thread Alex Harui
On 11/16/16, 7:07 AM, "Peter Ent" wrote: >Thanks. I am looking into this today. Any luck trying this with >DropdownList? I'm wondering if we need both controls. Combobox has editable "display" so it can handle entries not in the data provider. It isn't a built-in HTML control though. -Alex

Re: Keeping in mind that there's a Maven build ...

2016-11-16 Thread Alex Harui
On 11/16/16, 4:45 AM, "Christofer Dutz" wrote: >Hi, > >I know ... I saw the failure and was waiting for some time, if there were >fixes comming in, but I didn’t notice any tries to fix the buid, so I >fixed it. I thought it wasn’t noticed, because I always immediately fix a >broken build, as so

Re: [FlexJS]Promises

2016-11-16 Thread Alex Harui
On 11/16/16, 1:52 AM, "Harbs" wrote: >In my attempt to port my Adobe InDesign flash panels to FlexJS, it became >clear to me very quickly that Promises is critical for a normal flow of >code. > >I needed to convert a synchronous flow of code to an asynchronous one and >Promises is a very import

Re: [FlexJS] Building from Flash Builder

2016-11-16 Thread Alex Harui
On 11/16/16, 12:56 AM, "yishayw" wrote: >This is the console output. > >https://paste.apache.org/ET6T > >The problem is probably with this line > >-sdk-js-lib=C:\dev\flexjs\flex-sdk\frameworks\js\FlexJS\generated-sources > >It looks like it's relative to FLEX_HOME which is the classic SDK. Also

Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Alex Harui
Hi Yishay, Why should HTML components be dependent on Effects? IMO, basic components should not presume the existence of any effects/animation subsystem. In theory, HTML components might dispatch events that beads can watch and run effects if requested. -Alex On 11/16/16, 2:20 AM, "yish...@apa

Re: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Alex Harui
On 11/15/16, 11:58 PM, "yish...@apache.org" wrote: > override public function addedToParent():void > { > super.addedToParent(); >+ accordionCollapseBead; // make sure it's initialized > if (selectedInde

Re: FlexJS] ComboBox Broken in JS

2016-11-16 Thread Peter Ent
Thanks. I am looking into this today. Any luck trying this with DropdownList? I'm wondering if we need both controls. ‹peter On 11/16/16, 12:08 AM, "yishayw" wrote: >Added info in bug report. Thanks. > > > >-- >View this message in context: >http://apache-flex-development.247.n4.nabble.com/

Re: [FlexJS]Promises

2016-11-16 Thread Josh Tynjala
And here's the source for the Promise class in the Flex SDK: https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=blob;f=frameworks/projects/apache/src/org/apache/flex/promises/Promise.as;h=ef39926e03bc9c58a0b41d2d0e00c539659fd752;hb=HEAD I think it may need some updates to support stuff like

Re: AW: [FlexJS/Falcon] Build concerns

2016-11-16 Thread Christofer Dutz
I had a look at the problem, thanks for finding this one ☺ It only happens on windows machines, if the maven local repo is on a different drive as the project you are compiling. I had a „lastIndexOf“ in the code, which is absolutely valid on non-windows machines. On Windows machines it cuts off

Re: Keeping in mind that there's a Maven build ...

2016-11-16 Thread Christofer Dutz
Hi, I know ... I saw the failure and was waiting for some time, if there were fixes comming in, but I didn’t notice any tries to fix the buid, so I fixed it. I thought it wasn’t noticed, because I always immediately fix a broken build, as soon as I notice something going wrong. Well Ant could

RE: Keeping in mind that there's a Maven build ...

2016-11-16 Thread Yishay Weiss
Hi Chris, That would have been me. I was aware the jobs were failing, you just beat me to it. Thanks for fixing it. Is there a way to have both builds read the same file for determining package dependencies? I thought that was what compile-as-config.xml and compile-js-config.xml were doing

Re: AW: [FlexJS/Falcon] Build concerns

2016-11-16 Thread Christofer Dutz
Ok ... forget that last email of mine ;-) As soon as it came to the examples it failled with exactly the error you were reporting. If you want to try to fix it, go ahead ... I’ll review your changes after you did them. Otherwise I’ll try to tackle the problem. Chris Am 16.11.16, 13:11 schrie

Re: AW: [FlexJS/Falcon] Build concerns

2016-11-16 Thread Christofer Dutz
Ok so I just setup my Windows 10 VM that I could run the build on a drive other than C: and it worked perfectly. What branch are you on, if I may ask? Chris Am 15.11.16, 22:13 schrieb "piotrz" : Ok! I will try! :) It will be about my twenty first line of code in JAVA :) Never touch jav

Keeping in mind that there's a Maven build ...

2016-11-16 Thread Christofer Dutz
Hi guys, I just fixed a build problem that was causing the Maven builds to fail. It was related to some changes for which the Ant build was corrected, but not the Maven build. It is ok if you don’t know how to do things in Maven, please ask for help and do changes like this on a dedicated bran

Re: [FlexJS]Promises

2016-11-16 Thread OK
If you overlook this maybe this is helpful [1] Olaf [1] https://cwiki.apache.org/confluence/display/FLEX/AS3+Promises+-+a+guide+and+example -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Promises-tp56515p56516.html Sent from the Apache Flex Devel

[FlexJS]Promises

2016-11-16 Thread Harbs
In my attempt to port my Adobe InDesign flash panels to FlexJS, it became clear to me very quickly that Promises is critical for a normal flow of code. I needed to convert a synchronous flow of code to an asynchronous one and Promises is a very important piece of that. For things like network, a

SWFLoader: Content cut off

2016-11-16 Thread Josef
Hi all, I have a problem with SWFLoader: With the mainTest2.swf I want to load a second swf, called external2.swf. If I resize the mainTest2, the external2 should resize, too. The content should be stretched - that does work. But if I reduce the mainTest2 to a small size, at the right side and bott

Re: [FlexJS] Building from Flash Builder

2016-11-16 Thread yishayw
This is the console output. https://paste.apache.org/ET6T The problem is probably with this line -sdk-js-lib=C:\dev\flexjs\flex-sdk\frameworks\js\FlexJS\generated-sources It looks like it's relative to FLEX_HOME which is the classic SDK. Also, generated-sources no longer exists. -- View thi