Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Justin Mclean
Hi, > [1] http://answers.yahoo.com/question/index?qid=20100313060726AAdrIS8 Not quite "would have" -> "would've" which can be misheard as "would of", you don't have the same issue with "not have" (as not've is not exactly common usage). Either way have works for me if you want to change it. Ju

[jira] [Commented] (FLEX-33544) [Not injection][TLF only]The text display as multiline when paste multiline text into single-line TLFTextField,

2013-05-13 Thread jingyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656687#comment-13656687 ] jingyuan commented on FLEX-33544: - Add our dev's comments that: "To fix this issue, we ne

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Alex Harui
On 5/13/13 8:28 PM, "OmPrakash Muppirala" wrote: > On May 13, 2013 8:25 PM, "Justin Mclean" wrote: >> >> Hi, >> >>> Shouldn't this be "...may not have been..."? >> No but change it if you want. Non US English perhaps? >> >> Justin > > I always thought that was how Australians said that :-

[jira] [Created] (FLEX-33544) [Not injection][TLF only]The text display as multiline when paste multiline text into single-line TLFTextField,

2013-05-13 Thread jingyuan (JIRA)
jingyuan created FLEX-33544: --- Summary: [Not injection][TLF only]The text display as multiline when paste multiline text into single-line TLFTextField, Key: FLEX-33544 URL: https://issues.apache.org/jira/browse/FLEX-3354

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread OmPrakash Muppirala
On May 13, 2013 8:25 PM, "Justin Mclean" wrote: > > Hi, > > > Shouldn't this be "...may not have been..."? > No but change it if you want. Non US English perhaps? > > Justin I always thought that was how Australians said that :-) Om

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Justin Mclean
Hi, > Shouldn't this be "...may not have been..."? No but change it if you want. Non US English perhaps? Justin

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Alex Harui
On 5/13/13 6:47 PM, "jmcl...@apache.org" wrote: > AdvancedDataGridBase implements IIME > > /** > * @private > + * > + * Note columns may not of been committed at this point. Shouldn't this be "...may not have been..."? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http

[jira] [Resolved] (FLEX-27293) Not able to input caret or other accented characters

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-27293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-27293. -- Resolution: Not A Problem Not an Apache Flex SDK issue. > Not able to input ca

[jira] [Updated] (FLEX-26571) errorString does not reset the validators

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-26571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-26571: - Labels: easyfix easytest (was: ) > errorString does not reset the validators > -

[jira] [Updated] (FLEX-14177) The field property of ValidationResultEvent is never set (at least for base Validator class)

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-14177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-14177: - Labels: easyfix easytest (was: ) > The field property of ValidationResultEvent is never set

[jira] [Updated] (FLEX-23735) dispatching ValidationResultEvent does not work

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-23735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-23735: - Labels: easytest (was: ) > dispatching ValidationResultEvent does not work > ---

[jira] [Resolved] (FLEX-25617) ValidationResultEvent message property throws exception (EmailValidator)

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-25617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-25617. -- Resolution: Fixed Fix Version/s: Apache Flex 4.10.0 Fixed and checked into develop.

[jira] [Resolved] (FLEX-20117) ValidationResultEvent.message getter throws exception if the evnt is of type ValidationResultEvent.VALID

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-20117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-20117. -- Resolution: Fixed Fix Version/s: Apache Flex 4.10.0 Fixed and checking into develop

[jira] [Resolved] (FLEX-21512) Exception when tabbing

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-21512. -- Resolution: Duplicate > Exception when tabbing > -- > >

[jira] [Resolved] (FLEX-21082) DataGrid height was not calculated correctly

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-21082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-21082. -- Resolution: Cannot Reproduce Fix Version/s: Apache Flex 4.10.0 Probably fixed in previou

[jira] [Resolved] (FLEX-21090) DataGrid height was not calculated correctly

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-21090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-21090. -- Resolution: Duplicate > DataGrid height was not calculated correctly >

[jira] [Updated] (FLEX-32999) A small editable AdvancedDataGrid causes error when got focus.

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-32999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-32999: - Labels: easytest (was: ) > A small editable AdvancedDataGrid causes error when got focus. >

[jira] [Updated] (FLEX-27676) Throw exception in Label for russian name "Юлия"

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-27676: - Labels: easytest (was: ) > Throw exception in Label for russian name "Юлия" > --

[jira] [Updated] (FLEX-32959) Invalid implementation of drawColumnBackground function in AdvancedDataGridBaseEx.as

2013-05-13 Thread Justin Mclean (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-32959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-32959: - Labels: easyfix (was: ) > Invalid implementation of drawColumnBackground function in > Adva

ADG and RTEs when changing columns at runtime

2013-05-13 Thread Justin Mclean
Hi, Just checked in a couple of changed that first a couple of RTE occurring in the advanced data grid when changing columns at runtime. In one case old headerInfo information was being accessed and if the new datagrid had less column than the old datagrid a RTE would occur. Probably caused mi

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Alex Harui
On 5/13/13 3:21 PM, "Justin Mclean" wrote: > Hi, > >> Have you ever used resource modules? > A few years back yes, currently no. These day I'd just compile it into the swf > unless I had to support a large number of locales. With a large number of > locales this feature can be useful. > >> I

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, > Cant we just remove it in our repo and let the mirroring process take care > of it on github? I'll give it a go but I don't think branch changes are being mirrored in github. > Can you point out some examples (with urls) of this issue? Will be easier > for Infra to find out what is going

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 2:49 PM, Justin Mclean wrote: > Hi, > > Sound good on the github changes. > > > flex-tlf: master > This also has a develop branch (in git but not in github) - shouldn't that > be the default? > > > 2. Ask Infra to clean up the 'trunk' branch from the flex-sdk GitHub > > mi

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Justin Mclean
Hi, > Have you ever used resource modules? A few years back yes, currently no. These day I'd just compile it into the swf unless I had to support a large number of locales. With a large number of locales this feature can be useful. > I found out that these tests are trying to test the "update"

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, > The second part is about pull requests, and I think that will require some > experimentation and will take longer to settle. Issue as I see them are: 1. No visibility of pull requests - we had requests sit there for months unnoticed. Ideally it should mail the mailing list when a pull reque

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, Sound good on the github changes. > flex-tlf: master This also has a develop branch (in git but not in github) - shouldn't that be the default? > 2. Ask Infra to clean up the 'trunk' branch from the flex-sdk GitHub > mirror. Also ask to remove patches branch as well (not essential). I thi

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
Here is a quick summary of what we decided in this thread: 1. Ask Infra to set the default branches for our GitHub flex repos as follows: flex-sdk: develop flex-asjs: develop flex-falcon: develop flex-utilities: master flex-tlf: master flex-external: master 2. Ask Infra to clean up the 'trunk'

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 11:45 AM, Alex Harui wrote: > > > > On 5/13/13 11:31 AM, "OmPrakash Muppirala" wrote: > > > On Mon, May 13, 2013 at 11:24 AM, Alex Harui wrote: > > > >> Can we do it in two pieces? The first part is the subject of this > email: > >> Can we get the "develop" branch as th

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 11:43 AM, Jose Barragan < jose.barra...@codeoscopic.com> wrote: > Hi Om, > > In fact in our writable repo, doesn't have any branch called trunk, but we > have one in Github, and is the default branch (this is the origin of this > thread). > That seems to an artifact from

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Alex Harui
On 5/13/13 11:31 AM, "OmPrakash Muppirala" wrote: > On Mon, May 13, 2013 at 11:24 AM, Alex Harui wrote: > >> Can we do it in two pieces? The first part is the subject of this email: >> Can we get the "develop" branch as the default and the graphs showing the >> "develop" branch activity? >

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Jose Barragan
Hi Om, In fact in our writable repo, doesn't have any branch called trunk, but we have one in Github, and is the default branch (this is the origin of this thread). -- Jose Barragan Chief Software Architect Codeoscopic Madrid C/. Infanta Mercedes, 92. Planta 5. 505. 28020 Madrid. Tel.: +34 912

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 11:24 AM, Alex Harui wrote: > Can we do it in two pieces? The first part is the subject of this email: > Can we get the "develop" branch as the default and the graphs showing the > "develop" branch activity? I guess you meant this for flex-sdk. What about the others?

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Erik de Bruin
Sounds sensible enough ;-) Just adding my voice to the consensus. EdB On Mon, May 13, 2013 at 8:24 PM, Alex Harui wrote: > Can we do it in two pieces? The first part is the subject of this email: > Can we get the "develop" branch as the default and the graphs showing the > "develop" branch a

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Alex Harui
Can we do it in two pieces? The first part is the subject of this email: Can we get the "develop" branch as the default and the graphs showing the "develop" branch activity? I guess that could also include removal of the "trunk" if that's old SVN stuff. I think we have consensus on this? The se

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 11:15 AM, Alex Harui wrote: > Om, you seem to know what needs to be done, can you make sure the required > changes get made? > > I will as soon as we arrive at consensus here. Infra requests usually take time and I want to get what we want in one go :-) Thanks, Om > >

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Alex Harui
Om, you seem to know what needs to be done, can you make sure the required changes get made? On 5/13/13 11:10 AM, "OmPrakash Muppirala" wrote: > On Mon, May 13, 2013 at 8:52 AM, Alex Harui wrote: > >> >> >> >>> Other than that we should not spend more time on this 'issue'. >>> This i

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On Mon, May 13, 2013 at 8:52 AM, Alex Harui wrote: > > > > > > >> Other than that we should not spend more time on this 'issue'. > > This is an issue because it's seen by the wider community. I agree it's > mostly > > irrelevant to active committers but it is an issue for someone who does > a pul

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On May 13, 2013 7:30 AM, "Justin Mclean" wrote: > > Hi, > > > Once again, Git != GitHub. > So we should either support it or not support it. Having a mirror in Github and not supporting it reflects badly on the project. Define 'support'. How much support does a reasonable person expect from a 'm

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Alex Harui
> >> Other than that we should not spend more time on this 'issue'. > This is an issue because it's seen by the wider community. I agree it's mostly > irrelevant to active committers but it is an issue for someone who does a pull > request and that request is ignored for several months. It an i

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Alex Harui
On 5/12/13 11:56 PM, "Justin Mclean" wrote: > Hi, > >> The tests only compile in fr_FR, then set en_US in the locale chain before >> loading a resource module containing US resources. > > Sounds like the test is incorrect to me IMO you shouldn't be able to switch to > a resource bundle that

Re: Looks like the Github mirrors are back for flex-sdk

2013-05-13 Thread Alex Harui
Doesn't Cordova have a workflow of finding pull requests on GitHub and then somehow pulling them into their Apache Git repo? IIRC, it still requires that the requestor close the pull request at the end. However, I think that's about as good as it can get for a read-only mirror. Will their workfl

AIR 3.8 beta for Apache Flex

2013-05-13 Thread Justin Mclean
Hi, I missed it but it was released a week ago: http://labs.adobe.com/downloads/air.html The 3.8 beta includes support for Apache Flex - give it a try. Thanks for supporting us Adobe. Justin

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, > Once again, Git != GitHub. So we should either support it or not support it. Having a mirror in Github and not supporting it reflects badly on the project. > We should not make any changes to our repo to accommodate GitHub. Then we shouldn't support it and remove it. Is that what you wa

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Carlos Rovira
+1 2013/5/13 OmPrakash Muppirala > On May 13, 2013 2:20 AM, "Justin Mclean" wrote: > > > > Hi, > > > > > Because those repos are svn mirroring in git/github they're not really > Git repos > > Cassandra, mavin and couchdb I believe use Git as their primary VC system > (but not 100% sure) and are

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread OmPrakash Muppirala
On May 13, 2013 2:20 AM, "Justin Mclean" wrote: > > Hi, > > > Because those repos are svn mirroring in git/github they're not really Git repos > Cassandra, mavin and couchdb I believe use Git as their primary VC system (but not 100% sure) and are not SVN mirrors. > > > in fact, if you review our f

Re: Looks like the Github mirrors are back for flex-sdk

2013-05-13 Thread OmPrakash Muppirala
On May 13, 2013 12:40 AM, "Erik de Bruin" wrote: > > I'm looking at the tutorials for handling pull requests, but they all > refer to UI elements that I don't see on GitHub when I'm logged in as > (erikdebruin)... Do we need special privileges to be able to handle > these requests on GitHub? > > E

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, > Because those repos are svn mirroring in git/github they're not really Git > repos Cassandra, mavin and couchdb I believe use Git as their primary VC system (but not 100% sure) and are not SVN mirrors. > in fact, if you review our flex-sdk repo in GitHub, you can found a trunk > branch,

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Jose Barragan
Hi, >> We've a Git repo, and master develop is the regular structure. > Then why does github assume trunk is the default and not develop? Can we get > this changed? > > Every other major Apache project I've looked at uses trunk/master for regular > updates: > https://github.com/apache/lucene-so

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, > We've a Git repo, and master develop is the regular structure. Can you point to a single other Apache project that has the same structure on github as us? Or any other project for that matter? We currently have 3 main branches in github they are master, trunk and develop which is rather

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
HI, > We've a Git repo, and master develop is the regular structure. Then why does github assume trunk is the default and not develop? Can we get this changed? Every other major Apache project I've looked at uses trunk/master for regular updates: https://github.com/apache/lucene-solr https://gi

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Erik de Bruin
Carlos, Jose, While we're on the subject, would you mind having a look at the other thread about GitHub, the one concerning the handling of pull requests? Thanks! EdB On Mon, May 13, 2013 at 9:46 AM, Carlos Rovira wrote: > Hi Justin, > > -1 to move to old "trunk" svn layout. People comming to

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Jose Barragan
-1 We've a Git repo, and master develop is the regular structure. We must avoid mixing the things, to avoid the confusion increment -- Jose Barragan Chief Software Architect Codeoscopic Madrid C/. Infanta Mercedes, 92. Planta 5. 505. 28020 Madrid. Tel.: +34 912 94 80 80 On May 13, 2013, at 9

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Carlos Rovira
Hi Justin, -1 to move to old "trunk" svn layout. People comming to this project could came from SVN or GIT background, so reverting to "trunk" while we are on GIT will be the cause of more confusion. Nowadays, people should take into account the conventions over configurations, and master/develop

Re: [Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Erik de Bruin
This almost makes me want to start another "don't you love git" thread :-P The whole idea of the git-move was to make it easier for new contributors to come aboard the project, so from that perspective it does make sense to accomodate the GitHub workflow as much as possible... EdB On Mon, May

Re: Looks like the Github mirrors are back for flex-sdk

2013-05-13 Thread Erik de Bruin
I'm looking at the tutorials for handling pull requests, but they all refer to UI elements that I don't see on GitHub when I'm logged in as (erikdebruin)... Do we need special privileges to be able to handle these requests on GitHub? EdB On Mon, May 13, 2013 at 8:56 AM, Justin Mclean wrote: >

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Justin Mclean
Hi, This article changes the locale chain after the resource bundle has loaded: http://www.adobe.com/devnet/flex/articles/flex-localization-pt2.html Do you think you should be able to change the locale chain to a non existent locale and then load it? Do we know if the SDK supports this? I seem

[Dicuss] Github stats and lack of visibility by working not working in trunk/master

2013-05-13 Thread Justin Mclean
Hi, Is there anyway to change the stats on these pages: https://github.com/apache/flex-sdk/graphs So that they work off develop not trunk. (And for the other repos as well.) It's sort of giving the wrong idea (in a public way) re activity on the project. Alternatively what do people think abou