[dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-08-19 Thread Wei Hu (Xavier)
utgoing packets") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: fix TYPO_SPELLING warning in the commit log. --- app/test-pmd/txonly.c | 32 1 file changed, 32 insertions(+) diff --git a/app/test-pmd/

[dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-08-19 Thread Wei Hu (Xavier)
1 ("app/testpmd: fix port configuration print") Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 64 +++ 1 file

[dpdk-dev] [PATCH v3 0/3] minor updates for getting queue info

2020-08-20 Thread Wei Hu (Xavier)
): net/hns3: support getting Tx and Rx queue information Wei Hu (Xavier) (2): net/hns3: report Rx drop packets enable configuration ethdev: check if queue setupped when getting queue info drivers/net/hns3/hns3_ethdev.c| 11 + drivers/net/hns3/hns3_ethdev_vf.c | 11

[dpdk-dev] [PATCH v3 2/3] net/hns3: support getting Tx and Rx queue information

2020-08-20 Thread Wei Hu (Xavier)
From: Huisong Li This patch adds support for querying Rx/Tx queue information. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 2 ++ drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ drivers/net/hns3/hns3_rxtx.c | 33

[dpdk-dev] [PATCH v3 3/3] ethdev: check if queue setupped when getting queue info

2020-08-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds checking whether the related Tx or Rx queue has been setuped in the rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API function to avoid illegal address access. Signed-off-by: Wei Hu (Xavier) --- lib/librte_ethdev/rte_eth

[dpdk-dev] [PATCH v3 1/3] net/hns3: report Rx drop packets enable configuration

2020-08-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, if there are not available Rx buffer descriptors in recieving direction based on hns3 network engine, incoming packets will always be dropped by hardware. This patch reports the '.rx_drop_en' information to DPDK framework in the '.dev_i

Re: [dpdk-dev] [PATCH V2] net/hns3: support getting Tx and Rx queue information

2020-08-20 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/8/20 0:19, Ferruh Yigit wrote: On 8/18/2020 4:07 AM, Wei Hu (Xavier) wrote: From: Huisong Li This patch adds support for querying Rx/Tx queue information. Currently, if there are not available Rx buffer descriptors in receiving direction based on hns3 network engine

[dpdk-dev] [PATCH v4 0/3] minor updates for getting queue info

2020-08-24 Thread Wei Hu (Xavier)
): net/hns3: support getting Tx and Rx queue information Wei Hu (Xavier) (2): net/hns3: report Rx drop packets enable configuration ethdev: check if queue setupped when getting queue info drivers/net/hns3/hns3_ethdev.c| 11 + drivers/net/hns3/hns3_ethdev_vf.c | 11

[dpdk-dev] [PATCH v4 3/3] ethdev: check if queue setupped when getting queue info

2020-08-24 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds checking whether the related Tx or Rx queue has been setuped in the rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API function to avoid illegal address access. Signed-off-by: Wei Hu (Xavier) --- lib/librte_ethdev/rte_eth

[dpdk-dev] [PATCH v4 1/3] net/hns3: report Rx drop packets enable configuration

2020-08-24 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, if there are not available Rx buffer descriptors in receiving direction based on hns3 network engine, incoming packets will always be dropped by hardware. This patch reports the '.rx_drop_en' information to DPDK framework in the '.dev_i

[dpdk-dev] [PATCH v4 2/3] net/hns3: support getting Tx and Rx queue information

2020-08-24 Thread Wei Hu (Xavier)
From: Huisong Li This patch adds support for querying Rx/Tx queue information. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- v3 -> v4: remove unused variable ‘hw’ in hns3_rxq_info_get and hns3_rxq_info_get function. --- drivers/net/hns3/hns3_ethdev.c|

[dpdk-dev] [PATCH 02/11] net/hns3: get dev specifications from firmware

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds getting PF/VF device specifications from firmware. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Hongbo Zheng --- drivers/net/hns3/hns3_cmd.h | 15 drivers/net/hns3/hns3_dcb.c | 1 - drivers/net/hns3/hns3_dcb.h

[dpdk-dev] [PATCH 01/11] net/hns3: get device capability from firmware

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds getting device capabilities from firmware, so driver can supply differnet cpabilities and specifications to upper level applications base on differnet versions of hardware network engine. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/

[dpdk-dev] [PATCH 00/11] updates for hns3 PMD driver

2020-08-25 Thread Wei Hu (Xavier)
This series are features and fixes for hns3 PMD driver. Huisong Li (3): net/hns3: replace private macro with RTE MAX net/hns3: fix default MAC addr from firmware net/hns3: fix some incomplete command structures Wei Hu (Xavier) (8): net/hns3: get device capability from firmware net/hns3

[dpdk-dev] [PATCH 03/11] net/hns3: compatibility issues about Rx interrupts

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" There are difference about queue's interrupt configurations for different versions of hardware network engine, such as queue's interrupt mapping mode, coalesce configuration, etc. The following uses the configuration differences of the interrup

[dpdk-dev] [PATCH 05/11] net/hns3: add more hardware error types

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The new firmware adds the hardware error types reported by MSI-x mode. These errors are defined as RAS errors in hardware and belong to a different type from the MSI-x errors processed by the driver. When hardware detects an hardware errors, which need to be ha

[dpdk-dev] [PATCH 07/11] net/hns3: replace private macro with RTE MAX

2020-08-25 Thread Wei Hu (Xavier)
From: Huisong Li This patch uses RTE_MAX function in DPDK lib to replace the private macro named max_t in hns3 PMD driver. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 5 ++--- drivers/net/hns3/hns3_ethdev.h | 5 - 2 files changed, 2

[dpdk-dev] [PATCH 04/11] net/hns3: compatibility issues about Tx padding short frame

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" There are differece about padding ultra-short frame in Tx procession for different versions of hardware network engine. If packet length is less than minimum packet length supported by hardware in Tx direction, driver need to pad it to avoid error. The mini

[dpdk-dev] [PATCH 06/11] net/hns3: support a maximun 256 FDIR counter

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The FDIR counter was used to count the number of FDIR hit, the maximum number of the counter is 128 based on kunpeng 920, and it was 256 based on kunpeng 930. The firmware is responsible to allocate counters for diffent PF devices, so the available counter num

[dpdk-dev] [PATCH 11/11] net/hns3: fix some incomplete command structures

2020-08-25 Thread Wei Hu (Xavier)
that are less than 24 byte. So this patch fixes these incomplete command structures. Fixes: 62e3ccc2b94c6 ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.h | 12 +++- 1 file c

[dpdk-dev] [PATCH 10/11] net/hns3: fix Rx/Tx queue offload capability

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" According to rte_eth_rx_queue_setup and rte_eth_tx_queue_setup API function, rx_queue_offload_capa and rx_offload_capa, tx_queue_offload_capa and tx_offload_capa must be mutually exclusive in the '.dev_infos_get' ops implementation

[dpdk-dev] [PATCH 08/11] net/hns3: change the log level to INFO

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch changes the log level from NOTICE to INFO. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethd

[dpdk-dev] [PATCH 09/11] net/hns3: fix default MAC addr from firmware

2020-08-25 Thread Wei Hu (Xavier)
ssing default MAC addr in hns3 VF PMD driver so as to increase relevance and readability of the code. Fixes: eab21776717 ("net/hns3: support setting VF MAC address by PF driver") Fixes: d51867db65c ("net/hns3: add initialization") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Sign

Re: [dpdk-dev] [PATCH v2 3/3] net/hns3: add Rx buffer size to Rx qinfo query

2020-08-26 Thread Wei Hu (Xavier)
On 2020/8/26 15:12, Chengchang Tang wrote: Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- v1 -> v2: fix some spelling mistake. --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 inserti

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx buffer size display in queue info query

2020-08-26 Thread Wei Hu (Xavier)
On 2020/8/26 15:12, Chengchang Tang wrote: Add Rx buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- v1 -> v2: fix some spelling mistake --- app/test-

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add a field for rxq info structure

2020-08-26 Thread Wei Hu (Xavier)
: Andrew Rybchenko Reviewed-by: Wei Hu (Xavier) --- v1 -> v2: fix wrong headline format --- lib/librte_ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 70295d7..9fed5cb 100644 --- a/lib/librte_eth

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-08-31 Thread Wei Hu (Xavier)
Friendly ping On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c | 39 lib

Re: [dpdk-dev] [PATCH 00/11] updates for hns3 PMD driver

2020-09-02 Thread Wei Hu (Xavier)
Hi, all    Are there any comments? Thanks Xavier On 2020/8/25 19:52, Wei Hu (Xavier) wrote: This series are features and fixes for hns3 PMD driver. Huisong Li (3): net/hns3: replace private macro with RTE MAX net/hns3: fix default MAC addr from firmware net/hns3: fix some

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-09-02 Thread Wei Hu (Xavier)
Hi, all   Are there any other comments? Thanks Xavier On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c

Re: [dpdk-dev] [PATCH v2 0/4] minor fixes for testpmd

2020-09-02 Thread Wei Hu (Xavier)
Hi, all   Are there any comment? Thanks Xavier On 2020/8/20 9:42, Wei Hu (Xavier) wrote: This series are minor fixes for testpmd application. Chengchang Tang (3): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app

Re: [dpdk-dev] [PATCH] net/hns3: fix out-of-bounds access

2020-09-06 Thread Wei Hu (Xavier)
On 2020/9/7 9:46, wangyunjian wrote: From: Yunjian Wang This patch fixes (out-of-bounds access) coverity issue. Coverity issue: 349932 Fixes: 7d7f9f80bbfb ("net/hns3: support MAC address related operations") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Wei

[dpdk-dev] [PATCH 2/8] net/hns3: reduce address calculation in Rx

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds the internal function named hns3_write_reg_opt to avoid performance loss from address calculation during register access in the '.rx_pkt_burst' ops implementation function named hns3_recv_pkts. In addition, because hardware alway

[dpdk-dev] [PATCH 5/8] net/hns3: add vector Tx burst with NEON instructions

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds NEON vector instructions to optimize Tx burst process. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- config/common_base| 1 + config/common_linux | 1 + d

[dpdk-dev] [PATCH 0/8] net/hns3: updates for Rx Tx

2020-09-07 Thread Wei Hu (Xavier)
This series are updates for Rx/Tx process. Chengchang Tang (1): net/hns3: fix segfault when Tx multiple buffer packets Wei Hu (Xavier) (7): net/hns3: report Rx free threshold net/hns3: reduce address calculation in Rx net/hns3: add simple Rx process function net/hns3: add simple Tx

[dpdk-dev] [PATCH 1/8] net/hns3: report Rx free threshold

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch reports .rx_free_thresh value in the .dev_infos_get ops implementation function named hns3_dev_infos_get and hns3vf_dev_infos_get. In addition, the name of the member variable of struct hns3_rx_queue is modified and comments are added to im

[dpdk-dev] [PATCH 3/8] net/hns3: add simple Rx process function

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds simple Rx process function and support chose Rx function by real Rx offloads capability. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ethdev.c| 7 +- driver

[dpdk-dev] [PATCH 6/8] net/hns3: add vector Rx burst with NEON instructions

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds NEON vector instructions to optimize Rx burst process. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 1 + d

[dpdk-dev] [PATCH 4/8] net/hns3: add simple Tx process function

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds simple Tx process function. When multiple segment packets are not needed, Which means that DEV_TX_OFFLOAD_MBUF_FAST_FREE offload is not set, we can simple Tx process. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Signed-off-by: Che

[dpdk-dev] [PATCH 8/8] net/hns3: fix segfault when Tx multiple buffer packets

2020-09-07 Thread Wei Hu (Xavier)
med hns3_reassemble_tx_pkts is optimized to avoid a similar problem. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns

[dpdk-dev] [PATCH 7/8] net/hns3: add restriction on setting VF MTU

2020-09-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" when Rx of scattered packets is off, we have some possibility of using vector Rx process function or simple Rx functions in hns3 PMD driver. If the input MTU is increased and the maximum length of received packets is greater than the length of a buffer for Rx pa

Re: [dpdk-dev] [PATCH 08/11] net/hns3: change the log level to INFO

2020-09-07 Thread Wei Hu (Xavier)
Hi,Ferruh Yigit On 2020/9/4 18:34, Ferruh Yigit wrote: On 8/25/2020 12:53 PM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" This patch changes the log level from NOTICE to INFO. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH 08/11] net/hns3: change the log level to INFO

2020-09-07 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/7 20:10, Ferruh Yigit wrote: On 9/7/2020 12:34 PM, Wei Hu (Xavier) wrote: Hi,Ferruh Yigit On 2020/9/4 18:34, Ferruh Yigit wrote: On 8/25/2020 12:53 PM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" This patch changes the log level from NOTICE to INF

[dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB

2020-09-07 Thread Wei Hu (Xavier)
PMD driver cannot test the flow table feature when multiple TCs are enabled. Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/testpmd.c | 1 + 1 file changed,

[dpdk-dev] [PATCH 0/2] updates for testpmd

2020-09-07 Thread Wei Hu (Xavier)
This series are minor updates for testpmd application. Huisong Li (2): app/testpmd: update Rx RSS HASH offload when setting MQ RSS app/testpmd: retain original FDIR mode when configuring DCB app/test-pmd/testpmd.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.9.5

[dpdk-dev] [PATCH 1/2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS

2020-09-07 Thread Wei Hu (Xavier)
rivers. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/testpmd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7842c3b..73543bb 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/te

Re: [dpdk-dev] [PATCH 10/11] net/hns3: fix Rx/Tx queue offload capability

2020-09-08 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/4 18:34, Ferruh Yigit wrote: On 8/25/2020 12:53 PM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" According to rte_eth_rx_queue_setup and rte_eth_tx_queue_setup API function, rx_queue_offload_capa and rx_offload_capa, tx_queue_offload_capa and tx_offload

[dpdk-dev] [PATCH v2] net/hns3: fix Rx/Tx queue offload capability

2020-09-08 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, offload capabilities are only enabled for all Rx/Tx queues in hns3 PF/VF PMD driver, and offload capability only applied in a Rx/Tx queue is not supported. So this patch moves 'DEV_TX_OFFLOAD_MBUF_FAST_FREE' from tx_queue_offload_capa to tx_

[dpdk-dev] [PATCH v2 0/8] net/hns3: updates for Rx Tx

2020-09-09 Thread Wei Hu (Xavier)
This series are updates for Rx/Tx process. Chengchang Tang (1): net/hns3: fix segfault when Tx multiple buffer packets Wei Hu (Xavier) (7): net/hns3: report Rx free threshold net/hns3: reduce address calculation in Rx net/hns3: add simple Rx process function net/hns3: add simple Tx

[dpdk-dev] [PATCH v2 1/8] net/hns3: report Rx free threshold

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch reports .rx_free_thresh value in the .dev_infos_get ops implementation function named hns3_dev_infos_get and hns3vf_dev_infos_get. In addition, the name of the member variable of struct hns3_rx_queue is modified and comments are added to im

[dpdk-dev] [PATCH v2 3/8] net/hns3: add simple Rx process function

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds simple Rx process function and support chose Rx function by real Rx offloads capability. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ethdev.c| 7 +- driver

[dpdk-dev] [PATCH v2 2/8] net/hns3: reduce address calculation in Rx

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds the internal function named hns3_write_reg_opt to avoid performance loss from address calculation during register access in the '.rx_pkt_burst' ops implementation function named hns3_recv_pkts. In addition, because hardware alway

[dpdk-dev] [PATCH v2 6/8] net/hns3: add vector Rx burst with NEON instructions

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds NEON vector instructions to optimize Rx burst process. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 1 + d

[dpdk-dev] [PATCH v2 4/8] net/hns3: add simple Tx process function

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds simple Tx process function. When multiple segment packets are not needed, Which means that DEV_TX_OFFLOAD_MBUF_FAST_FREE offload is not set, we can simple Tx process. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Signed-off-by: Che

[dpdk-dev] [PATCH v2 5/8] net/hns3: add vector Tx burst with NEON instructions

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds NEON vector instructions to optimize Tx burst process. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- v1 -> v2: modification about meson.build for hns3_rxtx_vec.c file. --- drivers/net/hns3/

[dpdk-dev] [PATCH v2 8/8] net/hns3: fix segfault when Tx multiple buffer packets

2020-09-09 Thread Wei Hu (Xavier)
med hns3_reassemble_tx_pkts is optimized to avoid a similar problem. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns

[dpdk-dev] [PATCH v2 7/8] net/hns3: add restriction on setting VF MTU

2020-09-09 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" when Rx of scattered packets is off, we have some possibility of using vector Rx process function or simple Rx functions in hns3 PMD driver. If the input MTU is increased and the maximum length of received packets is greater than the length of a buffer for Rx pa

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-09-13 Thread Wei Hu (Xavier)
Hi, all   Are there any other comments? Thanks Xavier On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-09-16 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/15 0:31, Ferruh Yigit wrote: On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "por

[dpdk-dev] [PATCH v3 2/6] app/testpmd: fix VLAN offload configuration when config fail

2020-09-19 Thread Wei Hu (Xavier)
. This patch makes the function return directly insead of refreshing the configuration when execution fails. Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Fe

[dpdk-dev] [PATCH v3 0/6] minor fixes for testpmd

2020-09-19 Thread Wei Hu (Xavier)
This series are minor fixes for testpmd application. Chengchang Tang (5): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpmd: remove restriction on txpkts set app/testpmd: fix packet header in txonly mode app/testpmd:

[dpdk-dev] [PATCH v3 1/6] app/testpmd: fix missing verification of port id

2020-09-19 Thread Wei Hu (Xavier)
member of non-existent port. This patch adds verification of port id in tx vlan offloads and remove duplicated check. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v1 -> v

[dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-19 Thread Wei Hu (Xavier)
.@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 42 ++ 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 4e33208..882de2d 100644 --- a/ap

[dpdk-dev] [PATCH v3 6/6] app/testpmd: fix displaying Rx Tx queues information

2020-09-19 Thread Wei Hu (Xavier)
1 ("app/testpmd: fix port configuration print") Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 64 +++

[dpdk-dev] [PATCH v3 4/6] app/testpmd: fix packet header in txonly mode

2020-09-19 Thread Wei Hu (Xavier)
32b7 ("app/testpmd: add ability to split outgoing packets") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/txonly.c | 32 1 file changed, 32 insertions(+) diff --git a/app/test-pmd/txonly.c b/app/tes

[dpdk-dev] [PATCH v3 5/6] app/testpmd: fix valid desc id check

2020-09-19 Thread Wei Hu (Xavier)
use a default value to confiure the queue if nb_rx_desc or nb_tx_desc is zero. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 53 +-

[dpdk-dev] [PATCH 04/17] net/hns3: add max number of segs compatibility

2020-09-22 Thread Wei Hu (Xavier)
: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_ethdev.c| 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- drivers/net/hns3/hns3_rxtx.c | 30 -- drivers/net/hns3/hns3_rxtx.h | 1 + 4 files changed

[dpdk-dev] [PATCH 03/17] net/hns3: add default branch to switch in Rx VLAN processing

2020-09-22 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch solves the static check warning as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff

[dpdk-dev] [PATCH 02/17] net/hns3: fix default VLAN won't be deleted when set PF PVID

2020-09-22 Thread Wei Hu (Xavier)
from the hardware VLAN table when device is closed. Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 95 +++--- 1 file changed, 43

[dpdk-dev] [PATCH 00/17] updates for hns3 PMD driver

2020-09-22 Thread Wei Hu (Xavier)
hash type input configuration net/hns3: fix config when creating RSS rule after flush net/hns3: fix flushing RSS rule Wei Hu (Xavier) (6): net/hns3: add VLAN configuration compatibility net/hns3: add TSO pseudo header calculation compatibility net/hns3: add default branch to switch when pa

[dpdk-dev] [PATCH 01/17] net/hns3: add VLAN configuration compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Because of hardware limitation based on the old version of hns3 network engine, there are some restrictions: a) HNS3 PMD driver needs select different processing mode for VLAN based on whether PVID is set which means our driver need sense the PVID stat

[dpdk-dev] [PATCH 08/17] net/hns3: add break to exit loop when err stat item found

2020-09-22 Thread Wei Hu (Xavier)
statistical item without traversing the remaining table entries. Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_stats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c index 067673c..e8846b9 100644

[dpdk-dev] [PATCH 06/17] net/hns3: avoid accessing nonexistent VF reg when PF in FLR

2020-09-22 Thread Wei Hu (Xavier)
to be processed by PMD driver. Fixes: 2790c6464725 ("net/hns3: support device reset") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.h| 7 +++ drivers/net/hns3/hns3_ethdev_vf.c | 15 +++ 2 files changed

[dpdk-dev] [PATCH 05/17] net/hns3: add TSO pseudo header calculation compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" In kunpeng 920, when process pkts which need TSO, the network driver need to erase the L4 len value of the TCP TSO pseudo header and recalculate the pseudo header checksum. kunpeng930 support not need to erase the L4 len value of the TCP TSO pseudo header. Sig

[dpdk-dev] [PATCH 11/17] net/hns3: check input RSS type when creating flow with RSS

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch adds checking the input RSS type when creating a flow with RSS. If the input RSS type are not supported based on hns3 network engine, an error is returned. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 26

[dpdk-dev] [PATCH 07/17] net/hns3: add default branch to switch when parsing fd tuple

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch solves the static check warning in the internal function named hns3_fd_convert_tuple as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- dr

[dpdk-dev] [PATCH 12/17] net/hns3: set RSS hash type input configuration

2020-09-22 Thread Wei Hu (Xavier)
jun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h| 9 +- drivers/net/hns3/hns3_ethdev.h | 2 + drivers/net/hns3/hns3_rss.c| 244 +++-- drivers/net/hns3/hns3_rss.h| 20 +--- 4 files changed, 197 insertions(+), 78 deletions(-)

[dpdk-dev] [PATCH 10/17] net/hns3: support querying RSS flow rule

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch enables to query some RSS configurations of the specified rule. For example, show RSS hash function and rss types. Signed-off-by: Lijun Ou Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 23 --- 1

[dpdk-dev] [PATCH 09/17] net/hns3: support flow action of queue region

2020-09-22 Thread Wei Hu (Xavier)
_END after calling rte_flow_create, one FDIR rule will be created. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.c| 5 +- drivers/net/hns3/hns3_cmd.h| 2 +- drivers/net/hns3/hns3_ethdev.h | 8 +-- drivers/net/hns3/hns3_fdir.c | 35 +++-

[dpdk-dev] [PATCH 13/17] net/hns3: fix config when creating RSS rule after flush

2020-09-22 Thread Wei Hu (Xavier)
parameters in the hardware is unavailable. Also we set hw->rss_info.func to RTE_ETH_HASH_FUNCTION_MAX that indicate it is invalid. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- driver

[dpdk-dev] [PATCH 15/17] net/hns3: fix flushing RSS rule

2020-09-22 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 79 drivers/net/hns3/hns3_rss.h | 1 + 2 files changed, 58 insertions(+), 22 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 5b5124c..4f078e8

[dpdk-dev] [PATCH 17/17] net/hns3: fix storing RSS info when creating flow action

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. The root cause is that when application call the rte_flow_create API function to create RSS action, the operation of storin

[dpdk-dev] [PATCH 14/17] net/hns3: fix flow RSS queue num with 0

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When user specifies RSS queue num for 0 in action list by flow create API, it should create a valid flow rule. The following flow rule should be success in the command line of the testpmd application: flow create 0 actions rss queues / end Fixes: c37ca66f

[dpdk-dev] [PATCH 16/17] net/hns3: fix configuring device with RSS is enabled

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running the following commands in the CLI of testpmd application, the driver reports an -EINVAL error when performing the No.3 step. 1) flow create 0 ingress pattern end actions rss key func simple_xor types all end / end 2) flow flush

<    1   2   3   4   5   6