[dpdk-dev] [PATCH v6 0/2] ethdev: minor bugfixes

2020-07-06 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 12 +++- drivers/net/enic/enic_ethdev.c

Re: [dpdk-dev] [PATCH v6 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-07 Thread Wei Hu (Xavier)
Hi, Thomas Monjalon On 2020/7/7 22:11, Thomas Monjalon wrote: 06/07/2020 09:06, Wei Hu (Xavier): Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not

Re: [dpdk-dev] [PATCH v6 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-07 Thread Wei Hu (Xavier)
objects. Thanks, Xavier On 2020/7/7 21:38, Slava Ovsiienko wrote: Acked-by: Viacheslav Ovsiienko -Original Message- From: dev On Behalf Of Jeff Guo Sent: Tuesday, July 7, 2020 10:36 To: Wei Hu (Xavier) ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 2/2] ethdev: fix VLAN offloads s

Re: [dpdk-dev] [PATCH v2] net/bonding: change the state machine to defaulted

2020-07-08 Thread Wei Hu (Xavier)
Hi, Weifeng Li On 2020/7/7 22:38, Weifeng Li wrote: From: Weifeng Li A dpdk bonding 802.3ad network as follows: +--+ +---+ |dpdk lacp |slave1 <--> port1|switch lacp| | |slave2 <--> port2| | +--+ +--

Re: [dpdk-dev] [PATCH v6 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-09 Thread Wei Hu (Xavier)
On 2020/7/8 18:14, Thomas Monjalon wrote: 08/07/2020 05:37, Wei Hu (Xavier): On 2020/7/7 22:11, Thomas Monjalon wrote: 06/07/2020 09:06, Wei Hu (Xavier): Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which

[dpdk-dev] [PATCH v7 0/2] ethdev: minor bugfixes

2020-07-09 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 12 +++- drivers/net/enic/enic_ethdev.c

[dpdk-dev] [PATCH v7 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-09 Thread Wei Hu (Xavier)
le QinQ strip") Fixes: d4a27a3b092a ("nfp: add basic features") Fixes: 56139e85abec ("net/octeontx: support VLAN filter offload") Fixes: ba1b3b081edf ("net/octeontx2: support VLAN offloads") Fixes: d87246a43759 ("net/qede: enable and disable VLAN filtering&qu

[dpdk-dev] [PATCH v7 1/2] ethdev: fix data room size verification in Rx queue setup

2020-07-09 Thread Wei Hu (Xavier)
varibale named mbp_buf_size is bigger than RTE_PKTMBUF_HEADROOM. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Andrew Rybchenko Acked-by: Sachin Saxena Acked-by: Viacheslav Ovsiienko --- v2

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix MAC address when one port resets

2020-04-16 Thread Wei Hu (Xavier)
s, and then network engine will be able to work normally again. During the hardware reset, the command sending to firmware will timeout. We probably shouldn't allow you to bond devices that don't support setting MAC address. I don't think this check exists currently. T

[dpdk-dev] [PATCH v2 1/2] net/bonding: fix MAC address when switching active port

2020-04-17 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, when the link status of the primary port changes from up to down, one slave port changes to the primary port, but the new primary port's MAC address cannot change to the bond device's MAC address. A

[dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-04-17 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, in the following 2 cases: 1) The primary port resets. The link status of the primary port changes from up to down. 2) When switching the active port, one slave port resets at the same time. one slave port chan

[dpdk-dev] [PATCH v2 0/2] fixes for bonding

2020-04-17 Thread Wei Hu (Xavier)
This series include two fixes patches for bonding PMD driver. Wei Hu (Xavier) (2): net/bonding: fix MAC address when switching active port net/bonding: fix MAC address when one port resets drivers/net/bonding/rte_eth_bond_api.c | 1 + drivers/net/bonding/rte_eth_bond_pmd.c | 10

Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-04-17 Thread Wei Hu (Xavier)
Hi, Chas Williams Thanks for your comments on Patch V1. now we have sent Patch V2. Could you please give some suggestion on them? Thanks. Best Regards Xavier On 2020/4/17 16:19, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, based on a active-backup bond devi

[dpdk-dev] [PATCH] lib/rte_eal: fix heap-use-after-free bug

2020-04-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch fixes the heap-use-after-free bug which was found by ASAN (Address-Sanitizer) in the vfio_get_default_container_fd function. Fixes: 6bcb7c95fe14 ("vfio: share default container in multi-process") Cc: sta...@dpdk.org Signed-off-by: Chengwen

[dpdk-dev] [PATCH 1/2] net/hns3: modify the format for firmware version

2020-04-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch modifies the print format for firmware version in the log, It replaces "0x%08x" with "%lu.%lu.%lu.%lu" in the format control string. By the way, this patch adds ".fw_version_get" ops implemation for hns3 VF PM

[dpdk-dev] [PATCH 0/2] updates for hns3 PMD driver

2020-04-20 Thread Wei Hu (Xavier)
This series are updates for hns3 PMD driver. Chengwen Feng (1): net/hns3: get Rx/Tx queue fbd in extend device statistics Wei Hu (Xavier) (1): net/hns3: modify the format for firmware version drivers/net/hns3/hns3_cmd.c | 14 ++- drivers/net/hns3/hns3_cmd.h | 8 ++ drivers

[dpdk-dev] [PATCH 2/2] net/hns3: get Rx/Tx queue fbd in extend device statistics

2020-04-20 Thread Wei Hu (Xavier)
information in testpmd applcation by using the command "show port xstats" as below: rx_q0RX_QUEUE_FBD: 19 rx_q1RX_QUEUE_FBD: 18 tx_q0TX_QUEUE_FBD: 0 tx_q1TX_QUEUE_FBD: 0 Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_sta

[dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-24 Thread Wei Hu (Xavier)
fixes it by clearing last port statistics when executing "clear stats/xstats" command. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 11 +++ 1 file changed, 11

[dpdk-dev] [PATCH V2] app/testpmd: fix forward stats after clear stats command

2020-04-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect forward Rx/Tx-packets stats as below: -- Forward statistics for port 0 -- RX-packets: 184467440

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-25 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/4/25 0:12, Ferruh Yigit wrote: On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: From: Chengwen Feng Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect RX/TX-packets stats as b

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-26 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/4/25 0:12, Ferruh Yigit wrote: On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: From: Chengwen Feng Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect RX/TX-packets stats as b

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-28 Thread Wei Hu (Xavier)
Hi, Ferrh Yigit On 2020/4/27 22:00, Ferruh Yigit wrote: On 4/26/2020 10:22 AM, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/4/25 0:12, Ferruh Yigit wrote: On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: From: Chengwen Feng Currently, when running start/clear stats&xstats/stop com

[dpdk-dev] [PATCH V2] app/testpmd: fix forward stats after clear stats command

2020-04-28 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect forward Rx/Tx-packets stats as below: -- Forward statistics for port 0 -- RX-packets: 184467440

[dpdk-dev] [PATCH V3] app/testpmd: fix forward stats after clear stats command

2020-04-28 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running start/clear stats&xstats/stop command many times based on testpmd application, there are incorrect forward Rx/Tx-packets stats as below: -- Forward statistics for port 0 -- RX-packets: 184467440

[dpdk-dev] [PATCH 0/6] misc updates and bugfixes for hns3 PMD driver

2020-04-29 Thread Wei Hu (Xavier)
This series are misc updates and bugfixes for hns3 PMD driver. Lijun Ou (1): net/hns3: print the detail ret value Min Hu (Connor) (1): net/hns3: fix VLAN pvid when configuring device Wei Hu (Xavier) (4): net/hns3: get Tx abnormal errors in extend device statistics net/hns3: get PCI

[dpdk-dev] [PATCH 3/6] net/hns3: get PCI revision id

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The hns3 network engine is built-in multiple SoCs, such as kunpeng 920, kunpeng 930, etc. The PCI revision id is 0x21 in kunpeng 920, and the PCI revision id is 0x30 in kunpeng 930. This patch gets PCI revison to identify different version of hardware netw

[dpdk-dev] [PATCH 1/6] net/hns3: get Tx abnormal errors in extend device statistics

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When upper level application calls the rte_eth_tx_burst API function to send multiple packets at a time with burst mode based on hns3 network engine, there are some abnormal conditions that cause the driver to fail to operate the hardware to send packets correc

[dpdk-dev] [PATCH 2/6] net/hns3: print the detail ret value

2020-04-29 Thread Wei Hu (Xavier)
From: Lijun Ou Here adds some prints for return value when the relative function fails and enter the exception branch. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c| 7 +-- drivers/net/hns3/hns3_ethdev.c | 4 ++-- drivers/net/hns3

[dpdk-dev] [PATCH 6/6] net/hns3: fix return value when clearing statistics fails

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Since the return value of the '.stats_reset' and '.xstats_reset' callback function is int, when failing to issue command to firmware to execute clear statistics, the relevant callback function should return non-zero value. Fixes: 8839c5e20

[dpdk-dev] [PATCH 4/6] net/hns3: fix VLAN pvid when configuring device

2020-04-29 Thread Wei Hu (Xavier)
uration to hardware when pvid config is not set in rte_eth_conf. Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_ethdev.c | 7 +++ 1 file changed, 7

[dpdk-dev] [PATCH 5/6] net/hns3: fix MSI-x interrupt number during initialization

2020-04-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currnetly, based on hns3 VF device error may occur during initialization. The root cause as below: When the following fomula is excuted during initialization, the private variable named hw->tqps_num has not been obtained from PF driver through mailbox, f

Re: [dpdk-dev] [PATCH v2 0/2] fixes for bonding

2020-04-29 Thread Wei Hu (Xavier)
Hi, Chas Williams Could you please give some suggestion on them? Thanks. Best Regards Xavier On 2020/4/17 16:19, Wei Hu (Xavier) wrote: This series include two fixes patches for bonding PMD driver. Wei Hu (Xavier) (2): net/bonding: fix MAC address when switching active port

Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-14 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit & Chas Williams Could you please give any suggestion? Thanks. Best Regards Xavier On 2020/4/17 16:58, Wei Hu (Xavier) wrote: Hi, Chas Williams    Thanks for your comments on Patch V1. now we have sent Patch V2.    Could you please give some suggestion on

Re: [dpdk-dev] Fwd: Re: [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-16 Thread Wei Hu (Xavier)
On 2020/5/16 16:59, Wei Hu (Xavier) wrote: Forwarded Message Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets Date: Fri, 15 May 2020 11:46:30 +0100 From: Ferruh Yigit To: Wei Hu (Xavier) , Chas Williams <3ch...@gmail.com&

Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-16 Thread Wei Hu (Xavier)
On 2020/5/16 16:59, Wei Hu (Xavier) wrote: Forwarded Message Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets Date: Fri, 15 May 2020 11:46:30 +0100 From: Ferruh Yigit To: Wei Hu (Xavier) , Chas Williams <3ch...@gmail.com&

Re: [dpdk-dev] Fwd: Re: [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-18 Thread Wei Hu (Xavier)
On 2020/5/18 17:55, Ferruh Yigit wrote: On 5/16/2020 10:51 AM, Wei Hu (Xavier) wrote: On 2020/5/16 16:59, Wei Hu (Xavier) wrote: Forwarded Message Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets Date: Fri, 15 May 2020 11:46:30

[dpdk-dev] [PATCH] maintainers: add Xavier for bonding

2020-05-18 Thread Wei Hu (Xavier)
Adding Xavier as additional maintainer to bonding. Signed-off-by: Wei Hu (Xavier) --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6a14622..46b6535 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -529,6 +529,7 @@ F: doc/guides/nics/features

[dpdk-dev] [PATCH] doc: add release notes for Hisilicon hns3 PMD driver

2020-05-18 Thread Wei Hu (Xavier)
Add release notes for Hisilicon hns3 PMD driver. Signed-off-by: Wei Hu (Xavier) --- doc/guides/rel_notes/release_20_05.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 2e94566..1496e52 100644

[dpdk-dev] [PATCH 5/5] net/hns3: fix key length when configuring RSS

2020-05-22 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index aef301a..e3c2392 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -1475,

[dpdk-dev] [PATCH 2/5] net/hns3: fix promiscuous config not clear for PF on uninit

2020-05-22 Thread Wei Hu (Xavier)
s3: fix Rx queue search with broadcast packet") Fixes: d51867db65c1 ("net/hns3: add initialization") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 53 ++ 1 file chan

[dpdk-dev] [PATCH 4/5] net/hns3: add RSS hash offload to port Rx configuration

2020-05-22 Thread Wei Hu (Xavier)
: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations") Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev_vf.c | 1 +

[dpdk-dev] [PATCH 1/5] net/hns3: replace PF vport id zero with private macro

2020-05-22 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 48 +++--- drivers/net/hns3/hns3_ethdev.h | 3 +++ 2 files changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index a09ac08

[dpdk-dev] [PATCH 3/5] net/hns3: fix preparing sending packets less than 60 bytes

2020-05-22 Thread Wei Hu (Xavier)
packets. So the interception needs to be removed in the '.tx_pkt_prepare' ops implementation function named hns3_prep_pkts. Fixes: de620754a109 ("net/hns3: fix sending packets less than 60 bytes") Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") C

[dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

2020-05-22 Thread Wei Hu (Xavier)
length when configuring RSS Wei Hu (Xavier) (1): net/hns3: fix preparing sending packets less than 60 bytes drivers/net/hns3/hns3_ethdev.c| 102 -- drivers/net/hns3/hns3_ethdev.h| 3 ++ drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

2020-05-22 Thread Wei Hu (Xavier)
On 2020/5/22 19:20, Ferruh Yigit wrote: On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: This series are improvement and bugfixes for hns3 PMD driver. Hi Xavier, We are planning to have the -rc4 this weekend and the release on Tuesday. So we are literally a few days away from the release. It

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

2020-05-27 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/5/27 23:36, Ferruh Yigit wrote: On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: This series are improvement and bugfixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: replace PF vport id zero with private macro net/hns3: fix promiscuous config not clear for

[dpdk-dev] [PATCH v 2/4] net/hns3: fix VLAN strip configuration when setting a PVID

2020-06-03 Thread Wei Hu (Xavier)
Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.

[dpdk-dev] [PATCH v 1/4] net/hns3: remove unsupported VLAN capabilities

2020-06-03 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch removes unsupported vlan capabilities to avoid misleading users. Fixes: a5475d61fa34 ("net/hns3: support VF") Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-of

[dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-03 Thread Wei Hu (Xavier)
an abnormal state. Fixes: 6dca716c9e1d ("net/hns3: support TSO") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/hns3/hns

[dpdk-dev] [PATCH v 0/4] bugfixes for hns3 PMD driver

2020-06-03 Thread Wei Hu (Xavier)
This series are bugfixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: remove unsupported VLAN capabilities net/hns3: fix VLAN strip configuration when setting a PVID Hongbo Zheng (1): net/hns3: add checking tso segsz when sending TSO packets Wei Hu (Xavier) (1): net/hns3: fix

[dpdk-dev] [PATCH v 3/4] net/hns3: fix VLAN tags report in Rx

2020-06-03 Thread Wei Hu (Xavier)
ementation function named hns3_recv_pkts. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavi

[dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-03 Thread Wei Hu (Xavier)
ot;first public release") Fixes: 9eb974221f44 ("app/testpmd: fix statistics after reset") Cc: sta...@dpdk.org Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/c

Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-04 Thread Wei Hu (Xavier)
On 2020/6/5 0:30, Ferruh Yigit wrote: On 6/4/2020 7:22 AM, Wei Hu (Xavier) wrote: Currently, there are coverity defect warnings as blow: Coverity issue: In nic_stats_clear function: CID 290021 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) 5. negative_returns: ret is

[dpdk-dev] [PATCH v2] app/testpmd: fix passing negative parameter to strerror

2020-06-04 Thread Wei Hu (Xavier)
assed to a parameter that cannot be negative. Fixes: da328f7f115a ("ethdev: change xstats reset function to return int") Fixes: 9eb974221f44 ("app/testpmd: fix statistics after reset") Cc: sta...@dpdk.org Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: 1. add a negative

Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 0:56, Ferruh Yigit wrote: On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng Base on hns3 network engine, when the rte_eth_tx_burst API is called by Upper Level Process, if PKT_TX_TCP_SEG flag is set and tso_segsz is 0 in the input parameter structure rte_mbuf

Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 17:44, Ferruh Yigit wrote: On 6/5/2020 9:50 AM, Wei Hu (Xavier) wrote: On 2020/6/5 0:56, Ferruh Yigit wrote: On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng Base on hns3 network engine, when the rte_eth_tx_burst API is called by Upper Level Process, if

[dpdk-dev] [PATCH v3] app/testpmd: fix passing negative parameter to strerror

2020-06-05 Thread Wei Hu (Xavier)
by passing '-ret' to the function strerror() when ret is negative. Fixes: da328f7f115a ("ethdev: change xstats reset function to return int") Fixes: 9eb974221f44 ("app/testpmd: fix statistics after reset") Cc: sta...@dpdk.org Signed-off-by: Wei Hu (Xavier) --- v2

Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 17:25, Ferruh Yigit wrote: On 6/5/2020 3:57 AM, Wei Hu (Xavier) wrote: On 2020/6/5 0:30, Ferruh Yigit wrote: On 6/4/2020 7:22 AM, Wei Hu (Xavier) wrote: Currently, there are coverity defect warnings as blow: Coverity issue: In nic_stats_clear function: CID 290021 (#1

[dpdk-dev] [PATCH 0/4] Bugfixes of coverity defects for hns3 PMD driver

2020-06-09 Thread Wei Hu (Xavier)
This series are bugfixes of coverity defects warning for hns3 PMD driver. Hongbo Zheng (2): net/hns3: avoid unchecked return value in reset err process net/hns3: fix unintended sign extension in dump operation Wei Hu (Xavier) (2): net/hns3: fix passing negative parameter to strerror net

[dpdk-dev] [PATCH 2/4] net/hns3: avoid unchecked return value in reset err process

2020-06-09 Thread Wei Hu (Xavier)
re will be corresponding log information inside hns3_cmd_init. This patch adds '(void)' Type conversion to avoid coverity warnning. Coverity issue: 349934 Fixes: 2790c6464725 ("net/hns3: support device reset") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei

[dpdk-dev] [PATCH 4/4] net/hns3: fix unintended sign extension in dump operation

2020-06-09 Thread Wei Hu (Xavier)
h uint32_t in the inner static function named hns3_get_regs_length of hns3 PMD driver. Coverity issue: 349917, 349914 Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_r

[dpdk-dev] [PATCH 1/4] net/hns3: fix passing negative parameter to strerror

2020-06-09 Thread Wei Hu (Xavier)
There is a coverity defect related "Argument cannot be negative". This patch fixes it by passing '-ret' to the function strerror() when ret is negative. Coverity issue: 349933 Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 3/4] net/hns3: fix unintended sign extension in fd operation

2020-06-09 Thread Wei Hu (Xavier)
placing the data type of port_number and vlan_tag with uint32_t in the inner static function named hns3_fd_convert_meta_data of hns3 PMD driver. Coverity issue: 349937, 349893 Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Wei Hu (Xavier) ---

[dpdk-dev] [PATCH 2/9] net/hns3: replace zero with macro defined in DPDK framework

2020-04-10 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch replaces the specific macro named RTE_INTR_VEC_ZERO_OFFSET provided by DPDK framework instead of the magic number 0. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 8 drivers/net/hns3/hns3_e

[dpdk-dev] [PATCH 1/9] net/hns3: simplify process of some return values

2020-04-10 Thread Wei Hu (Xavier)
From: Lijun Ou Currently, the return value processing of some functions can be combined and the result is that some codes can be optimized. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 28 +--- drivers/net/hns3

[dpdk-dev] [PATCH 0/9] misc updates for hns3 PMD driver

2020-04-10 Thread Wei Hu (Xavier)
after reset net/hns3: fix residual flow directory rules when app restart Lijun Ou (3): net/hns3: simplify process of some return values net/hns3: fix missing RSS in Rx offload capability net/hns3: fix missing length of hash key when getting RSS Wei Hu (Xavier) (1): net/hns3: replace zero

[dpdk-dev] [PATCH 3/9] net/hns3: fix failure when adding a MC MAC address

2020-04-10 Thread Wei Hu (Xavier)
ated operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_ethdev.c| 133 ++--- drivers/net/hns3/hns3_ethdev_vf.c | 231 +++--- 2 files

[dpdk-dev] [PATCH 4/9] net/hns3: fix Rx interrupt after reset

2020-04-10 Thread Wei Hu (Xavier)
lling hns3_dev_all_rx_queue_intr_enable to enable interrupt before enabling queues. 2. After finished the initialization, we can enable queues to work by calling the internal function named hns3_enable_all_queues. Fixes: 02a7b55657b2 ("net/hns3: support Rx interrupt") Signed-off-by: Chengwen Feng Signed

[dpdk-dev] [PATCH 7/9] net/hns3: fix missing length of hash key when getting RSS

2020-04-10 Thread Wei Hu (Xavier)
ned-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_rss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 95a637ddc..a6cab29c9 100644 --- a/driver

[dpdk-dev] [PATCH 5/9] net/hns3: fix residual flow directory rules when app restart

2020-04-10 Thread Wei Hu (Xavier)
ned-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_fdir.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c index ca3c78e1c..53c6448cd 100644 --- a/drivers/net/hns3/hns3_fdir.c +++

[dpdk-dev] [PATCH 8/9] net/hns3: fix default VLAN filter configuration for PF

2020-04-10 Thread Wei Hu (Xavier)
d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 65 -- 1 file changed, 55 insertions(+), 10 deletions(-) diff --git a/drivers/net/hns3/hns3_et

[dpdk-dev] [PATCH 6/9] net/hns3: fix missing RSS in Rx offload capability

2020-04-10 Thread Wei Hu (Xavier)
n function named hns3_dev_infos_get and hns3vf_dev_infos_get for hns3 PF/VF PMD driver. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 3 ++- drivers/net/hns3/hns3_ethdev_v

[dpdk-dev] [PATCH 9/9] net/hns3: fix VLAN filter when setting promisucous mode

2020-04-10 Thread Wei Hu (Xavier)
add start/stop and configure operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 119 + 1 file changed, 91 insertions(+), 28 deletions(-) diff --git a/drivers/net/hns3/hns3_eth

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-11 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/1/28 19:27, Ferruh Yigit wrote: On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_port are not updated after setting mtu successfully in port_mtu_se

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-12 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/2/12 8:25, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/1/28 19:27, Ferruh Yigit wrote: On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_po

[dpdk-dev] [PATCH v2] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-12 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_port are not updated after setting mtu successfully in port_mtu_set function by 'port config mtu ' command. This may lead to reconfig mtu to the initial valu

[dpdk-dev] [PATCH 0/2] fixes for bonding

2020-02-25 Thread Wei Hu (Xavier)
This series include two fixes patches for bonding PMD driver. Wei Hu (Xavier) (2): net/bonding: fix MAC address when switching active port net/bonding: fix MAC address when one port resets drivers/net/bonding/rte_eth_bond_api.c | 1 + drivers/net/bonding/rte_eth_bond_pmd.c | 11

[dpdk-dev] [PATCH 2/2] net/bonding: fix MAC address when one port resets

2020-02-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, in the following 2 cases: 1) The primary port resets. The link status of the primary port changes from up to down. 2) When switching the active port, one slave port resets at the same time. one slave port chan

[dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port

2020-02-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, when the link status of the primary port changes from up to down, one slave port changes to the primary port, but the new primary port's MAC address cannot change to the bond device's MAC address. A

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port

2020-02-27 Thread Wei Hu (Xavier)
Hi,Ferruh Yigit On 2020/2/28 1:03, Ferruh Yigit wrote: On 2/25/2020 9:29 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, when the link status of the primary port changes from up to down, one slave port changes to the primary por

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port

2020-03-01 Thread Wei Hu (Xavier)
Hi, Chas Williams Could you please give some suggestion on these patches? Thanks. Regards Xavier On 2020/2/28 9:31, Wei Hu (Xavier) wrote: Hi,Ferruh Yigit On 2020/2/28 1:03, Ferruh Yigit wrote: On 2/25/2020 9:29 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Curren

Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes

2020-06-18 Thread Wei Hu (Xavier)
Hi, Chas Williams & Sergey Lvov There was a two-patch series about bonding those are still in reviewing state, and the one of them includes the identical modification. Thanks. http://patches.dpdk.org/patch/68742/ The series include two patches: http://patches.dpdk.org/patch/68742/ http://pa

[dpdk-dev] [PATCH 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-18 Thread Wei Hu (Xavier)
Fixes: 81f9db8ecc2c ("ethdev: add vlan offload support") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- lib/librte_ethdev/rte_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.c b/l

[dpdk-dev] [PATCH 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-18 Thread Wei Hu (Xavier)
that the local varibale named mbp_buf_size is bigger than RTE_PKTMBUF_HEADROOM. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- lib/librte_ethdev/rte_ethdev.c | 3 ++- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH 0/2] ethdev: minor bugfixes

2020-06-18 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Chengchang Tang (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities lib/librte_ethdev/rte_ethdev.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-19 Thread Wei Hu (Xavier)
Hi, Andrew Rybchenko On 2020/6/19 16:37, Andrew Rybchenko wrote: On 6/19/20 6:42 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start a vlan hardware offloads which the driver does not

[dpdk-dev] [PATCH v2 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-19 Thread Wei Hu (Xavier)
varibale named mbp_buf_size is bigger than RTE_PKTMBUF_HEADROOM. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Andrew Rybchenko --- v1 -> v2: simplify the check condition of mbp_buf_size

[dpdk-dev] [PATCH v2 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-19 Thread Wei Hu (Xavier)
leanup duplicated checks which are done in some PMDs. Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: cleanup duplicated checks which are done in som PMDs. --- drivers/net/d

[dpdk-dev] [PATCH v2 0/2] ethdev: minor bugfixes

2020-06-19 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 5 - drivers/net/enic/enic_ethdev.c | 12

[dpdk-dev] [PATCH v3 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-21 Thread Wei Hu (Xavier)
varibale named mbp_buf_size is bigger than RTE_PKTMBUF_HEADROOM. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Andrew Rybchenko --- v2 -> v3: No change. v1 -> v2: Simplify the ch

[dpdk-dev] [PATCH v3 0/2] ethdev: minor bugfixes

2020-06-21 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 5 - drivers/net/enic/enic_ethdev.c | 12

[dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Wei Hu (Xavier)
f-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko --- v2 -> v3: Add __rte_unused to avoid unused parameter 'dev' and 'mask' warning. v1 -> v2: cleanup duplicated checks which are done in some PMDs. --- drivers/net/dpaa2/dpaa2_ethde

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Wei Hu (Xavier)
Hi, Andrew Rybchenko On 2020/6/21 21:44, Andrew Rybchenko wrote: On 6/20/20 9:53 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wei Hu (Xavier)
Hi, Sachin Saxena On 2020/6/22 13:10, Sachin Saxena (OSS) wrote: On 22-Jun-20 8:17 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD

[dpdk-dev] [PATCH v4 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-22 Thread Wei Hu (Xavier)
varibale named mbp_buf_size is bigger than RTE_PKTMBUF_HEADROOM. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Andrew Rybchenko --- v3 -> v4: No change. v2 -> v3: No change. v1 -> v2:

[dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wei Hu (Xavier)
f-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko Acked-by: Hyong Youb Kim --- v3 -> v4: Delete "next_mask" label and modify the function that when the offload is not supported the function fail. v2 -> v3: Add __rte_unused to avoid

[dpdk-dev] [PATCH v4 0/2] ethdev: minor bugfixes

2020-06-22 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 12 +++- drivers/net/enic/enic_ethdev.c

Re: [dpdk-dev] small error in rte_eth_bond_api.c

2020-06-22 Thread Wei Hu (Xavier)
Hi, Anatoly Dubinsky it looks you are right. Maybe you can send a patch to fix it. Thanks, Xavier On 2020/6/20 2:12, Анатолий Дубинский wrote: Hello! I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c : Func rte_eth_bond_create: ret = rte_vdev_init(name, devargs); if (ret

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-28 Thread Wei Hu (Xavier)
dev: new Rx/Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko Acked-by: Hyong Youb Kim --- v3 -> v4: Delete "next_mask" label and modify the function that when the offload is not support

[dpdk-dev] [PATCH 2/5] net/hns3: fix wrong Tx interrupt when enabling Rx interrupt

2020-03-07 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when receiving and transmitting packets based on hns3 network engine there are probably unexpected and redundant Tx interrupts if Rx interrupt is enabled. The root cause as below: Tx and Rx queues with the same number share the interrupt vector in hn

<    1   2   3   4   5   6   >