Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Sunday, March 25, 2018 5:51 PM
> To: Wang, Xiao W ; dev@dpdk.org
> Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang,
> Cunming ; Xu, Rosen ; Chen,
> Junjie J ; Dal
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Monday, March 26, 2018 9:30 PM
> To: Wang, Xiao W ; dev@dpdk.org
> Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang,
> Cunming ; Xu, Rosen ; Chen,
> Junjie J ; Dal
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Saturday, March 31, 2018 9:16 PM
> To: Maxime Coquelin
> Cc: Wang, Xiao W ; Yigit, Ferruh
> ; dev@dpdk.org; Wang, Zhihong
> ; y...@fridaylinux.org; Tan, Jianfeng
> ; Bie
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Saturday, March 31, 2018 7:27 PM
> To: Wang, Xiao W ; Yigit, Ferruh
>
> Cc: dev@dpdk.org; Wang, Zhihong ;
> y...@fridaylinux.org; Tan, Jianfeng ; Bie, Tiwei
> ; Li
> -Original Message-
> From: Mcnamara, John
> Sent: Monday, October 23, 2017 9:07 PM
> To: Wang, Xiao W ; dev@dpdk.org
> Cc: Wu, Jingjing ; Chen, Jing D
> ; Wang, Xiao W
> Subject: RE: [dpdk-dev] [PATCH 4/4] doc: add switch restart support to fm10k
> guide
&g
> -Original Message-
> From: Bie, Tiwei
> Sent: Friday, November 24, 2017 1:39 PM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread-
> safe
>
> On Fri, Nov 24, 2017 at
> -Original Message-
> From: Bie, Tiwei
> Sent: Friday, November 24, 2017 2:05 PM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] net/virtio: support GUEST ANNOUNCE
>
> Hi,
>
> Some quick comments. Will go
> -Original Message-
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Monday, November 27, 2017 8:49 PM
> To: Wang, Xiao W
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 2/2] net/virtio: support GUEST ANNOUNCE
>
> On Fri, Nov 24, 2017 at 03:04:00AM -0800, X
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, November 30, 2017 10:59 AM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread-
>
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Tuesday, February 6, 2018 10:24 PM
> To: Wang, Xiao W ; dev@dpdk.org
> Cc: Tan, Jianfeng ; Bie, Tiwei ;
> y...@fridaylinux.org; Liang, Cunming ; Daly, Dan
> ; Wang, Z
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Thursday, February 8, 2018 5:09 PM
> To: Wang, Xiao W ; dev@dpdk.org
> Cc: Tan, Jianfeng ; Bie, Tiwei ;
> y...@fridaylinux.org; Liang, Cunming ; Daly, Dan
> ; Wang, Z
Hi,
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, December 12, 2017 9:39 AM
> To: Wang, Xiao W
> Cc: Yigit, Ferruh ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] igb_uio: allow multi-process access
>
> On F
Thanks for pointing it out. Fix it in v3.
BRs,
Xiao
> -Original Message-
> From: Bie, Tiwei
> Sent: Tuesday, December 19, 2017 5:05 PM
> To: Wang, Xiao W
> Cc: Yigit, Ferruh ; dev@dpdk.org;
> step...@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH v2] igb_uio
Hi,
> -Original Message-
> From: Chen, Junjie J
> Sent: Sunday, December 24, 2017 12:56 AM
> To: y...@fridaylinux.org; maxime.coque...@redhat.com; Bie, Tiwei
> ; Wang, Xiao W
> Cc: dev@dpdk.org; Chen, Junjie J
> Subject: [PATCH v5] vhost: support virtqueue i
Hi,
> -Original Message-
> From: Bie, Tiwei
> Sent: Monday, December 4, 2017 4:47 PM
> To: Wang, Xiao W
> Cc: y...@fridaylinux.org; dev@dpdk.org; step...@networkplumber.org
> Subject: Re: [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE
>
> On Mon, Dec 04,
> -Original Message-
> From: Bie, Tiwei
> Sent: Wednesday, December 6, 2017 7:23 PM
> To: Wang, Xiao W
> Cc: y...@fridaylinux.org; dev@dpdk.org; step...@networkplumber.org
> Subject: Re: [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE
>
> On Mon, Dec 04,
> -Original Message-
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Tuesday, December 5, 2017 10:26 PM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; Bie, Tiwei
> Subject: Re: [PATCH 2/2] net/virtio: support GUEST ANNOUNCE
>
> On Thu, Nov 30, 2017 at 02:41:
> -Original Message-
> From: Wang, Xiao W
> Sent: Wednesday, January 3, 2018 9:37 AM
> To: Bie, Tiwei
> Cc: y...@fridaylinux.org; dev@dpdk.org; step...@networkplumber.org
> Subject: RE: [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE
>
> Hi,
>
> > --
Hi Tiwei,
> -Original Message-
> From: Bie, Tiwei
> Sent: Thursday, January 4, 2018 10:51 AM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org; step...@networkplumber.org
> Subject: Re: [PATCH v3 2/2] net/virtio: support GUEST ANNOUNCE
>
> Hi Xiao,
>
Hi,
> -Original Message-
> From: Chen, Junjie J
> Sent: Wednesday, December 27, 2017 1:43 AM
> To: Wang, Xiao W ; y...@fridaylinux.org;
> maxime.coque...@redhat.com; Bie, Tiwei
> Cc: dev@dpdk.org; Chen, Junjie J
> Subject: [PATCH v6] vhost: support virtqueue i
Hi
> -Original Message-
> From: Bie, Tiwei
> Sent: Saturday, January 6, 2018 1:57 AM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org; step...@networkplumber.org
> Subject: Re: [PATCH v5 3/3] net/virtio: support GUEST ANNOUNCE
>
> On Fri, Jan 05,
Hi,
> -Original Message-
> From: Bie, Tiwei
> Sent: Saturday, January 6, 2018 2:01 AM
> To: Wang, Xiao W
> Cc: dev@dpdk.org; y...@fridaylinux.org; step...@networkplumber.org
> Subject: Re: [PATCH v5 2/3] net/virtio: add packet injection method
>
> On Fri, Ja
> -Original Message-
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Monday, January 8, 2018 9:04 PM
> To: Wang, Xiao W
> Cc: Bie, Tiwei ; dev@dpdk.org;
> step...@networkplumber.org
> Subject: Re: [PATCH v6 2/3] net/virtio: add packet injection method
>
Hi,
> -Original Message-
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Monday, January 8, 2018 9:07 PM
> To: Wang, Xiao W
> Cc: Bie, Tiwei ; dev@dpdk.org;
> step...@networkplumber.org
> Subject: Re: [PATCH v6 1/3] net/virtio: make control queue thread-saf
> -Original Message-
> From: Wang, Xiao W
> Sent: Monday, January 8, 2018 11:12 PM
> To: Yuanhan Liu
> Cc: Bie, Tiwei ; dev@dpdk.org;
> step...@networkplumber.org
> Subject: RE: [PATCH v6 2/3] net/virtio: add packet injection method
>
>
>
> >
names in
DEBUGFUNC(), duplicate comments and a stubbed-out header comment for
fm10k_sm_mbx_init.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 61 ++
drivers/net/fm10k/base/fm10k_mbx.h | 4 +--
drivers/net/fm10k/base/fm10k_pf.c | 12
The vid variable name is shorthand for VLAN ID, so we should use this in
comments explaining what is happening.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b
tures correctly")
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.h
b/drivers/net/fm10k/base/fm10k_pf.h
index 92e2962..ee8527a 100644
--- a/drivers/net/fm10k/base/fm10k_
The upstream Linux kernel community prefers constants are to the right of
binary operators.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base
checkpatch warns about lines over 80 characters.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 2 +-
drivers/net/fm10k/base/fm10k_pf.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_mbx.c
b/drivers/net/fm10k/base
-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.h | 7 --
drivers/net/fm10k/base/fm10k_osdep.h | 32 +
drivers/net/fm10k/base/fm10k_pf.h| 4 --
drivers/net/fm10k/base/fm10k_type.h | 132 ---
4 files changed, 32 insertions(+), 143 deletions
: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
drivers/net/fm10k/base/fm10k_tlv.c | 24
drivers/net/fm10k/base/fm10k_type.h | 18 --
3 files changed, 30 insertions(+), 24 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b
Remove the unused element request_lport_map in struct fm10k_mac_ops.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fm10k/base/fm10k_type.h
b/drivers/net/fm10k/base/fm10k_type.h
index f807216..3fc8f13 100644
Hi,
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, February 26, 2016 12:14 AM
> To: Chen, Jing D
> Cc: Thomas Monjalon ; Wang, Xiao W
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding
>
> On Thu,
Hi,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, February 26, 2016 5:06 PM
> To: Wang, Xiao W
> Cc: Richardson, Bruce ; Chen, Jing D
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable
> -Original Message-
> From: Richardson, Bruce
> Sent: Saturday, February 27, 2016 12:33 AM
> To: David Marchand
> Cc: Wang, Xiao W ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding
>
> On Fri, Feb 26, 2016 at
in FTAG rather than mac and vlan table.
To activate this feature, user needs to turn CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD
to y in common_linuxapp or common_bsdapp. Currently this feature is supported
only on PF.
Signed-off-by: Wang Xiao W
---
config/common_bsdapp | 1 +
config
port by
the switch without changing the destination mac address.
Signed-off-by: Wang Xiao W
---
app/test/Makefile | 1 +
app/test/test_fm10k_ftag.c | 253 +
2 files changed, 254 insertions(+)
create mode 100644 app/test/test_fm10k_ftag.c
diff
This is a RFC patch set for FTAG based forwarding feature of RRC.
Wang Xiao W (3):
fm10k: enable FTAG based forwarding
fm10k: add a unit test for FTAG based forwarding
doc: add introduction for fm10k FTAG based forwarding
app/test/Makefile | 1 +
app/test
Add a brief introduction on FTAG, describes what's FTAG and how it works
in forwarding, introduction on how to run fm10k with FTAG is also included.
Signed-off-by: Wang Xiao W
---
doc/guides/nics/fm10k.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/doc/guides
Hi, John
> -Original Message-
> From: Mcnamara, John
> Sent: Tuesday, January 12, 2016 10:16 PM
> To: Wang, Xiao W ; Chen, Jing D
> ; Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [RFC PATCH 3/3] doc: add introduction for fm10k
&g
This shared code update patch set has passed the regression test.
Wang Xiao W (16):
fm10k/base: cleanup namespace pollution and correct typecast
fm10k/base: use bitshift for itr_scale
fm10k/base: reset max_queues on init_hw_vf failure
fm10k/base: document ITR scale workaround in VF TDLEN
ivers with custom SR-IOV
message handlers can strip it.
remove unused struct element in struct fm10k_mac_ops.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 10 ++
drivers/net/fm10k/base/fm10k_pf.h | 4 ++--
drivers/net/fm10k/base/fm10k_tlv.c
path since that will already be the default Gen3 case.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 6 +++---
drivers/net/fm10k/base/fm10k_vf.c | 4
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_type.h
b/drivers/net/
ut, if its error code is not properly handled
the VF driver may still believe it has queues which no longer belong to
it. Fix this by clearing the hw->mac.max_queues on exit due to errors.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_vf.c | 13 ++---
1 file changed, 10 i
Add comments which properly explain the undocumented use of bits in
TDLEN register prior to VF initializing it to the correct value. Note
that the mechanism is entirely software-defined and explain its purpose
to help reduce confusion in the future.
Signed-off-by: Wang Xiao W
---
drivers/net
Cleanup lines over 80 characters.
Cleanup useless else, checkpatch warns that else is not generally
useful after a break or return.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 2 +-
drivers/net/fm10k/base/fm10k_pf.c | 19 ++-
2 files changed, 11
Linux kernel community prefers avoiding CamelCase in
variables, function names, etc.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
drivers/net/fm10k/base/fm10k_tlv.c | 24
drivers/net/fm10k/base/fm10k_type.h | 18 --
3
The upstream Linux kernel community prefers avoiding CamelCase in
variables, function names, etc.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 14 +++---
drivers/net/fm10k/fm10k_ethdev.c| 24
2 files changed, 19 insertions(+), 19
Use memcpy instead of copying MAC address byte-by-byte.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base/fm10k_pf.c
index 7d48210..a1469aa
e function call. Add a NO_IS_SLOT_APPROPRIATE_CHECK
definition which can be defined during strip process to remove the code.
If left undefined (the default) then the code will all be active and no
driver changes should be necessary.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_
The vid variable name is shorthand for VLAN ID, so we should use this in
comments explaining what is happening.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b
names in DEBUGFUNC(),
duplicate comments and a stubbed-out header comment for fm10k_sm_mbx_init.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 61 ++
drivers/net/fm10k/base/fm10k_mbx.h | 4 +--
drivers/net/fm10k/base/fm10k_pf.c | 12
added that had a u8 or similar sticking on the end things
would break. Fix this by using 4byte alignment which will prevent the
TLV LE_STRUCT code from breaking. Update the comment explaining that we
need 4byte alignment of our structures.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base
The upstream Linux kernel community prefers constants are to the right of
binary operators.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base
Some cleanups to better reflect the code that was actually pushed out to
the upstream Linux community.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.h | 7 --
drivers/net/fm10k/base/fm10k_pf.h | 4 --
drivers/net/fm10k/base/fm10k_type.h | 132
Some macros such as FM10K_RXINT_TIMER_SHIFT are removed in the share
code drop, but they are needed in dpdk/fm10k. This patch put all these
necessary macros into fm10k_osdep.h
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_osdep.h | 30 ++
1 file changed
The new share code makes fm10k_msg_update_pvid_pf function static, so we can
not refer to it now in fm10k_ethdev.c. The registered pf handler is almost the
same as the default pf handler, removing it has no impact on mailbox.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/fm10k_ethdev.c | 17
Hi Bruce,
> -Original Message-
> From: Richardson, Bruce
> Sent: Saturday, January 23, 2016 5:32 AM
> To: Wang, Xiao W
> Cc: Chen, Jing D ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 15/16] fm10k: use default mailbox message
> handler for pf
>
> On Thu,
This patch set adds support for FTAG based forwarding in fm10k. This feature
is a particularity of fm10k, so I add an introduction for it in fm10k.rst.
A FTAG unit test is kept internally for feature testing, it's not included
in the patch set due to the particularity.
Wang Xiao W (3):
in FTAG rather than mac and vlan table.
To activate this feature, user needs to turn
``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD``
to y in common_linuxapp or common_bsdapp. Currently this feature is supported
only on PF, because FM10K_PFVTCTL register is read-only for VF.
Signed-off-by: Wang Xiao W
Add a brief introduction on FTAG, describe what's FTAG and how it works
in forwarding.
Signed-off-by: Wang Xiao W
---
doc/guides/nics/fm10k.rst | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst
index 42
Update the release note.
Signed-off-by: Wang Xiao W
---
doc/guides/rel_notes/release_2_3.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/doc/guides/rel_notes/release_2_3.rst
index 99de186..2c8b6f9 100644
--- a/doc/guides/rel_notes/release_2_3.rst
> -Original Message-
> From: Richardson, Bruce
> Sent: Wednesday, January 27, 2016 4:17 AM
> To: Wang, Xiao W
> Cc: Chen, Jing D ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 15/16] fm10k: use default mailbox message
> handler for pf
>
> On Mon, Jan 2
v2:
* Put the two extra fix patches ahead of the base code patches.
Wang Xiao W (16):
fm10k: use default mailbox message handler for pf
fm10k/base: add macro definitions that are needed
fm10k/base: cleanup namespace pollution and correct typecast
fm10k/base: use bitshift for itr_scale
The new share code makes fm10k_msg_update_pvid_pf function static, so we can
not refer to it now in fm10k_ethdev.c. The registered pf handler is almost the
same as the default pf handler, removing it has no impact on mailbox.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/fm10k_ethdev.c | 17
Some macros such as FM10K_RXINT_TIMER_SHIFT are removed in the share
code drop, but they are needed in dpdk/fm10k. This patch put all these
necessary macros into fm10k_osdep.h
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_osdep.h | 30 ++
1 file changed
ivers with custom SR-IOV
message handlers can strip it.
remove unused struct element in struct fm10k_mac_ops.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 10 ++
drivers/net/fm10k/base/fm10k_pf.h | 4 ++--
drivers/net/fm10k/base/fm10k_tlv.c
path since that will already be the default Gen3 case.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 6 +++---
drivers/net/fm10k/base/fm10k_vf.c | 4
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_type.h
b/drivers/net/
ut, if its error code is not properly handled
the VF driver may still believe it has queues which no longer belong to
it. Fix this by clearing the hw->mac.max_queues on exit due to errors.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_vf.c | 13 ++---
1 file changed, 10 i
Add comments which properly explain the undocumented use of bits in
TDLEN register prior to VF initializing it to the correct value. Note
that the mechanism is entirely software-defined and explain its purpose
to help reduce confusion in the future.
Signed-off-by: Wang Xiao W
---
drivers/net
Cleanup lines over 80 characters.
Cleanup useless else, checkpatch warns that else is not generally
useful after a break or return.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 2 +-
drivers/net/fm10k/base/fm10k_pf.c | 19 ++-
2 files changed, 11
Linux kernel community prefers avoiding CamelCase in
variables, function names, etc.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
drivers/net/fm10k/base/fm10k_tlv.c | 24
drivers/net/fm10k/base/fm10k_type.h | 18 --
3
The upstream Linux kernel community prefers avoiding CamelCase in
variables, function names, etc.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 14 +++---
drivers/net/fm10k/fm10k_ethdev.c| 24
2 files changed, 19 insertions(+), 19
Use memcpy instead of copying MAC address byte-by-byte.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base/fm10k_pf.c
index 7d48210..a1469aa
e function call. Add a NO_IS_SLOT_APPROPRIATE_CHECK
definition which can be defined during strip process to remove the code.
If left undefined (the default) then the code will all be active and no
driver changes should be necessary.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_
The vid variable name is shorthand for VLAN ID, so we should use this in
comments explaining what is happening.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b
names in DEBUGFUNC(),
duplicate comments and a stubbed-out header comment for fm10k_sm_mbx_init.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 61 ++
drivers/net/fm10k/base/fm10k_mbx.h | 4 +--
drivers/net/fm10k/base/fm10k_pf.c | 12
added that had a u8 or similar sticking on the end things
would break. Fix this by using 4byte alignment which will prevent the
TLV LE_STRUCT code from breaking. Update the comment explaining that we
need 4byte alignment of our structures.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base
Some cleanups to better reflect the code that was actually pushed out to
the upstream Linux community.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.h | 7 --
drivers/net/fm10k/base/fm10k_pf.h | 4 --
drivers/net/fm10k/base/fm10k_type.h | 132
The upstream Linux kernel community prefers constants are to the right of
binary operators.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base
a notice in the doc to emphasize that application should ensure
an appropriate FTAG for every frame in FTAG based forwarding mode.
Wang Xiao W (3):
fm10k: enable FTAG based forwarding
doc: add introduction for fm10k FTAG based forwarding
doc: update release note for fm10k FTAG suppo
in FTAG rather than mac and vlan table.
To activate this feature, user needs to pass a devargs parameter to eal
for fm10k device like "-w :84:00.0,enable_ftag=1". Currently this
feature is supported only on PF, because FM10K_PFVTCTL register is
read-only for VF.
Signed-off-by: W
Add a brief introduction on FTAG, describe what's FTAG and how it works
in forwarding.
Signed-off-by: Wang Xiao W
---
doc/guides/nics/fm10k.rst | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst
Update the 16_04 release note.
Signed-off-by: Wang Xiao W
---
doc/guides/rel_notes/release_16_04.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/guides/rel_notes/release_16_04.rst
b/doc/guides/rel_notes/release_16_04.rst
index 73494f9..c3ee8b1 100644
--- a/doc/guides/rel_notes
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, March 1, 2016 3:36 PM
> To: Wang, Xiao W
> Cc: dev at dpdk.org; Chen, Jing D
> Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding
>
> 201
Hi,
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, March 2, 2016 6:38 AM
> To: Wang, Xiao W
> Cc: Chen, Jing D ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding
>
ot; instead of -1 in VF FTAG use case.
v2:
* Gave an error message for VF FTAG use case.
* Added a notice in the doc to emphasize that application should ensure
an appropriate FTAG for every frame in FTAG based forwarding mode.
Wang Xiao W (2):
fm10k: enable FTAG based forwarding
doc: add in
in FTAG rather than mac and vlan table.
To activate this feature, user needs to pass a devargs parameter to eal
for fm10k device like "-w :84:00.0,enable_ftag=1". Currently this
feature is supported only on PF, because FM10K_PFVTCTL register is
read-only for VF.
Signed-off-by: W
Add a brief introduction on FTAG, describe what's FTAG and how it works
in forwarding.
Signed-off-by: Wang Xiao W
---
doc/guides/nics/fm10k.rst | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst
Hi,
> > > +
> > > + err = mbx->ops.write_posted(hw, msgbuf, 2, 0);
> > > + if (err)
> > > + return err;
> > > +
> > > + err = mbx->ops.read_posted(hw, msgbuf, 2, 0);
> >
> > Is it more reasonable to read a message of size 1 than 2? Pf side only
> > write 1 word into mbx.
> Thanks for the c
> -Original Message-
> From: Richardson, Bruce
> Sent: Tuesday, March 8, 2016 9:24 PM
> To: Wang, Xiao W ; Chen, Jing D
>
> Cc: Chen, Jing D ; dev at dpdk.org; He, Shaopeng
>
> Subject: Re: [PATCH v3 00/18] fm10k: update shared code
>
> On Fri, Feb 19,
Hi Mark,
> -Original Message-
> From: Chen, Jing D
> Sent: Tuesday, March 8, 2016 10:25 PM
> To: Wang, Xiao W ; Richardson, Bruce
>
> Cc: dev at dpdk.org; He, Shaopeng
> Subject: RE: [PATCH v3 00/18] fm10k: update shared code
>
> Hi, Xiao
>
> >
-Original Message-
From: Zhang, Helin
Sent: Saturday, October 10, 2015 11:57 AM
To: Wang, Xiao W; dev at dpdk.org
Subject: RE: [dpdk-dev] [PATCH] e1000: enable igb TSO support
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wang Xiao W
This patch enables igb TSO feature, the feature works on both PF and VF.
The TCP segmentation offload needs to write the offload related information
into the advanced context descriptors, which is similar to checksum offload.
Signed-off-by: Wang Xiao W
---
drivers/net/e1000/igb_ethdev.c | 6
Signed-off-by: Wang Xiao W
---
doc/guides/rel_notes/release_2_2.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides/rel_notes/release_2_2.rst
index 5687676..74ebd49 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides
v2:
* Reworded the old comment about union igb_vlan_macip which was no more used.
* Corrected typo in line "There're some limitaions in hardware for TCP
segmentaion offload".
* Added "unlikely" in check_tso_para function.
v1:
* Initial version for igb TSO feature.
v2:
* Updated release note for the new feature.
* Added "likely" in TSO parameters checking.
v1:
* Initial version for fm10k TSO feature.
Wang Xiao W (2):
fm10k: enable TSO support
doc: update release note for fm10k TSO support
doc/guides/rel_notes/release_2_2.rst | 4
d
This patch enables fm10k TSO feature for both non-tunneling packet
and tunneling packet.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_osdep.h | 5 +
drivers/net/fm10k/fm10k_ethdev.c | 3 ++-
drivers/net/fm10k/fm10k_rxtx.c | 21 ++---
3 files
Signed-off-by: Wang Xiao W
---
doc/guides/rel_notes/release_2_2.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides/rel_notes/release_2_2.rst
index 5687676..ab01ebb 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides
101 - 200 of 345 matches
Mail list logo
